Deploy Checklist: New Expensify 2021-08-25

[OSBotify]

Release Version: 1.0.90-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• [CP Staging] Remove duplicate form fields #4117
• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• Fix staging due to undefined Onyx key #4286
• Fix broken list components on staging #4300
• Patch for PR #4190  #4322
• Update getPullRequestsMergedBetween to run pre-set string command #4336
• Update XCode to fix iOS deploy #4339
• Fix User is able to upload a file larger than 50mb #4358
• Fix: Selecting a language does not update in real time #4366
• Fix: Infinite loader on login #4397
• add autofocus #4402
• Ping ApplauseLeads when PRs get CPed #4414
• Attempt at fixing race #4416
• Race fix attempt 2 #4436
• fix: message alignment #4503
• Allow users to login with validate code and be redirected to Workspace/Card modal #4519
• Fix the text style in about page #4522
• [No QA] Make a dummy change for a test PR #4568
• Fix ExpensiInput autoFocus & tab Focus #4593
• Hide Password mismatch incase both the passwords are empty #4607
• Check for value before checking length #4613
• Clear storage immediately on sign out #4614
• Fix: autofill on the BaseExpensiInput #4632
• Update state picker component in VBA flow #4633
• Changed Personal and Company Address Labels #4636
• Add Guides call request flow to workspace card configuration screen #4637
• Change picker value color #4641
• update copy for login #4644
• don't show user while searching #4647
• Hide automated accounts from Recent sections of Split Money/Request Money #4648
• Multiline for ExpensiTextInput #4649
• Added tooltips to all Icon buttons #4661
• Update withOnyx to fix prop dependent key updates #4676
• [CP Staging] Use props not state in NewPasswordForm #4684
• Fix context-menu on native devices #4687
• Add capatilisation to translation & some margin for the input #4688
• Search label removed, added no results found instead #4689
• select default/local currency #4691
• [No QA] Make Firebase traces an opt-in feature of global Timing class #4697
• Bump Onyx version to fix recent regressions #4706
• Only trigger deploy blocker notifications on issues #4707
• Exclude cards that are not activated #4720
• Fix enable payments page with another Onyx update #4721
• [NO QA] Document why we pass the currentDate but we don't use it #4724
• [NO QA] Update the PR template to enforce issue linking formatting #4725
• Change UI view for Attachments in Chat #4736
• Increase to 5 seconds #4740
• Handle errorText in TextInputWithLabel #4741
• Display the /bank-account/requestor page #4742
• Bumped expensify-common(Supports nested markdown links) #4750
• Update CONTRIBUTING.md #4751
• Hide localtime for Expensify Emails (Automated Accounts) #4755
• [No QA] Post deploy announcements in slack #4757
• [No QA] Performance tracking with flipper-plugin-performance #4760
• Fix StagingDeployBlocker where chat draft message is kept in the test input while switching chats #4761
• Added translations for CompanyStep #4765
• [No QA] Tag mobile deployers instead of @here in #announce for deploy failures #4767
• Refactor the componentDidUpdate method for ReportActionCompose #4768
• Web - Attachments Preview_3901 #4769
• Fix MarkerBadge Count #4773
• Fix: marker is not clickable on android #4774
• Added translations for "edited" label in chats #4776
• call debounce only when it's required #4777
• Block system user from Inviting into Workspace #4781
• Reduced emoji spacing and increased emoji size #4782
• Update height of default buttons to to match the text inputs #4792
• New breakpoint for tablet size #4793
• Fix: IOU - Final review modal design #4795
• Update NewDot deploy permissions. #4796
• Update StagingDeployCash for manual cherry-picks #4798
• #4517 update timezone on user activity #4799
• [No QA] Fix regression on web due to #4760 #4800
• Fix Web Safari Signin page layout #4802
• Remove expensifySMS domain from the request IOU page #4803
• Update fastlane version #4804
• Bank account load animation issue #4696 #4805
• Add missing period to preferences page #4806
• Remove unnecessary style causing bug in android #4807
• fix Locale Picker and small picker styles #4810
• Revert "Update StagingDeployCash for manual cherry-picks" #4815
• Fixed tooltip pointer in left/right-aligned tooltips #4820
• Fix owner to fix 404 when trying to comment #4824
• [No QA] Announce CP failures in the #announce Slack channel #4829
• Fix syntax error in GitHub action expression #4833
• Trim long workspace name #4835
• Styles h3/h4 missing bold fixed for web, desktop, iOS #4839
• Fixed icon alignment on ReportComposeAction #4851
• Stop automatically creating a workspace when landing on an invalid url #4852
• Update capitalization of copy to match new guidelines #4854
• Remove onSubmitEditing if submit button disabled #4858
• Update the HTML entity parsing #4859
• Fix autocomplete issue in VBA flow #4862
• fix count when LHN is open on mobile #4865
• Download Filename and Tooltip to Download #4871
• Fix notification preference selector label #4872
• Prioritize reports with draft comments in the Most Recent priority mode #4873
• Remove Growl from VBA flow, for non-server errors #4875
• Ensure Requestor Info validation shows error growl #4879
• Password Error message Translation on Language change #4880
• Prevent errorAttemptsCount from being wiped out by JSON.stringify #4889
• Update CONTRIBUTING.md #4893
• Hopefully fix persistent splash screen #4895
• Fixed alignment issue for Workspace name #4901
• remove sms domain from login #4907
• dlt the comment when it's empty #4909
• Add string comparison to boolean expressions #4915
• Revert regex changes for comment #4917
• Remove redundant placeholder for login form #4918
• Add icons to buttons, fix inboxcallbutton text size #4919
• Link Workspace ID to reimbursement account setup so it is accessible during validation step #4923
• [No QA] Use pretext in chrerry pick workflow to tag mobile-deployers #4925
• Properly JSON-decode outputs #4927
• Make dummy change in README #4931
• Make dummy change #4934
• [No QA] Use fromJSON in platformDeploy.yml #4940
• Workspace Admin Translation fix, few es copy changes #4954
• Grab iOS version from release event #4957
• Allow builds to distribute to external testers #4961
• Remove internationalization beta #4967

Deploy Blockers:

• [Apple rejecting release] Investigate splash screen issue with apple test credentials #4608
• Android - Left half of the new message badge is unresponsive  #4716
• [HOLD for payment 2021-09-28] If you mark a message as unread and close the app or minimize it, the unread status is removed. #4855
• Chat - Incorrect number of new messages are shown in green marker badge count #4863
• Download file doesn't have the same name as preview #4868
• Chat - Clicking on download does not show same filename as in the preview #4869
• Chat - Additional lines are shown when editing a text with markdown type Quote #4898
• Login form - No option to change the password in login and password entry form #4958

cc @Expensify/applauseleads

[isagoico]

Checking off these PRs that were incorrectly added to the list:

1. Add offline message to IOU and Split bill and allow currency selection while offline #4019
2. [CP Staging] Remove duplicate form fields #4117
3. fix: paste and Ctrl+z #4131
4. Modify line height so text does not get cut off in LHN #4143
5. Make sure we get state/status from the right variable name when we get chat report name #4239
6. Web - Settings - Dropdown symbol overlaps with text in the box #4243
7. Fix staging due to undefined Onyx key #4286
8. Fix broken list components on staging #4300
9. Patch for PR #4190  #4322
10. Update getPullRequestsMergedBetween to run pre-set string command #4336
11. Update XCode to fix iOS deploy #4339
12. Fix User is able to upload a file larger than 50mb #4358
13. Fix: Selecting a language does not update in real time #4366
14. Fix: Infinite loader on login #4397
15. Attempt at fixing race #4416
16. Race fix attempt 2 #4436
17. fix: message alignment #4503
18. [No QA] Make a dummy change for a test PR #4568
19. Fix ExpensiInput autoFocus & tab Focus #4593
20. Hide Password mismatch incase both the passwords are empty #4607
21. Check for value before checking length #4613
22. Clear storage immediately on sign out #4614
23. Fix: autofill on the BaseExpensiInput #4632
24. Update state picker component in VBA flow #4633
25. Changed Personal and Company Address Labels #4636
26. [CP Staging] Use props not state in NewPasswordForm #4684

[isagoico]

Starting QA 🚀

[isagoico]

Another batch of PRs that were incorrectly added:

1. Update withOnyx to fix prop dependent key updates #4676
2. [CP Staging] Use props not state in NewPasswordForm #4684
3. Bump Onyx version to fix recent regressions #4706
4. Fix enable payments page with another Onyx update #4721
5. Handle errorText in TextInputWithLabel #4741
6. Display the /bank-account/requestor page #4742
7. Fix StagingDeployBlocker where chat draft message is kept in the test input while switching chats #4761
8. Fix: marker is not clickable on android #4774
9. Update fastlane version #4804
10. Remove unnecessary style causing bug in android #4807

[roryabraham]

Removing the lock label to fix staging deploys

[isagoico]

Everything was a pass here 🎉 https://github.com/Expensify/App/actions/runs/1168597268
Only thing is that I still don't see the "Deployed to staging" messages, can we ignore that and start QA? CC @roryabraham

[roryabraham]

Yes, those will not appear because of the bug that existed when we ran the prod deploy. Ignore and begin QA please.

[isagoico]

Starting QA 🚀

[isagoico]

These PRs are missing QA steps:

1. Trim long workspace name #4835
2. Fixed tooltip pointer in left/right-aligned tooltips #4820
3. New breakpoint for tablet size #4793
4. Added translations for CompanyStep #4765
5. Hide localtime for Expensify Emails (Automated Accounts) #4755
6. Bumped expensify-common(Supports nested markdown links) #4750
7. Change UI view for Attachments in Chat #4736
8. Added tooltips to all Icon buttons #4661
9. Multiline for ExpensiTextInput #4649

[isagoico]

Regression is finished!
Issues found:

1. [HOLD for payment 2021-09-22] Concierge - Request call without phone number leads to infinite loading. In mobile, app crashes #4861
2. [Hold for payment 2021-09-07] Request a call - Phone number is filled in First Name box #4864
3. [HOLD for payment 2021-09-10] Sign in - Error message is not specific if password is not entered #4856
4. Android/Moto G7 - Attaching picture directly from camera will crash the app #4853
5. [HOLD for payment 2021-09-28] If you mark a message as unread and close the app or minimize it, the unread status is removed. #4855
6. Chat - Incorrect number of new messages are shown in green marker badge count #4863 - Failing Fix MarkerBadge Count #4773 (Being worked on at the moment 🎉)
7. Card Screen - p character on 'Help' button is cropped #4866
8. Download file doesn't have the same name as preview #4868 - Failing Change UI view for Attachments in Chat #4736
9. Chat - No tool tip for download icon for docx file #4870

Comments left in PRs:

1. New breakpoint for tablet size #4793 (comment)
2. Exclude cards that are not activated #4720 (comment)

Going to test this once all PRs and deploy blockers are checked off #4824

[isagoico]

#4793 (comment) Resolved - Checking it off

[isagoico]

#4871 (comment) fixed #4868 🎉 Checking them off

[isagoico]

Checking off more PRs that were added because of the CP issue:

1. Web - Attachments Preview_3901 #4769
2. Added translations for "edited" label in chats #4776
3. Block system user from Inviting into Workspace #4781
4. Reduced emoji spacing and increased emoji size #4782
5. Fix Web Safari Signin page layout #4802
6. Bank account load animation issue #4696 #4805
7. fix Locale Picker and small picker styles #4810
8. Styles h3/h4 missing bold fixed for web, desktop, iOS #4839
9. Fixed icon alignment on ReportComposeAction #4851
10. Stop automatically creating a workspace when landing on an invalid url #4852
11. Update capitalization of copy to match new guidelines #4854
12. Remove onSubmitEditing if submit button disabled #4858
13. Update the HTML entity parsing #4859
14. Fix autocomplete issue in VBA flow #4862
15. Prioritize reports with draft comments in the Most Recent priority mode #4873
16. Remove Growl from VBA flow, for non-server errors #4875

[isagoico]

#4865 Was a pass! Checking it off along with #4863

[roryabraham]

Before we close this issue, we should really do some testing of this PR.

[roryabraham]

Checking off #4608 pending prod deploy.

[isagoico]

Looks like #4720 was a pass 🎉
Testing #4824 now

[OSBotify]

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[isagoico]

@roryabraham I think #4824 has to be tested when it hits production (not sure.)
Also for #4796 let me know if this has been tested or if you need me to check it out. The checklist is ready to be closed 🎉 🎉

[roryabraham]

Just FYI there are a number of issues with the deploy process we are working to address.

[roryabraham]

Going to close this to verify that it reopens w/ a comment.

[OSBotify]

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[roryabraham]

Nice, that worked as expected.

[roryabraham]

@isagoico Can you please close this issue w/o any comment for me?

[OSBotify]

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

[roryabraham]

@Expensify/applauseleads There were some issues with our standard deploy process today, and we accidentally ran a production deploy when the issue was closed here. Fortunately, all the code that was deploy was already production-approved, so we got lucky there. 😅 🎉

I am going to remove and re-add the lock label to this checklist, and that will trigger a fresh staging deploy with all the latest changes. It will also add a few PRs to this checklist, which we are going to reuse for the next QA/deploy cycle.

Furthermore, we've put some new safeguards in place so that, going forward, only members of @Expensify/mobile-deployers will be able to close out deploy checklists and trigger a production deploy.

What does this mean for Applause?

• Once the lock-label has been re-added, I will post a link to the staging deploy. Once that has been completed, you have the green-light 🟢 to being regression testing.
• Only re-test individual PRs which are not already checked off on the checklist.
• Going forward, a member of the @Expensify/mobile-deployers team will be responsible for closing the checklist to trigger the production deploy and create a new checklist.

Thanks, and let me know if you have any questions!

[roryabraham]

Trying that one more time after merging #4940

[roryabraham]

Okay, staging deploy for v1.0.90-0 is running here. Once that's done, feel free to begin QA (regression + testing unchecked PRs).

[isagoico]

Starting QA!

[isagoico]

CP issue is back, Checking off:

1. Remove expensifySMS domain from the request IOU page #4803
2. Remove redundant placeholder for login form #4918
3. Add icons to buttons, fix inboxcallbutton text size #4919
4. [No QA] Use pretext in chrerry pick workflow to tag mobile-deployers #4925
5. Workspace Admin Translation fix, few es copy changes #4954
6. Grab iOS version from release event #4957

[isagoico]

We're almost finished with QA, all PRs have been tested and I already updated the checklist with the results.
These 2 PRs have unresolved comments:

1. Refactor the componentDidUpdate method for ReportActionCompose #4768 (comment)
2. Link Workspace ID to reimbursement account setup so it is accessible during validation step #4923 (comment)

#4880 is failing because of #4958 (It's currently being fixed 🎉)

On regression, we haven't found any issues or deploy blocker yet. Still about 25% left in the TestRail.

CC @roryabraham

[roryabraham]

Please retest #4880 / #4958 in version 1.0.90-2, being deployed here

[isagoico]

Checking off #4880 since it's a pass 🎉

[roryabraham]

@TomatoToaster is going to QA #4923 internally, but since it's still hidden behind a beta, I'm not going to block the production deploy on it. So I'm going to go ahead and check it off on the checklist and run a prod deploy.

[isagoico]

@roryabraham We're about to finish the regression testing, only 10% left, should be done in a little bit.

[isagoico]

It's finished! feel free to trigger the Prod deploy 🎉 (no deploy blocker were found!)

[TomatoToaster]

Just noting that this one is QA'ed and passed too: #4923 (comment)

[roryabraham]