Bank account load animation issue #4696

[Santhosh-Sellavel]

Details

Update position of the animated gif added a new header to close the view.
Android Gif Animation was broken, update fresco version to fix it.

Fixed Issues

$ #4696

Tests &QA Steps

1. Open New Expensify
2. Click "+"
3. Click "Create Workspace"
4. Click "Get Started"
5. Bank loading animation view will open

Fixes added to Bank loading animation view :

1. Added a new header with the title One Momentwith the close button.
2. Animated image position will be moved to top-docked
3. One moment... under animated image was remove to avoid redundancy

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Web.mov

Mobile Web

iOS.mov

Desktop

Desktop.mov

iOS

MWeb.mp4

Android

Android.mov

[Santhosh-Sellavel]

@Jag96 this is ready for review!

[Jag96]

This is looking good, I'm just having trouble getting this to run on Android. I'm seeing this error when booting the app:

LOG  Running "NewExpensify" with {"rootTag":1}
WARN  Possible Unhandled Promise Rejection (id: 0):
TypeError: undefined is not a function
TypeError: undefined is not a function
    at sendDataToConnection (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:131284:46)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:131333:40)
    at tryCallOne (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:31831:16)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:31932:27)
    at apply (native)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32372:26)
    at _callTimer (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32260:17)
    at _callImmediatesPass (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32299:17)
    at callImmediates (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:32516:33)
    at __callImmediates (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:6152:35)
    at anonymous (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:5931:34)
    at __guard (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:6135:15)
    at flushedQueue (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:5930:21)
    at invokeCallbackAndReturnFlushedQueue (http://10.0.2.2:8081/index.bundle?platform=android&dev=true&minify=false&app=com.expensify.chat&modulesOnly=false&runModule=true:5923:33)

It seems to be working fine in the PR description gif, @Santhosh-Sellavel are you seeing the same thing? I have no issue running it on main, if you aren't seeing the issue I can ask in slack to see if anybody else can reproduce.

[Jag96]

Remove extra line

[Santhosh-Sellavel]

Will remove it.

[Santhosh-Sellavel]

Removed it

[Santhosh-Sellavel]

It seems to be working fine in the PR description gif, @Santhosh-Sellavel are you seeing the same thing?
I have no issue running it on main, if you aren't seeing the issue I can ask in slack to see if anybody else can reproduce?

What are you asking about here about gif issues or error reproduction?. @Jag96

Gif issue?

Before the fix,
I was able to reproduce consistently in my personal device running android 11 S20 Plus
In simulator running Android 12.0 beta

After the fix,
I verified in both devices it's working fine for me.

Booting up issue - this one?

I facing this issue for few days because the simulator time is not updating properly when I manually update time in settings it works fine.

I can reproduce the error across all branches.

[Jag96]

I facing this issue for few days because the simulator time is not updating properly when I manually update time in settings it works fine. I can reproduce the error across all branches.

@Santhosh-Sellavel can you merge main into your branch and update? I did an npx react-native-clean-project and that fixed the issue I encountered yesterday. I am now seeing the following issue on the CompanyStep, however, which seems to be fixed on main:

Once it's updated I'll fully test the VBA flow to confirm all the screens look good, thanks for bearing with me on this one!

[Santhosh-Sellavel]

@Jag96 No issues 👍

[Jag96]

@Santhosh-Sellavel can you do a git merge main on your branch and push up the changes? Just so I can run through the tests on android for the entire flow, including the Company Step (where I'm getting the autoCompleteType error), not just the first step.

[Santhosh-Sellavel]

Pushed now. @Jag96

[Jag96]

LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Jag96 in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅