Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bank account load animation issue #4696 #4805

Merged
merged 5 commits into from
Aug 27, 2021
Merged

Bank account load animation issue #4696 #4805

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88d4cf9
Animation position changed to top
Santhosh-Sellavel Aug 17, 2021
2e30fab
VBA Loading page updated with header & title
Santhosh-Sellavel Aug 24, 2021
60afb75
Fresco version updated to 2.5.0
Santhosh-Sellavel Aug 24, 2021
492dfe5
Unwanted line removed
Santhosh-Sellavel Aug 26, 2021
66c2262
Merge branch 'main' into BankAccount_Animation_Issue
Santhosh-Sellavel Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ dependencies {
implementation "com.google.firebase:firebase-perf"

// GIF support
implementation 'com.facebook.fresco:fresco:2.3.0'
implementation 'com.facebook.fresco:animated-gif:2.3.0'
implementation 'com.facebook.fresco:fresco:2.5.0'
implementation 'com.facebook.fresco:animated-gif:2.5.0'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it

// Android support library
implementation 'com.android.support:support-core-utils:28.0.0'
Expand Down
14 changes: 9 additions & 5 deletions src/components/VBALoadingIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,20 @@ import styles from '../styles/styles';
import CONST from '../CONST';
import withLocalize, {withLocalizePropTypes} from './withLocalize';
import Text from './Text';
import HeaderWithCloseButton from './HeaderWithCloseButton';
import Navigation from '../libs/Navigation/Navigation';
import ScreenWrapper from './ScreenWrapper';

const propTypes = {
...withLocalizePropTypes,
};

const VBALoadingIndicator = ({translate}) => (
<View style={[StyleSheet.absoluteFillObject, styles.fullScreenLoading]}>
<ScreenWrapper style={[StyleSheet.absoluteFillObject, styles.vbaFullScreenLoading]}>
<HeaderWithCloseButton
title={translate('vbaLoadingAnimation.oneMoment')}
onCloseButtonPress={Navigation.dismissModal}
/>
<View style={[styles.pageWrapper]}>
<Image
source={{uri: `${CONST.CLOUDFRONT_URL}/images/icons/emptystates/emptystate_reviewing.gif`}}
Expand All @@ -19,15 +26,12 @@ const VBALoadingIndicator = ({translate}) => (
]}
/>
<View style={[styles.ph6]}>
<Text style={[styles.textStrong, styles.h3, styles.mb4, styles.mt4, styles.textAlignCenter]}>
{translate('vbaLoadingAnimation.oneMoment')}
</Text>
<Text style={[styles.textAlignCenter]}>
{translate('vbaLoadingAnimation.explanationLine')}
</Text>
</View>
</View>
</View>
</ScreenWrapper>
);

VBALoadingIndicator.propTypes = propTypes;
Expand Down
2 changes: 1 addition & 1 deletion src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ export default {
},
},
vbaLoadingAnimation: {
oneMoment: 'One moment...',
oneMoment: 'One Moment',
explanationLine: 'We’re taking a look at your information. You will be able to continue with next steps shortly.',
},
session: {
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ export default {
},
},
vbaLoadingAnimation: {
oneMoment: 'Un momento...',
oneMoment: 'Un Momento',
explanationLine: 'Estamos verificando tu información y podrás continuar con los siguientes pasos en unos momentos.',
},
session: {
Expand Down
8 changes: 8 additions & 0 deletions src/styles/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1788,6 +1788,14 @@ const styles = {
zIndex: 10,
},

vbaFullScreenLoading: {
backgroundColor: themeColors.componentBG,
opacity: 0.8,
justifyContent: 'flex-start',
alignItems: 'center',
zIndex: 10,
},

hiddenElementOutsideOfWindow: {
position: 'absolute',
top: 0,
Expand Down