Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Post deploy announcements in slack #4757

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Conversation

luacmartins
Copy link
Contributor

cc @roryabraham will you please take a look?

Details

Posts an announcement in the #announce Slack channel after app is deployed to staging and production.

Fixed Issues

$ #4727

Tests

  1. Make sure that the StagingDeployCash is not locked.
  2. Lock the StagingDeployCash, then verify that the resulting staging deploy is announced in #announce.
  3. Merge a PR with the CP Staging label, then verify that the resulting staging deploy is announced in #announce.
  4. Once the deploy checklist is complete and we close it out, verify that the resulting prod deploy is announced in #announce.

QA Steps

None.

Tested On

N/A GitHub only!

@luacmartins luacmartins requested a review from a team August 19, 2021 17:36
@luacmartins luacmartins self-assigned this Aug 19, 2021
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team August 19, 2021 17:36
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also post prod deploys in #expensify-open-source?

Julesssss
Julesssss previously approved these changes Aug 20, 2021
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @luacmartins, I'm unsure how to test this without causing havoc with the current release. Should we merge and use internal testing to verify against the next official release and CP?

@luacmartins luacmartins requested a review from a team as a code owner August 20, 2021 16:22
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team August 20, 2021 16:23
@luacmartins
Copy link
Contributor Author

Updated! Added the step to post prod deploys to #expensify-open-source.

Hi @luacmartins, I'm unsure how to test this without causing havoc with the current release. Should we merge and use internal testing to verify against the next official release and CP?

@Julesssss I think that might be the only way.

@luacmartins luacmartins requested review from Julesssss and roryabraham and removed request for yuwenmemon August 20, 2021 16:24
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with some more emoji

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I agree with @Julesssss that it's lacking in emoji.

Live-testing changes like this always requires some patience and persistence. You don't necessarily have follow the testing instructions to the T in order to verify it works, just remember to verify it when CPs / staging deploys / prod deploys happen.

@Julesssss
Copy link
Contributor

You don't necessarily have follow the testing instructions to the T in order to verify it works, just remember to verify it when CPs / staging deploys / prod deploys happen.

Good points, will keep an eye out for this. Merging now.

@Julesssss Julesssss merged commit f442577 into main Aug 23, 2021
@Julesssss Julesssss deleted the cmartins-slack-message branch August 23, 2021 09:28
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@luacmartins
Copy link
Contributor Author

Seems to be working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants