Fix syntax error in GitHub action expression #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with tests and emojis!! |
AndrewGable
approved these changes
Aug 25, 2021
|
Going to merge this to fix staging deploys and unblock QA |
roryabraham
approved these changes
Aug 26, 2021
|
Looks like the staging deploy is running here |
|
🚀 Deployed to staging by @roryabraham in version: 1.0.87-1 🚀
|
|
Looks like it worked! 🎉 |
|
Now we gotta check the prod deploy messages. |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Coming from here https://expensify.slack.com/archives/C07J32337/p1629913059428800?thread_ts=1629910896.422200&cid=C07J32337
Fixed Issues
$ #4832
Tests
I tested the new syntax here. While that test failed because we don't have the Slack secret in that repo, it did not complain about the syntax and correctly echoed
stagingsince the conditional resolved to false. That seems to have solved the syntax issue here!#announceSlack channel for staging deploys and#announceand#expensify-open-sourcechannels for production deploys.QA Steps
None.
Tested On
N/A GitHub only