Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: autofill on the BaseExpensiInput #4632

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Fix: autofill on the BaseExpensiInput #4632

merged 3 commits into from
Aug 13, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ Fixes #4597

Tests | QA Steps

  1. Open any form on NewDot where data is auto-filled for you on the Web Platform.
  2. Label should be correctly placed.

Tested On

  • Web
  • Mobile Web
  • Desktop

Screenshots

Web | Mobile Web | Desktop

image

@parasharrajat parasharrajat requested a review from a team as a code owner August 12, 2021 22:10
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team August 12, 2021 22:10
@parasharrajat parasharrajat mentioned this pull request Aug 12, 2021
Closed
@Jag96 Jag96 requested a review from Luke9389 August 12, 2021 22:11
@parasharrajat
Copy link
Member Author

parasharrajat commented Aug 12, 2021 •
edited
Loading

Don't forget to CP it or remove the issue from deployblocker list.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@Luke9389
Copy link
Contributor

testing now @parasharrajat

@Luke9389
Copy link
Contributor

Nice job!
Screen Shot 2021-08-12 at 4 11 48 PM

@Luke9389
Copy link
Contributor

Ignoring the Company Address field since I'm fixing that elsewhere 👍

Luke9389
Luke9389 previously approved these changes Aug 12, 2021
View reviewed changes
Jag96
Jag96 suggested changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one request for jsdocs

src/components/ExpensiTextInput/BaseExpensiTextInput.js Outdated
this.deactivateLabel();
}

setValue(v) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add jsdoc for param type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Jag96 Jag96 merged commit ea0fb88 into Expensify:main Aug 13, 2021
github-actions bot pushed a commit that referenced this pull request Aug 13, 2021
@Jag96
Merge pull request #4632 from parasharrajat/newInput
cf583f9 
Fix: autofill on the BaseExpensiInput
(cherry picked from commit ea0fb88)
This was referenced Aug 13, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.0.85-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 17, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.0.85-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 25, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 30, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

This was referenced Sep 1, 2021
Closed
Closed
Closed
@anthony-hull anthony-hull mentioned this pull request Nov 30, 2021
Merged
5 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web - New text input does not work with autofill
5 participants
@parasharrajat @Luke9389 @OSBotify @botify @Jag96