Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string comparison to boolean expressions #4915

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Hopefully fixed a myriad of GH workflow failures caused by this PR

Fixed Issues

$ n/a

Tests

Same as #4796

QA Steps

None.

@roryabraham roryabraham requested a review from a team as a code owner August 30, 2021 17:44
@roryabraham roryabraham self-assigned this Aug 30, 2021
@MelvinBot MelvinBot requested review from flodnv and removed request for a team August 30, 2021 17:44
Copy link
Contributor

@flodnv flodnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are they not real booleans? Is that a GH Actions thing or are we holding it wrong?

@roryabraham
Copy link
Contributor Author

Why are they not real booleans? Is that a GH Actions thing or are we holding it wrong?

I think this is a subtle thing with GH actions where inputs and outputs to jobs and actions are always JSON-encoded. So what was a boolean in one job becomes a string in another

flodnv
flodnv previously approved these changes Aug 30, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham
Copy link
Contributor Author

Let's see if this works 🤞

@roryabraham roryabraham merged commit 337f59c into main Aug 30, 2021
@roryabraham roryabraham deleted the Rory-FixDeployPermissions branch August 30, 2021 18:29
@roryabraham
Copy link
Contributor Author

Seems like it did not work 100%, but has much less severe issues than before: https://github.com/Expensify/App/runs/3465096540?check_suite_focus=true

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.89-0 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants