Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string comparison to boolean expressions #4915

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Add string comparison to boolean expressions #4915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf56c01
Add string comparison to boolean expressions
roryabraham Aug 30, 2021
a615b74
Fix incorrect boolean check swap
roryabraham Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cherryPick.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
createNewVersion:
needs: validateActor
runs-on: ubuntu-latest
if: ${{ needs.validateActor.outputs.IS_DEPLOYER && github.event.inputs.NEW_VERSION == '' }}
if: ${{ needs.validateActor.outputs.IS_DEPLOYER == 'true' && github.event.inputs.NEW_VERSION == '' }}
outputs:
NEW_VERSION: ${{ steps.getNewVersion.outputs.NEW_VERSION }}
steps:
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:

cherryPick:
needs: [validateActor, createNewVersion]
if: ${{ always() && needs.validateActor.outputs.IS_DEPLOYER }}
if: ${{ always() && needs.validateActor.outputs.IS_DEPLOYER == 'true' }}
runs-on: ubuntu-latest
steps:
# Version: 2.3.4
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/finishReleaseCycle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
team: mobile-deployers

- name: Reopen and comment on issue
if: ${{ !steps.validateActor.outputs.isTeamMember }}
if: ${{ steps.validateActor.outputs.isTeamMember == 'false' }}
uses: Expensify/App/.github/actions/reopenIssueWithComment@main
with:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
Expand All @@ -33,15 +33,15 @@ jobs:
Reopening!

- name: Check for any deploy blockers
if: ${{ steps.validateActor.outputs.isTeamMember }}
if: ${{ steps.validateActor.outputs.isTeamMember == 'true' }}
id: checkDeployBlockers
uses: Expensify/App/.github/actions/checkDeployBlockers@main
with:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
ISSUE_NUMBER: ${{ github.event.issue.number }}

- name: Reopen and comment on issue
if: ${{ steps.validateActor.outputs.isTeamMember && steps.checkDeployBlockers.outputs.HAS_DEPLOY_BLOCKERS == 'true' }}
if: ${{ steps.validateActor.outputs.isTeamMember == 'true' && steps.checkDeployBlockers.outputs.HAS_DEPLOY_BLOCKERS == 'true' }}
uses: Expensify/App/.github/actions/reopenIssueWithComment@main
with:
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
Expand All @@ -54,7 +54,7 @@ jobs:
updateProduction:
runs-on: ubuntu-latest
needs: validate
if: ${{ needs.validate.outputs.isValid }}
if: ${{ needs.validate.outputs.isValid == 'true' }}
steps:
- uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
with:
Expand All @@ -72,7 +72,7 @@ jobs:
createNewStagingDeployCash:
runs-on: macos-11
needs: validate
if: ${{ needs.validate.outputs.isValid }}
if: ${{ needs.validate.outputs.isValid == 'true' }}
steps:
# Version: 2.3.4
- uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/platformDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
android:
name: Build and deploy Android
needs: validateActor
if: ${{ needs.validateActor.outputs.IS_DEPLOYER }}
if: ${{ needs.validateActor.outputs.IS_DEPLOYER == 'true' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
desktop:
name: Build and deploy Desktop
needs: validateActor
if: ${{ needs.validateActor.outputs.IS_DEPLOYER }}
if: ${{ needs.validateActor.outputs.IS_DEPLOYER == 'true' }}
runs-on: macos-11
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:
iOS:
name: Build and deploy iOS
needs: validateActor
if: ${{ needs.validateActor.outputs.IS_DEPLOYER }}
if: ${{ needs.validateActor.outputs.IS_DEPLOYER == 'true' }}
runs-on: macos-11
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -232,7 +232,7 @@ jobs:
web:
name: Build and deploy Web
needs: validateActor
if: ${{ needs.validateActor.outputs.IS_DEPLOYER }}
if: ${{ needs.validateActor.outputs.IS_DEPLOYER == 'true' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down