Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification preference selector label #4872

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Fix notification preference selector label #4872

merged 1 commit into from
Aug 29, 2021

Conversation

nkuoch
Copy link
Contributor

@nkuoch nkuoch commented Aug 27, 2021

Fixed Issues

$ #4849

Tests

Went to the announce room and made sure that the notifications selector looked good with the new copies.

QA Steps

None, it's just a copy change

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

In english
image

In spanish
image

@nkuoch nkuoch requested a review from a team as a code owner August 27, 2021 08:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team August 27, 2021 08:24
@nkuoch nkuoch self-assigned this Aug 27, 2021
@nkuoch
Copy link
Contributor Author

nkuoch commented Aug 27, 2021

I have read the CLA Document and I hereby sign the CLA

@nkuoch nkuoch requested review from a team and removed request for a team August 27, 2021 09:11
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnmlee101
Copy link
Contributor

@Luke9389 I'll let you final review?

@nkuoch nkuoch removed the request for review from Luke9389 August 29, 2021 13:10
@nkuoch nkuoch merged commit f928158 into main Aug 29, 2021
@nkuoch nkuoch deleted the nat-notifpref branch August 29, 2021 13:11
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nkuoch in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants