Hide Password mismatch incase both the passwords are empty

[mananjadhav]

@alex-mechler Can you please help review this?

Details

Show Password mismatch error only if New Password is entered.

Regression from #4367

Fixed Issues

$ #4606
$ #4665

Tests

Apart from the test cases mentioned here #4409

1. Tested by keeping New Password and Confirm Password blank onBlur.

QA Steps

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

change-password-val-web.mp4

Mobile Web

change-password-val-mweb.mp4

Desktop

change-password-val-desktop.mp4

iOS

change-password-val-ios.mp4

Android

change-password-val-android.mp4

[parasharrajat]

@mananjadhav You can use the Fixes keyword to close that issue. Fixes #4606

[mananjadhav]

@parasharrajat Okay. Is it that for fresh tasks/issues we don't use Fixes and for regression we do? I am told adding Fixes closes the issue when PR is merged.

[parasharrajat]

No, it's not like that. It is just that there is nothing left to do with that issue after you have merged the fix. So it saves some time. Also, it will create a link between the issue and PR. So anyone can find what fixed it.

[mananjadhav]

Thanks for the tip.

[mananjadhav]

@AndrewGable Can you please review this and probably merge too? #4665 is blocked by this.

[AndrewGable]

Trying to untangle the duplicates before merging this.

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[AndrewGable]

CP-ing to resolve deploy blocker.

[OSBotify]

🚀 Cherry-picked to staging by @AndrewGable in version: 1.0.85-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

[OSBotify]

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @AndrewGable in version: 1.0.85-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊