Password Error message Translation on Language change #4880

mananjadhav · 2021-08-27T16:49:09Z

@Jag96 Can you please review this?

Details

Changed error translation on language change
Also added onBlur to the forms
Hide API error if formError exists

Fixed Issues

$ #4663

Tests

Checked error messages translation on changing the language after the error is shown
Ensure that error hides if the value is entered and textinput is blurred

QA Steps

Go to the Login Form, press the button and the error is shown
After that if the language is changed, then the translation for the password should also be changed

This has to be tested for LoginForm as well as PasswordForm

Tested On

Screenshots

…slation fix

mananjadhav · 2021-08-27T16:50:12Z

@Jag96 In addition to the translation error, I've also fixed two minor UI issues. Updated in the GH body. Please check.

mananjadhav · 2021-08-27T17:09:35Z

@Jag96 @nickmurray47 Do you guys notice that the iOS signing screen is broken on language change? Earlier I thought it was because of my change but it seems to exist on the main branch too.

Update: I've added a fix for the same and pushed it. Attached are the videos for the same. Should we be tracking it outside this PR scope?

https://user-images.githubusercontent.com/3069065/131166578-c94a300f-67c7-44e0-b403-4e8c67153c21.mp4
https://user-images.githubusercontent.com/3069065/131166584-0093ac24-0aa3-4c6e-9f35-61a26cbf6973.mp4

Also, do you think the error message in the PasswordForm should come before the Forgot? link.

Jag96

Update: I've added a fix for the same and pushed it. Attached are the videos for the same. Should we be tracking it outside this PR scope?

Good find! I think it's fine to keep this in this PR if it resolves the issue on all platforms since it's fairly straightforward. If it turns out to be a more complicated issue during testing or if it has other side effects we can move it to its own issue.

Jag96 · 2021-08-27T18:20:22Z

src/pages/signin/PasswordForm.js

     */
-    validateAndSubmitForm() {
+
+    isFormValid() {


Can we remove this function and the onBlur for both forms? I don't think it makes sense to add it here because in the case that the user has 2fa, when they click outside of the password field into the 2fa field they will see an error before they even submit the form. Additionally, on the loginForm there is only one input field so it doesn't make sense to onBlur there until the user submits the form. We also don't have this functionality for all inputs across the app, so I think we can just stick to the previous functionality of waiting to verify after submit is clicked.

Okay I’ll remove onBlur from both the forms

Jag96 · 2021-08-27T18:20:38Z

src/pages/signin/TermsAndLicenses/TermsWithLicenses/index.ios.js

@@ -20,7 +20,7 @@ const TermsWithLicenses = ({translate}) => (
                styles.justifyContentCenter,
            ]}
        >
-            <View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter]}>
+            <View style={[styles.dFlex, styles.flexRow, styles.flexWrap, styles.alignItemsCenter]}>


Nice job finding this one!

mananjadhav · 2021-08-27T18:40:33Z

@Jag96 PR Updated.

Jag96

LGTM, works well!

OSBotify · 2021-08-27T20:15:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-08-30T17:32:12Z

🚀 Deployed to staging by @Jag96 in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

roryabraham · 2021-08-31T20:30:31Z

Looks like this might've been involved with a deploy blocker

roryabraham · 2021-08-31T20:42:46Z

I do notice for sure that errors from the API signin method are not translated.

Jag96 · 2021-08-31T22:11:18Z

I do notice for sure that errors from the API signin method are not translated.

This was not part of the change or requirements for this one, translating errors from the API will have to be a separate issue.

OSBotify · 2021-09-01T01:42:56Z

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mananjadhav · 2021-09-01T04:03:27Z

@roryabraham I saw the marked issue was unrelated to this one and resolved. Let me know if you still need help.

roryabraham · 2021-09-01T05:10:23Z

Thanks @mananjadhav, this PR didn't cause any regressions, so all good here 👍

mananjadhav added 4 commits August 27, 2021 21:29

fix(password-error-trans): Fixed errors with the login form, and tran…

dfa8062

…slation fix

fix(password-error-trans): Fixed translation issue on PasswordForm

f7bb52a

fix(password-error-trans): Hide error onBlur of the form

59e6566

fix(password-error-trans): Avoid showing formError as well as API error

94d1c09

mananjadhav requested a review from a team as a code owner August 27, 2021 16:49

MelvinBot requested review from nickmurray47 and removed request for a team August 27, 2021 16:49

mananjadhav added 2 commits August 27, 2021 23:06

fix(password-error-trans): Return flags in form

753d9b1

fix(password-error-trans): Fix iOS terms overflow

4f9b57f

Jag96 suggested changes Aug 27, 2021

View reviewed changes

fix(password-error-trans): Rolled back isFormValid changes

686100c

Jag96 approved these changes Aug 27, 2021

View reviewed changes

Jag96 merged commit b9300c7 into Expensify:main Aug 27, 2021

OSBotify mentioned this pull request Aug 30, 2021

Deploy Checklist: New Expensify 2021-08-25 #4828

Closed

Jag96 mentioned this pull request Aug 30, 2021

[HOLD for payment 2021-09-10] Sign in - Error message is not specific if password is not entered #4856

Closed

kavimuru mentioned this pull request Aug 31, 2021

Login form - No option to change the password in login and password entry form #4958

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Password Error message Translation on Language change #4880

Password Error message Translation on Language change #4880

mananjadhav commented Aug 27, 2021 •

edited

Loading

mananjadhav commented Aug 27, 2021

mananjadhav commented Aug 27, 2021 •

edited

Loading

Jag96 left a comment

Jag96 Aug 27, 2021

mananjadhav Aug 27, 2021

Jag96 Aug 27, 2021

mananjadhav commented Aug 27, 2021

Jag96 left a comment

OSBotify commented Aug 27, 2021

OSBotify commented Aug 30, 2021

roryabraham commented Aug 31, 2021

roryabraham commented Aug 31, 2021

Jag96 commented Aug 31, 2021

OSBotify commented Sep 1, 2021

mananjadhav commented Sep 1, 2021

roryabraham commented Sep 1, 2021

Password Error message Translation on Language change #4880

Password Error message Translation on Language change #4880

Conversation

mananjadhav commented Aug 27, 2021 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

mananjadhav commented Aug 27, 2021

mananjadhav commented Aug 27, 2021 • edited Loading

Jag96 left a comment

Choose a reason for hiding this comment

Jag96 Aug 27, 2021

Choose a reason for hiding this comment

mananjadhav Aug 27, 2021

Choose a reason for hiding this comment

Jag96 Aug 27, 2021

Choose a reason for hiding this comment

mananjadhav commented Aug 27, 2021

Jag96 left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 27, 2021

OSBotify commented Aug 30, 2021

roryabraham commented Aug 31, 2021

roryabraham commented Aug 31, 2021

Jag96 commented Aug 31, 2021

OSBotify commented Sep 1, 2021

mananjadhav commented Sep 1, 2021

roryabraham commented Sep 1, 2021

mananjadhav commented Aug 27, 2021 •

edited

Loading

mananjadhav commented Aug 27, 2021 •

edited

Loading