Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #4893

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Update CONTRIBUTING.md #4893

merged 1 commit into from
Aug 31, 2021

Conversation

arielgreen
Copy link
Contributor

Per this discussion in Slack: https://expensify.slack.com/archives/C01SKUP7QR0/p1629911987086600

Details

Fixed Issues

$ GH_LINK

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@arielgreen arielgreen requested a review from a team August 27, 2021 23:40
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team August 27, 2021 23:41
@Beamanator Beamanator self-requested a review August 28, 2021 05:54
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 👍

Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Gonna go ahead and merge this for ya

@jasperhuangg jasperhuangg merged commit fdcf519 into main Aug 31, 2021
@jasperhuangg jasperhuangg deleted the arielgreen-patch-1 branch August 31, 2021 01:12
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @jasperhuangg in version: 1.0.90-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants