Prioritize reports with draft comments in the Most Recent priority mode #4873
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
1 similar comment
|
recheck |
|
@iwiznia Requested a review from you as well, since you have reviewed the original proposal. |
| @@ -467,7 +471,15 @@ function getOptions(reports, personalDetails, draftComments, activeReportID, { | |||
| } | |||
| } | |||
|
|
|||
| // If we are prioritizing IOUs the user owes, add them before the normal recent report options | |||
| // If we are prioritizing reports with draft comments, add them before the normal recent report options | |||
There was a problem hiding this comment.
So, drafts will be at the very top, right? I wonder if that's what we want or we rather have IOUs/pinned/defaults.
There was a problem hiding this comment.
Oh, maybe I am wrong, the test seems to contradict me?
There was a problem hiding this comment.
Tested locally and seems good to me function-wise 👍
Edit: Wrong picture here.
There was a problem hiding this comment.
Damn, had it there a sec before taking the screenshot, hold on haha
There was a problem hiding this comment.
ok I figured out this works because we always prepend the arrays, so first one we do is last.
There was a problem hiding this comment.
The code LGTM!
Great job @meetmangukiya for your first PR in this repo! 🎉
| @@ -467,7 +471,15 @@ function getOptions(reports, personalDetails, draftComments, activeReportID, { | |||
| } | |||
| } | |||
|
|
|||
| // If we are prioritizing IOUs the user owes, add them before the normal recent report options | |||
| // If we are prioritizing reports with draft comments, add them before the normal recent report options | |||
There was a problem hiding this comment.
Tested locally and seems good to me function-wise 👍
Edit: Wrong picture here.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@meetmangukiya No problem! I assume you have not been hired on Upwork yet. Jason is based in US West Coast so he should get around to hire you. Although, I am not sure if you have done it as this is your first PR here, have you sent a proposal for the Upwork job posting inside Upwork? Here is the job posting. |
|
Sorry, let's bring this discussion to the original issue! |
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
Details
Prioritizing reports with draft comments on LHN over no priority reports. After this change the priority is Pinned > IOUs > Drafts > everything else.
Fixed Issues
$ #4615
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
Not been able to get android setup running yet on m1