Hide localtime for Expensify Emails (Automated Accounts) #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecanoro
approved these changes
Aug 24, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 24, 2021
|
@mananjadhav Hello! Any QA tests needed for this PR? |
|
@isagoico Updated QA steps |
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
marcaaron
reviewed
Sep 7, 2021
| @@ -11,6 +11,7 @@ import {withNavigationFocus} from '@react-navigation/compat'; | |||
| import _ from 'underscore'; | |||
| import lodashGet from 'lodash/get'; | |||
| import {withOnyx} from 'react-native-onyx'; | |||
| import lodashIntersection from 'lodash/intersection'; | |||
There was a problem hiding this comment.
Not a huge deal, but I think we prefer using underscore over new lodash methods.
There was a problem hiding this comment.
I don't have any current PR related to any related module. I'll raise a separate PR to address this sometime tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pecanoro Can you please review?
Details
Added the expensify emails block from expensify-common and hid the localtime when participants are automated accounts.
Fixed Issues
$ #4664
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android