call debounce only when it's required #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aman-atg please always assign the PR to yourself :) I'll assign it this time for you |
tgolen
approved these changes
Aug 23, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Thanks @tgolen . |
|
I think that's just with issues, I believe you can assign PRs to yourself,
but maybe that's not true anymore. You can try to unassign and reassign
yourself to this PR to test it out.
…On Mon, Aug 23, 2021 at 8:59 AM Aman Ansari ***@***.***> wrote:
Thanks @tgolen <https://github.com/tgolen> .
And I think it's not possible for external contributors to assign
themselves.
Please correct me if that's not true.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4777 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAB7OFL3ZQPWUV6EU2B3T6JO5RANCNFSM5CRWSDVQ>
.
|
|
Yup, no option to assign myself. |
|
huh, OK! I guess that's not the process anymore. Sorry for the confusion!
…On Mon, Aug 23, 2021 at 9:06 AM Aman Ansari ***@***.***> wrote:
[image: Screenshot 2021-08-23 at 8 33 47 PM]
<https://user-images.githubusercontent.com/28243942/130470888-c3656b20-6427-4362-b353-bcda493241ff.png>
Yup, no option to assign myself.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4777 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAB3HLLDWSSM3WSDAHMLT6JPWXANCNFSM5CRWSDVQ>
.
|
5 tasks
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
#4267 (comment)
Fixed Issues
$ #4267
Tests || QA Steps
Use one of the account
*User* is typingafter the message is sent.Tested On
Screenshots
Web
Web.mov
Mobile Web
mWeb.mov
Desktop
Desktop.mov
iOS
IOS.mov
Android
Android.mov