[UX-Improvement] Getting "User is typing" even when they aren't

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to New Expensify in two devices with different accounts
2. Open chat room for both of them

Use one of the account

3. Type your message
4. Press enter
5. It'll show *User* is typing for the second account

Expected Result:

Shouldn't show *User* is typing again

Actual Result:

typingIssue.mp4

Workaround:

Visual Issue

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal

Explaination

• It's happening because when we submit we update the comment here to clear the message
  

  App/src/pages/home/report/ReportActionCompose.js

  Line 419 in d35ab90

  this.updateComment('');

• And because of that we're firing debouncedBroadcastUserIsTyping here. Which ultimately results in unnecessary *User* is typing status
  

  App/src/pages/home/report/ReportActionCompose.js

  Line 310 in d35ab90

  this.debouncedBroadcastUserIsTyping();

Solution

• We can fix this by calling the debouncedBroadcastUserIsTyping function only when the comment is not empty

      if (newComment) {
            this.debouncedBroadcastUserIsTyping();
      }

[flaviadefaria]

Seems less of a priority, but makes sense to fix this.

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

Putting on hold for week-ish while we focus on internal priorities.

[MelvinBot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

Taking off hold.
Agree with @flaviadefaria Seems less of a priority, but makes sense to fix this. (if we can)
@francoisl what do you think?

[francoisl]

Yep I agree too, it's not broken to the point of preventing you from using the app, but it makes sense to fix.

[MelvinBot]

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

@tgolen , I know you're swamped now, no rush on this, it's currently a `weekly', please review @aman-atg 's proposal when ya can. #4267 (comment)

[tgolen]

The proposal looks good to me. 🟢 👍

[mallenexpensify]

d'oh, forgot to paste the Upwork link before. @aman-atg can you apply here plz and drop a comment in this issue once you have? https://www.upwork.com/jobs/~01fecedda11d93aa95

[aman-atg]

Submitted the proposal on Upwork.

[marcaaron]

How accurate do we need to be? This is a chat app not an MMORPG

[aman-atg]

Haha, haven't seen this type of behaviour on any other chat app though.

[marcaaron]

Haha, haven't seen this type of behaviour on any other chat app though.

Do you often chat with yourself when using these other chat apps? To be clear, I don't mind fixing this, but seems unlikely anyone would notice unless they were searching for flaws. I just wonder how many real users would notice or care.

[MelvinBot]

@tgolen, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Hired @aman-atg in Upwork and assigned. Heads ups, we're prioritizing some internal work this week so Tim might not be available for a review til next week.

[aman-atg]

@mallenexpensify, Looks like the proposal was already reviewed. And the PR also got merged 2 days ago.

[mallenexpensify]

Paid @aman-atg in Upwork with the bonus for reporting the issue. Closing cuz the PR looks like it was deployed to production