Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: IOU - Final review modal design #4795

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Fix: IOU - Final review modal design #4795

merged 1 commit into from
Aug 24, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 23, 2021 •
edited
Loading

Details

Please find the details here #3952 (comment)

Fixed Issues

$ #3952

Tests | QA Steps

  1. Log in to new.expensify.com on the mobile web on Android device
  2. Tap on FAB
  3. Tap on Request money
  4. Set an amount and continue
  5. On user search, click on any user with the keyboard open.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Updating shortly...

Web | Desktop

iou-w

Mobile Web

iou-m
iou-mi

iOS

iou-i

Android

iou-a

@parasharrajat parasharrajat requested a review from a team as a code owner August 23, 2021 23:53
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team August 23, 2021 23:53
Luke9389
Luke9389 approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I'll stop back here when you've tested with screenshots. Nice job 👍

@parasharrajat
Copy link
Member Author

All set @Luke9389

@Luke9389 Luke9389 merged commit f8ed9b5 into Expensify:main Aug 24, 2021
@Luke9389
Copy link
Contributor

Nailed it, thanks man 👍

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Aug 24, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parasharrajat @Luke9389 @OSBotify @botify