Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace Admin Translation fix, few es copy changes #4954

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Workspace Admin Translation fix, few es copy changes #4954

merged 1 commit into from
Aug 31, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Aug 31, 2021 •
edited
Loading

@thienlnam

Details

Added translation fix for role Admin in workspace peoples page. Updated a few incorrect translations in en copies in es file.

Fixed Issues

$ #4667

Tests & QA Steps

  1. Go to settings -> Preferreces -> set preferred language as Espanol
  2. Now go back to the Settings page & open the workspace
  3. Tap Personas to see available members in the workspace.

Fix:
4. Role Admin should be translated.

Additionally, updated untranslated copy in es, verify that alone.
Copy is for Beneficial Owners Step page

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-08-31 at 10 31 22 PM

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-08-31 at 22 36 19

Desktop

Screenshot 2021-08-31 at 10 39 34 PM

iOS

Simulator Screen Shot - iPhone 12 - 2021-08-31 at 23 06 23

Android

Screenshot_1630431095

@Santhosh-Sellavel Santhosh-Sellavel marked this pull request as ready for review August 31, 2021 17:57
@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner August 31, 2021 17:57
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team August 31, 2021 17:57
thienlnam
thienlnam approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great

@thienlnam thienlnam merged commit 5bc21cd into Expensify:main Aug 31, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Aug 31, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to staging by @thienlnam in version: 1.0.90-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Santhosh-Sellavel @OSBotify @botify @thienlnam