Ensure Requestor Info validation shows error growl

[Julesssss]

Details

Follow up to this PR, which was accidentally merged early.

Adds the Growl for non-server errors on the Requestor Info VBA step. These errors are not yet displayed in the error Modal, so we need to continue to show with the Growl.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/175331

Tests

0) Test Setup

• Create a new user
• From the global create menu, tap 'New Workspace', then the 'Get Started' button
• Tap 'Connect Manually' and use the data from this StackOverflow post to fill the Routing and Account number

1) Verify that Modal validation errors DO NOT show as a Growl

• Using the stack overflow post, fill each field except 'Company Website', leave that as https://
• Hit 'Save & Continue'
• You should see the Company Website field highlighted red with an error message
• You should see a Modal popup with an error message
• You should NOT see a Growl with the same message

2) Verify that server errors DO show as a Growl

• Continue from the end of test 1
• Enter a valid website
• Set the 'Phone Number' field to 12345678
• Hit 'Save & Continue'
• You should see a Growl with an error message
• You should NOT see the field highlighted red
• You should NOT see a Modal popup

2) Verify that unhandled validation errors DO show as a Growl

• Continue from the end of test 2
• Enter valid information in every field
• Hit 'Save & Continue'
• At the 'Requestor Information' step, enter first and second name only
• Hit 'Save & Continue'
• Fix each error one by one, ensure a Growl message shows for each
• These will be changed to Modal validation in a separate issue

QA Steps

Run above tests

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[Julesssss]

I am currently unable to test mobile web for either Android or Web (slack discussion). So please verify that platform if possible.

[marcaaron]

NAB, maybe something like shouldGrowl be better here since we aren't making assumptions about the kind of error?

[marcaaron]

Not sure if we want to clean this up now, but I think maybe we should. IIRC we should not be waiting for Onyx.merge() promises to resolve.

[marcaaron]

Looks good and tests well!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @marcaaron in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[isagoico]

@Julesssss We will test this via the Bank-account/new flow. Please stop me if it's not acceptable. We currently don't have access to the "Get started" button since all our testing domains already have the expensify card.
Also, since the /Bank-account/new flow requires access to the URL this will only be tested in Web. Please let me know if we're good with this. 🙇

[Julesssss]

Hi @isagoico, that makes sense. Is this how you have tested all other Bank account PRs up to now?

[isagoico]

Yes! we have used this method for those PRs.

[Julesssss]

Thanks, then the plan sounds fine. I'll just tag @MitchExpensify and @kevinksullivan to ensure we test internally in addition.

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅