Stop automatically creating a workspace when landing on an invalid url #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HorusGoul
previously approved these changes
Aug 26, 2021
|
Oops I forgot to remove the import. Silly silly. One sec. |
|
@HorusGoul, ready for another look! (had to also resolve some merge conflicts) |
HorusGoul
approved these changes
Aug 26, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @HorusGoul in version: 1.0.88-3 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We will stop creating a workspace when a user lands tries to access the workspace modal with an invalid policyID. Before when we had the
Create Workspacemodal, this was useful since the user could actively choose to create a workspace if the one they're accessing does not exist. Now, we areFixed Issues
https://github.com/Expensify/Expensify/issues/174834
Tests
Same as QA, done locally
QA Steps
Tested On
Only relevant on Web at the moment.
Screenshots
Web