Only trigger deploy blocker notifications on issues

[AndrewGable]

Details

We were triggering the deploy blocker notifications on PRs which could include forks, which was causing issues here: https://github.com/Expensify/App/actions/runs/1140938643

Tests

1. Merge this PR
2. Add a DeployBlockerCash label to a PR, verify it does not ping in Slack
3. Add a DeployBlockerCash label to a issue, verify it does ping in Slack

[aldo-expensify]

nab: If I'm understanding correctly, we are not listening anymore to events related to pull request, maybe we should comment or remove the lines handling these events:

App/.github/workflows/deployBlocker.yml

Lines 26 to 31 in 8dc03e3

	- name: Get URL, title, & number of new deploy blocker (pull request)
	if: ${{ github.event_name == 'pull_request' }}
	run: |
	echo "DEPLOY_BLOCKER_URL=${{ github.event.pull_request.html_url }}" >> $GITHUB_ENV
	echo "DEPLOY_BLOCKER_NUMBER=${{ github.event.pull_request.number }}" >> $GITHUB_ENV
	echo "DEPLOY_BLOCKER_TITLE=$(sed -e "s/'/'\\\\''/g; s/\`/\\\\\`/g; 1s/^/'/; \$s/\$/'/" <<< "'${{ github.event.pull_request.title }}'")" >> $GITHUB_ENV

The may confuse another developer into thinking that this is still processing pull requests.

Besides that, I don't know how to test this safely. The modified lines make sense to me, but I guess this should be also reviewed by someone else :)

[AndrewGable]

Nice find @aldo-expensify! The linked code is actually dead and I will update to remove it.

[roryabraham]

@AndrewGable I'll hold off on reviewing until you've removed the dead code. Just ping me when it's ready!

[AndrewGable]

Updated

[aldo-expensify]

Looking good to me!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[roryabraham]

Going to use this PR and the linked issue to test this.

[roryabraham]

Yep, that didn't do anything, which is what we want. We could maybe remove the label and leave a comment to explain that only issues (not pull requests) can be deploy blockers. But we don't have to – that's a nice-to-have. What do y'all think?

[roryabraham]

This worked for issues: https://expensify.slack.com/archives/C01GTK53T8Q/p1630438694222000

So this is a QA-pass 🎉

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅