Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context-menu on native devices #4687

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix context-menu on native devices #4687

merged 1 commit into from
Aug 23, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 17, 2021 •
edited
Loading

Details

Fixed Issues

$ #4200

Tests | QA Steps

  1. Open the app in iOS.
  2. Navigate to a conversation.
  3. Long press on a message

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

Screenshot 2021-08-23 18:06:28

Mobile Web

Screenshot 2021-08-23 18:08:54

iOS

context-menu.mp4

Android

Screenshot 2021-08-23 18:10:36

@parasharrajat parasharrajat requested a review from a team as a code owner August 17, 2021 05:23
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team August 17, 2021 05:23
@parasharrajat
Copy link
Member Author

Any thought @puneetlath?

@parasharrajat
Copy link
Member Author

@Beamanator Could you please review this? I will upload the screens for other platforms if needed.

@Beamanator Beamanator self-requested a review August 23, 2021 12:16
@Beamanator
Copy link
Contributor

@parasharrajat we'd like everyone to be in the habit of testing all PRs on every platform so in the future, please do add a screenshot for every platform. This is how we'll most effectively reduce regressions

@parasharrajat
Copy link
Member Author

I did test it but didn't upload the images. I will update them.

@parasharrajat
Copy link
Member Author

Done

Beamanator
Beamanator approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on android, ios, mweb safari -> works great 👍

@Beamanator Beamanator merged commit 8885807 into Expensify:main Aug 23, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Aug 24, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

@bondydaa bondydaa mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@puneetlath puneetlath Awaiting requested review from puneetlath

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parasharrajat @Beamanator @OSBotify @botify