Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capatilisation to translation & some margin for the input #4688

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Add capatilisation to translation & some margin for the input #4688

merged 1 commit into from
Aug 19, 2021

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Aug 17, 2021

Details

#4673 (comment)
We need some top margin and capitalization of the required translation.

Fixed Issues

$ #4673

QA Steps

1.Click on the global create button
2.Click on request money
3. Set an amount
4. Select another user as an attendee

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

mobileWeb

Desktop

iOS

Android

android

@thesahindia thesahindia marked this pull request as ready for review August 17, 2021 15:04
@thesahindia thesahindia requested a review from a team as a code owner August 17, 2021 15:04
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team August 17, 2021 15:04
@Julesssss
Copy link
Contributor

Confirmed on iOS and Desktop, will merge when the iOS check completes

@Julesssss Julesssss merged commit ba2a9d2 into Expensify:main Aug 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants