Added translations for "edited" label in chats #4776

akshayasalvi · 2021-08-21T02:50:48Z

@Julesssss PR for the review.

Details

Add translation for "(edited)" label

Fixed Issues

$ #4518

Tests

Tested by switching the language for edited messages
Tested for Links (HTML content)

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

…vi/App into translation-edited-label

akshayasalvi · 2021-08-21T03:24:13Z

@Julesssss I found that the same label is hardcoded in BaseHTMLEngineProvider as well. I've fixed it there too.

But I need a little help here. How should I pass withLocalizePropTypes to the EditRenderer?

Options:

I leave it as per what I've done right now
I create a named component and then passed propTypes. But in this what would be the other propTypes for the renderer component?

Julesssss · 2021-08-23T11:17:30Z

Hi @akshayasalvi, I'm not sure about this. I asked in our open source slack channel here for some help. Please feel free to add your own comments, or to follow along here

akshayasalvi · 2021-08-23T13:20:39Z

Hi @Julesssss,
I am unable to access the link and I don't have a slack account. I've found two more functions in src/libs/translate. I feel translateLocal might help in this case. I've tested and it works. Can we use that? I've updated the PR to reflect the changes. Let me know if it has to be changed to some other way.

Julesssss · 2021-08-24T09:40:15Z

Hi @akshayasalvi, transalateLocal seems to be a valid solution here. I would suggest joining our Slack channel for better communication and updates about new jobs, ect.

akshayasalvi · 2021-08-24T11:05:28Z

Thank you. Then any other changes from my side?

I'll try to join the channel. How do I join it?

Julesssss · 2021-08-24T11:19:09Z

Instructions are here. I'll review the PR now.

Julesssss

One issue: I noticed that the HTML edited does not update when changing language. Perhaps this is due to translateLocal... If you are stuck here I think we should continue the discussion I started in the Slack thread

akshayasalvi · 2021-08-24T12:12:21Z

Ohh yeah, that's right. It doesn't change.

akshayasalvi · 2021-08-24T14:35:10Z

@Julesssss I have sent the request to join slack.

I've checked and my previous solution of adding withLocalize to EditedRenderer is working fine. Should we think on those lines?

…ion-edited-label # Conflicts: # src/languages/en.js # src/languages/es.js

Julesssss · 2021-08-25T14:37:07Z

I've checked and my previous solution of adding withLocalize to EditedRenderer is working fine.

Yeah, lets do that. I was a bit worried about the performance hit from adding a new subscription to a Commonly used component, but apparently it is fine 👍

akshayasalvi · 2021-08-25T14:40:16Z

PR updated

aldo-expensify · 2021-08-26T19:18:42Z

src/languages/es.js

@@ -129,6 +129,7 @@ export default {
        fileUploadFailed: 'Subida fallida. El archivo no es compatible.',
        roomIsArchived: 'Esta sala de chat ha sido eliminada',
        localTime: ({user, time}) => `Son las ${time} para ${user}`,
+        edited: '(editar)',


This should be (editado), not (editar).

Edit -> Editar
Edited -> Editado/a (depending on the gender of what we edited).

Julesssss

LGTM, just need to make the fix @aldo-expensify suggested

akshayasalvi · 2021-08-27T11:38:29Z

Is there a function to know the gender of the person who edited ?

Julesssss · 2021-08-27T12:32:42Z

Is there a function to know the gender of the person who edited?

We don't have a way of doing this yet. Maybe we could use their pronouns which are optional, but that's out of scope of this issue.

akshayasalvi · 2021-08-27T13:06:19Z

Then I'll just change to editado

akshayasalvi · 2021-08-27T13:22:28Z

@Julesssss @aldo-expensify PR updated

aldo-expensify · 2021-08-27T16:26:49Z

Is there a function to know the gender of the person who edited?

We don't have a way of doing this yet. Maybe we could use their pronouns which are optional, but that's out of scope of this issue.

heh I may have caused some confusion here. It is the genre of what is being edited: the message (input), not the person. It really depends on how we refer to each "input" of a chat (report) in Spanish. Anyway, I think editado is the right one!

Update: Looking at other translations, I see that we refer to each input as "Comentario", so, editado is the correct one.

akshayasalvi · 2021-08-27T16:31:53Z

Ohh. Thanks for the clarification @aldo-expensify. Sorry for the confusion :)

aldo-expensify

Looks good to me, I leave it to you @Julesssss

OSBotify · 2021-08-27T16:59:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-08-30T17:32:21Z

🚀 Deployed to staging by @Julesssss in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2021-09-01T01:43:05Z

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

akshayasalvi added 2 commits August 20, 2021 21:29

Added translations for "edited" label in chats

6b9172f

Added translations for "edited" label in chats

5f7703c

akshayasalvi requested a review from a team as a code owner August 21, 2021 02:50

MelvinBot requested review from Julesssss and removed request for a team August 21, 2021 02:50

akshayasalvi added 2 commits August 21, 2021 08:50

Added edit label translation to HTML content

860d00c

Merge branch 'translation-edited-label' of github-personal:akshayasal…

6cdd40e

…vi/App into translation-edited-label

Changed the translate function for html section

3922097

Julesssss requested changes Aug 24, 2021

View reviewed changes

akshayasalvi added 2 commits August 25, 2021 19:52

Merge branch 'main' of github-personal:akshayasalvi/App into translat…

e439423

…ion-edited-label # Conflicts: # src/languages/en.js # src/languages/es.js

Changed translateLocal to 'withLocalize'

04ee1a0

aldo-expensify reviewed Aug 26, 2021

View reviewed changes

Julesssss previously approved these changes Aug 27, 2021

View reviewed changes

Changed spanish translation

313d476

akshayasalvi dismissed Julesssss’s stale review via 313d476 August 27, 2021 13:21

aldo-expensify approved these changes Aug 27, 2021

View reviewed changes

Julesssss approved these changes Aug 27, 2021

View reviewed changes

Julesssss merged commit d845aba into Expensify:main Aug 27, 2021

OSBotify mentioned this pull request Aug 27, 2021

Deploy Checklist: New Expensify 2021-08-25 #4828

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added translations for "edited" label in chats #4776

Added translations for "edited" label in chats #4776

akshayasalvi commented Aug 21, 2021

akshayasalvi commented Aug 21, 2021

Julesssss commented Aug 23, 2021

akshayasalvi commented Aug 23, 2021 •

edited

Loading

Julesssss commented Aug 24, 2021

akshayasalvi commented Aug 24, 2021

Julesssss commented Aug 24, 2021

Julesssss left a comment

akshayasalvi commented Aug 24, 2021

akshayasalvi commented Aug 24, 2021

Julesssss commented Aug 25, 2021 •

edited

Loading

akshayasalvi commented Aug 25, 2021

aldo-expensify Aug 26, 2021 •

edited

Loading

Julesssss left a comment

akshayasalvi commented Aug 27, 2021

Julesssss commented Aug 27, 2021

akshayasalvi commented Aug 27, 2021

akshayasalvi commented Aug 27, 2021

aldo-expensify commented Aug 27, 2021 •

edited

Loading

akshayasalvi commented Aug 27, 2021

aldo-expensify left a comment

OSBotify commented Aug 27, 2021

OSBotify commented Aug 30, 2021

OSBotify commented Sep 1, 2021

Added translations for "edited" label in chats #4776

Added translations for "edited" label in chats #4776

Conversation

akshayasalvi commented Aug 21, 2021

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

akshayasalvi commented Aug 21, 2021

Julesssss commented Aug 23, 2021

akshayasalvi commented Aug 23, 2021 • edited Loading

Julesssss commented Aug 24, 2021

akshayasalvi commented Aug 24, 2021

Julesssss commented Aug 24, 2021

Julesssss left a comment

Choose a reason for hiding this comment

akshayasalvi commented Aug 24, 2021

akshayasalvi commented Aug 24, 2021

Julesssss commented Aug 25, 2021 • edited Loading

akshayasalvi commented Aug 25, 2021

aldo-expensify Aug 26, 2021 • edited Loading

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

akshayasalvi commented Aug 27, 2021

Julesssss commented Aug 27, 2021

akshayasalvi commented Aug 27, 2021

akshayasalvi commented Aug 27, 2021

aldo-expensify commented Aug 27, 2021 • edited Loading

akshayasalvi commented Aug 27, 2021

aldo-expensify left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 27, 2021

OSBotify commented Aug 30, 2021

OSBotify commented Sep 1, 2021

akshayasalvi commented Aug 23, 2021 •

edited

Loading

Julesssss commented Aug 25, 2021 •

edited

Loading

aldo-expensify Aug 26, 2021 •

edited

Loading

aldo-expensify commented Aug 27, 2021 •

edited

Loading