[Hold for payment on Sept 3rd] Translation not added for Edited label in the comment

[akshayasalvi]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Keep the language Spanish
2. Go to the any chat and edit the comment
3. Click on save changes
4. You'll see (edited) is still in English.

Expected Result:

(edited) label should be translated to Spanish

Actual Result:

(edited) label shows in English

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @ntrepanier (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[akshayasalvi]

Proposed Solution:

Add translation for edited keyword and update the english text with function

For language files add keys,
en -> common -> edited: '(edited)'
es -> common -> edited: '(editado)'

Update the below block in ReportActionItemFragment

with

this.props.translate('common.edited')

Currently, the class doesn't have localize hoc. Need to add that too.

export default compose(
	withLocalize,
	withWindowDimensions
)(ReportActionItemFragment);

and props ...withLocalizePropTypes

[MelvinBot]

@ntrepanier Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

This can be done by external , but I'm taking this for myself for learning purposes

[akshayasalvi]

@ntrepanier @aldo-expensify While it was picked by somebody in the team, will I still be paid for finding the issue and suggesting the fix?

[aldo-expensify]

Sorry, closed by mistake, reopened.

[aldo-expensify]

The proposed solution works in my opinion. This can be handled by someone external.

[MelvinBot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[akshayasalvi]

Thank you for responding @Julesssss It seems this isn't closed and we are hiring from Upwork. I got an invite for this job. So am I supposed to work on it?

[MTN718]

Thanks @Julesssss. I saw Upwork project yesterday and immediately i made proposal. seems it's late

[Julesssss]

It seems this isn't closed and we are hiring from Upwork

@akshayasalvi so we'll need to hire you in UpWork too, as that's how we currently make payments, but as soon as you are given approval and assigned to this issue you are free to start working on the task. Please let me know if you have any other questions.

[Julesssss]

Hi @MTN718. Yeah, to give you some context the reason I went with the other proposal is because: A) It was the first proposal we received (10 days ago), and B) it had a bit more detail, and included the fact that we would need to add the localize hoc.

[MTN718]

Ok no problem thanks.

[akshayasalvi]

@akshayasalvi please go ahead and submit a PR.

@Julesssss I somehow missed this chat and was waiting for the Upwork job. Nevertheless, I've submitted the PR. Please review.

[MelvinBot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

waiting on PR merge

[Julesssss]

Merged

[Julesssss]

@adelekennedy we can pay this today

[adelekennedy]

@akshayasalvi has been paid, the contract has been completed, and the Upwork post has been closed!

[akshayasalvi]

Thank you @Julesssss and @adelekennedy