Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles h3/h4 missing bold fixed for web, desktop, iOS #4839

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Styles h3/h4 missing bold fixed for web, desktop, iOS #4839

merged 2 commits into from
Aug 26, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Aug 25, 2021 •
edited
Loading

@roryabraham

Details

Bold style missed out for welcome text

Fixed Issues

$ #4729

Tests & QA Steps

  1. Go to the new Expensify app. Log out if already logged in.
  2. Login page welcome text should be bolded on all platforms
  3. Enter email click continue
  4. Forgot? should also be not be bolded.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-08-26 at 12 46 29 AM

Screenshot 2021-08-26 at 2 22 03 AM

Mobile Web

Screenshot 2021-08-26 at 12 46 43 AM

Screenshot 2021-08-26 at 2 22 16 AM

Desktop

Screenshot 2021-08-26 at 1 01 05 AM

Screenshot 2021-08-26 at 2 34 40 AM

iOS

Simulator Screen Shot - iPhone 12 - 2021-08-26 at 00 52 22
Simulator Screen Shot - iPhone 12 - 2021-08-26 at 02 21 28

Android

Screenshot_1629924608
Screenshot_1629924632

@shawnborton
Copy link
Contributor

Can we make sure Forgot? is just in our normal paragraph text style and not bold? Thanks!

@Santhosh-Sellavel
Copy link
Collaborator Author

Yes, will update PR.

@Santhosh-Sellavel Santhosh-Sellavel marked this pull request as ready for review August 25, 2021 21:43
@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner August 25, 2021 21:43
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team August 25, 2021 21:44
@Santhosh-Sellavel
Copy link
Collaborator Author

Can we make sure Forgot? is just in our normal paragraph text style and not bold? Thanks!

Updated Forget Style also.

@shawnborton
Copy link
Contributor

Perfect, thank you!

sketchydroide
sketchydroide approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sketchydroide sketchydroide merged commit 56ab0eb into Expensify:main Aug 26, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 27, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @sketchydroide in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sketchydroide sketchydroide sketchydroide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Santhosh-Sellavel @shawnborton @OSBotify @sketchydroide