Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #4751

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Update CONTRIBUTING.md #4751

merged 1 commit into from
Aug 19, 2021

Conversation

mallenexpensify
Copy link
Contributor

@mallenexpensify mallenexpensify commented Aug 18, 2021

Updating line 30 from
Payment for your contributions will be made no less than 7 days after the pull request is merged to allow for regression testing.
to
Payment for your contributions will be made no less than 7 days after the pull request is deployed to production to allow for regression testing.

Details

Fixed Issues

https://github.com/Expensify/Expensify/issues/174180

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Updating line 30 from
Payment for your contributions will be made no less than 7 days after the pull request is merged to allow for regression testing.
to
Payment for your contributions will be made no less than 7 days after the pull request is deployed to production to allow for regression testing.
@mallenexpensify mallenexpensify requested a review from a team as a code owner August 18, 2021 23:51
@mallenexpensify mallenexpensify self-assigned this Aug 18, 2021
@MelvinBot MelvinBot requested review from alex-mechler and removed request for a team August 18, 2021 23:51
Copy link
Contributor

@alex-mechler alex-mechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a link to the issue in the body, so that it is easier to find

@alex-mechler alex-mechler merged commit 055a80c into main Aug 19, 2021
@alex-mechler alex-mechler deleted the mallenexpensify-patch-2 branch August 19, 2021 17:04
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants