Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the text style in about page #4522

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Fix the text style in about page #4522

merged 4 commits into from
Aug 18, 2021

Conversation

Dal-Papa
Copy link

@Dal-Papa Dal-Papa commented Aug 10, 2021

@shawnborton & @bondydaa

Details

The text in the about page wasn't using our regular font size.

Fixed Issues

$ N/A

QA Steps

  1. Click on your user profile image to open the Settings menu
  2. Go to "About"
  3. Verify that the text is in a normal font size

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-08-10 at 10 47 42

Mobile Web

Screen Shot 2021-08-10 at 10 57 49

Desktop

iOS

Android

@Dal-Papa Dal-Papa requested review from shawnborton and a team August 10, 2021 09:12
@Dal-Papa Dal-Papa self-assigned this Aug 10, 2021
@MelvinBot MelvinBot requested review from bondydaa and removed request for a team August 10, 2021 09:13
@shawnborton
Copy link
Contributor

To help get rid of the dangling orphan, maybe we can change the last line to "Help us build the next generation of Expensify." - thoughts?

@Dal-Papa
Copy link
Author

To help get rid of the dangling orphan, maybe we can change the last line to "Help us build the next generation of Expensify." - thoughts?

It seems to work, happy to commit.
Screen Shot 2021-08-10 at 11 41 24

@shawnborton
Copy link
Contributor

Looks great!

shawnborton
shawnborton previously approved these changes Aug 10, 2021
@Dal-Papa Dal-Papa requested a review from a team as a code owner August 10, 2021 09:47
@MelvinBot MelvinBot removed the request for review from a team August 10, 2021 09:48
shawnborton
shawnborton previously approved these changes Aug 10, 2021
bondydaa
bondydaa previously approved these changes Aug 11, 2021
@bondydaa
Copy link
Contributor

merge conflicts

@Dal-Papa
Copy link
Author

@shawnborton : Wording was changed in this commit and it screwed up your nice alignment... What do you advise ?
Screen Shot 2021-08-12 at 09 26 00

@shawnborton
Copy link
Contributor

If we add "Come..." back to the front of the last sentence, does that give us at least two words on the third line? Or alternatively, we could just say "Help us build the future of Expensify."

@Dal-Papa
Copy link
Author

If we add "Come..." back to the front of the last sentence, does that give us at least two words on the third line? Or alternatively, we could just say "Help us build the future of Expensify."

I have tried adding back the Come but it still leaves the Expensify alone in the last line. Let me try that last option.

@Dal-Papa
Copy link
Author

It works ! Though now I'd say the Spanish translation is off isn't it ?
Screen Shot 2021-08-12 at 10 05 23

@shawnborton
Copy link
Contributor

I think they roughly communicate the same thing, but you could ping #espanol if you want to update it. I think it will be fine though.

# Conflicts:
#	src/languages/en.js
@Dal-Papa Dal-Papa dismissed stale reviews from bondydaa and shawnborton via dc4dd81 August 12, 2021 08:47
Copy link
Contributor

@bondydaa bondydaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm with @shawnborton I think we might need to fix this line as well

description: 'El nuevo aplicación Expensify está creado por una comunidad de desarrolladores de código abierto de todo el mundo. Ven y ayúdanos a construir la próxima generación de Expensify.',

@Dal-Papa
Copy link
Author

Here's the About page with the updated copy in Spanish :
Screen Shot 2021-08-16 at 16 56 19

shawnborton
shawnborton previously approved these changes Aug 16, 2021
@shawnborton
Copy link
Contributor

Looks good to me, thanks Clem!

@Dal-Papa Dal-Papa requested a review from bondydaa August 17, 2021 08:05
@bondydaa
Copy link
Contributor

did you forget to push?

I don't see any changes to the es.js file
Screen Shot 2021-08-17 at 15 43 47

@Dal-Papa
Copy link
Author

did you forget to push?

... No ... 🏃‍♂️

@bondydaa bondydaa merged commit 25737b5 into main Aug 18, 2021
@bondydaa bondydaa deleted the clem-fix-about-text branch August 18, 2021 16:26
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants