Link Workspace ID to reimbursement account setup so it is accessible during validation step #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @robertjchen in version: 1.0.89-0 🚀
|
4 tasks
|
@TomatoToaster Hello! We're currently blocked from testing this since all our domain already have the expensify card. Can this be tested internally? |
|
Ahh I actually had the same problem. I had a sort of hacky way to open the bank flow though again, so I was able to test adding a bank through the workspace page. But this let me test the full bank flow per the QA steps and at the end, I go the url pointing to the right workspace ID:
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robertjchen , please review when you get the chance
Details
We are currently not linking workspaces to the reimbursement accounts when we create them in NewDot.
This is a problem since when it comes to the validation step (enter 3 amounts) in bank setup, the user is routed to
your workspaceand it points to no actual workspace. It'll benew.expensify.com/workspace//cardinstead of something like 'new.exepsnify.com/workspace/153B54BA57F38FA7/card. This PR fixes that issue by making sure we link the reimbursement bank account to a workspace id. Specifically it takes the workspace id from the one that most recently clickedGet Started/Finish Setup` on the workspace page.You can see where the
your workspacemessage is generated here in Web-Secure: https://github.com/Expensify/Web-Secure/blob/master/lib/BankAccount/VerificationUtils.php#L320Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173546
Tests
Same as QA, done locally.
QA Steps
Create a new account on NewDot that has access to the freePlan beta (or do this in an account on the beta, that does not already have a verified bank account tied to a workspace).
Create a workspace from clicking the plus on the bottom right:
Click on
Get Startedand follow the steps in this S/O forTo create a PENDING bank account: https://stackoverflow.com/c/expensify/questions/342Eventually you should get to this step:
You can close the modal here and go to the chat with concierge. You should see a message like this:
Click on
your workspaceand verify that it actually opens you up to the workspace:Tested On
Screenshots
Only affects web and screenshots included in QA Steps