fix count when LHN is open on mobile

[parasharrajat]

Details

1. Only increment the counter when the report is visible and in other case, we should reset the counter.

Fixed Issues

$ #4863

Tests | QA Steps

1. Lunch the app
2. Log in with account A in device 1
3. Select user you will chat and scroll the chat to 10-30 messages to top
4. Back to LHN
5. Log in with account B in device 2
6. Send 13 messages to account A from device 2
7. Back to conversation from LHN in device 1 and check the green Marker Badge Coun

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

fix-count.mp4

[parasharrajat]

Updated. Don't forget to CP it. Thanks.

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[roryabraham]

@parasharrajat I notice from your screen recording that the UnreadActionIndicator does not seem to be visible when you scroll to the bottom of the chat.

[parasharrajat]

Sorry, what are you referring to via UnreadActionIndicator new-messages line marker or new messages Marker Badge which is being fixed in this PR?

[parasharrajat]

If you are talking about the new messages line marker. then there are two similar issues for this #4357 & #4723. I think this should be covered there.

[roryabraham]

If you are talking about the new messages line marker. then there are two similar issues for this #4357 & #4723. I think this should be covered there.

Yep, that's what I was talking about. Thanks!

[OSBotify]

🚀 Cherry-picked to staging by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[isagoico]

Retested this on my Android and it was a pass!

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅