Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>

…rom machine.conf (#2991)

* add code to read base mac from machine.conf

* rewording the comments

* add mac validation with re

* fix review comments

* remove empty line

…2874)

…ory (#3079)

* fix fast reboot compatibility

We should handle both cases for backward-compatible with 201803:
 - fast-reboot
 - SONIC_BOOT_TYPE=fast-reboot

* handle review comments
* add a comment that getBootType code snippet is shared between two files

Signed-off-by: Wenda Ni <wenni@microsoft.com>

Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>

Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>

- Add reboot cause support for the platform API
 - Add LED support for the platform API xcvrs and fans
 - Misc fixes

* Switch Vendor: DellEMC
    * Switch SKU: s5232F
    * ASIC Vendor: Broadcom
    * Swich ASIC: Trident3
    * Port Configuration: 32x100G
    * SONiC Image: sonic-broadcom.bin

    * LED support for s5232f
    * Changes Include ipmitool implementation for platform_sensors script is inclued in pmon startup
    * Added 100G,25G,10G configruation ( 100G is default).

…3059)

Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>

…form API (#3013)

#3012)

Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>

* [ARISTA] adding 7060_cs32s to eMMC exclusions

Following PR 2774 we added the 7060-cx32s according to the guidelines of
PR 2780

This adds the 7060-cx32s to the list f devices that mount /var/log as a
tmpfs to mitigate eMMC wearout

Signed-off-by: Michel Moriniaux <m.moriniaux@criteo.com>

* [ARISTA] adding 7060_cs32s to eMMC exclusions

Following PR 2774 we added the 7060-cx32s according to the guidelines of
PR 2780

This adds the 7060-cx32s to the list f devices that mount /var/log as a
tmpfs to mitigate eMMC wearout

Signed-off-by: Michel Moriniaux <m.moriniaux@criteo.com>

Implement new platform api sfp part, including the following APIs;
- get_reset_status
- get_tx_disable_channel
- get_lpmode
- get_power_override
- reset
- set_lpmode
- tx_disable
- tx_disable_channel
- set_power_override

* Added > /64 ip6 route support for 1024 entries.

Signed-off-by: Ashok Daparthi <Ashok_Daparthi@Dell.com>

Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>

…#3107)

* sonic-device-data: update SAI config checker for Broadcom TD3 and TH3

The following properties have been approved by the Broadcom chip arch team:

l3_alpm_ipv6_128b_bkt_rsvd
ifp_inports_support_enable
pll_bypass
dpr_clock_frequency
device_clock_frequency
port_flex_enable
mmu_port_num_mc_queue
serdes_core_rx_polarity_flip_physical{<PORT>}
serdes_core_tx_polarity_flip_physical{<PORT>}

Signed-off-by: Dante (Kuo-Jung) Su <dante.su@broadcom.com>
Change-Id: I1c6239cddfb0582a9298e671d792a32f79e4f006

Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>

…9100 & S6100 (#3063)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

…cess-reboot-cause' (#3102)

…3117)

* Added debug symbols to many debug dockers.

* For debug images *only*:
1) Archive source files into debug image
2) Archived source is copied into /src
3) Created an empty dir /debug
4) Mount both /src as ro & /debug as rw into every docker
5) Login banner will give some details on /src & /debug
6) Devs can copy core file into /debug and view it from inside a container.
7) Dev may create all gdb logs and other data directly into /debug.

* Dropped redundant REDIS_TOOLS per review comments.

* Added debug symbols to frr package and hence FRR based BGP docker.

* 1) Moved dbg_files.sh to scripts/
2) Src directories to archive are now collected from individual Makefiles.
3) Added few more debug symbols
4) Added few more debug dockers.

Here after no more changes except per review comments.

To debug:
Install required version of debug image in Switch or VM.
Copy core file into /debug of host
Get into Docker
gdb /usr/bin/<daemon> -c /debug/<your core file>
set directory /src/... <-- inside gdb to get the source

For non-in-depth debugging:

Download corresponding debug Docker image (docker-...-dbg.gz) to your VM
Load the image
Run image with entrypoint as 'bash' with dir containing core mapped in.
Run gdb on the core.

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>

* new platform api, chassis part

* Inject mlnx mlx libs to platform monitor

* address the review comments

* remove some confusing naming.

* Adjust the minor cause to a more human-readable way when rebooted by firmware

* address review comments

* expose host dir /host/reboot-cause to pmon docker so that the reboot causing by user command can be identified

* 1. Revert "expose host dir /host/reboot-cause to pmon docker so that the reboot causing by user command can be identified"
Since the only hardware-causing reboot should be handled by get_reboot_cause and the logic of handling reboot cause is about to move to the host side, no need to mount this dir to pmon docker.
This reverts commit 3feb968.
2. adjust log output by using sonic_daemon_base.daemon_base.Logger.
3. remove the logic of verifying /host/reboot-cause/ files.
4. fix typo.

* implement get_firmware_version and adjust the interfaces regarding components' version retrieving according to the sonic-net/sonic-platform-common#34

redis-server-dbgsym is not available since redis server 4

Variables SFP_VLOT_OFFSET and QSFP_VLOT_OFFSET containing the typo are originally defined in repo sonic-platform-common. The typo has been fixed in PR #33. However, some Mellanox-specific code hasn't updated correspondingly, which results in xcvrd fail to start.
This PR updates the variable name in Mellanox-specific code correspondingly to fix that.

…c_platform implementation (#3126)

- Add PSU support for the platform API
 - Complete LED support for the platform API
 - Misc refactoring

…rior to reading dom data (#3120)

* fix the issue Bug SW #1816356 which is due to failing to test whether dom supported prior to reading dom data

* use pre-defined variable to avoid magic number.
no need to read 16 bytes, 1 byte is enough since calibration and dom capability are all in bytes at offset 92

Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

- What I did

Configure sshd to close all SSH connetions after 15 minutes of inactivity.

- How I did it

Set ClientAliveInterval to 900 (900 seconds = 15 minutes) and ClientAliveCountMax to 0
in /etc/ssh/sshd_config using augtool in build_debian.sh. In the process, I refactored the existing augtool command for sshd_config so as to add comments and empty lines to file for readability.

- How to verify it

Log into device via management port. Wait 15 minutes without sending a keystroke -- you should be automatically logged out.

…API (#3123)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

* fix the memory leak in on_pmpe. objects created via sx_api having convention new_<type_name> should be release explicitly via delete_<type_name>.

* avoid duplicate code.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

Signed-off-by: derek_sun <derek_sun@edge-core.com>

* Update hw-mgmt package to v183

* update sonic-linux-kernel repo to pick up new patches

* Add serdes polarity for 32x400G Arista 7060PX/DX4

* Add serdes polarity for 64x100G on Arista 7060PX/DX4

…filesystem (#3154)

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

Define slave_base_tag_ref variable in Makefile.work containing
specific base image tag to use, rather than always defaulting
to :latest.

Add an ARG command before FROM statement in Dockerfile.user
for sonic-slave and sonic-slave-stretch. ARG variable defaults
to latest if slave_base_tag_ref not specified in Makefile.work.

The presumption to always refer to the :latest tagged Docker base
image when creating the user image causes problems in a shared
build server environment, where the most recently created base
image (i.e. the current :latest tag) may not be compatible with
the current build. For example, different users working in
different branches may all be sharing the same build server.

Signed-off-by: Greg Paussa greg.paussa@broadcom.com

- What I did
Added a DOCKER_AVOID_BASE_TAG_LATEST build option to rules/config that forces the Docker user image creation to refer to its base image by a specific tag rather than rely on the :latest tag. This is needed in a shared build server environment where builds from different developers and/or different SONiC branches all converge on the same Docker daemon instance running on the build server. The :latest tag is always assigned to the most recent base image built, which might not correspond to the base image needed for a particular build, thus causing various build errors that mostly manifest as missing Debian packages or package version mismatches.

NOTE TO REVIEWERS: This PR relies on Docker support of "ARG before FROM," which was first introduced in Docker version 17.05.1-ce. Although there is no mention of a minimum required Docker version for the build server in the SONiC Building Guide pages, please consider whether it is reasonable to assume that Docker 17.05.1-ce or later must be used for SONiC build hosts before approving this PR.

- How I did it
Added an ARG before the FROM statement at the top of the sonic-slave/Dockerfile.user and sonic-slave-stretch/Dockerfile.user files. The ARG variable defaults to latest, but can be overridden in Makefile.work to reference the SLAVE_BASE_TAG so that it refers to the specific, matching base image for the build. This override is activated by un-commenting the DOCKER_AVOID_BASE_TAG_LATEST = y line in rules/config.

Added details on how to build debug docker images and how they can be exploited for debugging.

- Make sure that migrated DB contents persisted for next boot
- Make sure that db saved after warm reboot.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

In case of going from previous iteration of SONiC, and the last reboot
was hardware, REBOOT_CAUSE_FILE may not be present and the service may
throw an error.

…3144)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

* Remove unnecessary checks

)

* ee56d54 2019-07-16 | [fast-reboot] Stop services after killing containers to prevent automatic restart (#572) (HEAD -> master, origin/master, origin/HEAD) [Joe LeVeque]
* c718cab 2019-07-17 | [acl_loader]: Fix show mirror_session error (#580) [JaredLius]
* 2764c6c 2019-07-16 | [Mellanox] Improve the prompt of the Mellanox sdk sniffer command. (#546) [Stephen Sun]
* 5a5b74d 2019-07-10 | Generate interface table to have an entry for default VRF (#525) [Prince Sunny]
* c30e9ff 2019-07-10 | [show] Don't abort in InterfaceAliasConverter ctor if PORT table doesn't exist (#571) [Joe LeVeque]
* 1aac696 2019-07-10 | [fast reboot] stop removing opennsl module before reboot (#560) [Ying Xie]
* 37823d4 2019-07-09 | Modified CLI doc for 201904 release, changed the config interface command, etc., (#561) [kannankvs]
* 77ae6b8 2019-07-03 | [PR template] Add reminder to update Command Line Reference Guide if modifying user-facing commands (#569) [Joe LeVeque]
* dc52015 2019-06-25 | [Sonic-utilities]: Added commands to view acl and port running configs (#557) [Prem Prakash]
* c7f45c3 2019-06-19 | [warm-reboot] Use retryCount option of orchagent_restart_check program (#555) [Jipan Yang]
* c6a08f7 2019-06-17 | [scripts]: add support to db_migrator for non-default unix socket (#551) [Lawrence Lee]
* 98e087f 2019-06-06 | [show]: Edit comment (#549) [Vasant Patil]
* 5667a90 2019-06-06 | [intfutil] Fix error when <interface name> specified in show interface related commands (#548) [Gord Chen]
* b7fcb1f 2019-06-04 | Add buffer pool watermark support in watermarkstat and counterpoll (#521) [Wenda Ni]
* 635dc88 2019-06-03 | [config]: Add config acl add/remove table command (#541) [Shuotian Cheng]
* dcdc922 2019-06-03 | [show]: Add show policer command (#540) [Shuotian Cheng]
* 82ef3ec 2019-06-01 | IP Address validation check (#530) [Tapash Das]
* 1f326ad 2019-05-31 | [show] Remove ability to clear counters from 'show' commands (#518) [Joe LeVeque]
* 669d36d 2019-06-01 | Add SONIC CLI Manual (#533) [kannankvs]
* 7657001 2019-06-01 | 'show vlan config' not displaying the VLAN members, after the clear config and reload with default l2 configuration. (#457) [RAMA CHANDRA REDDY GADDAM]
* 9493883 2019-05-28 | use vlan members (#542) [trzhang-msft]
* 128462a 2019-05-22 | [config]: Add --policer option for mirror session (#537) [Shuotian Cheng]
* 38da7f3 2019-05-22 | [acl_loader]: Add policer attribute in show mirror_session command (#538) [Shuotian Cheng]
* f95ff00 2019-05-22 | [acl_loader]: Do not apply default DENY rule for MIRRORV6 table (#522) [Shuotian Cheng]
* 50b7256 2019-05-21 | [sonic_installer] If asked to install an image which is already installed, simply set as default (#534) [Joe LeVeque]
* d823062 2019-05-20 | [201811] enable DB migrator code (#536) [Ying Xie]
* 7f7f384 2019-05-10 | update scheme variable name (#531) [trzhang-msft]
* c66315a 2019-05-10 | Config interface Loopback0 ip add/del is not working (#443) [Kiran Kumar Kella]
* 430d4b8 2019-05-10 | decode-syseeprom : added new option to show the Product Name. (#496) [Olivier Singla]

Integrating official Mellanox SDK/FW release as a pre condition for getting new Mellanox SAI release with hash changes (inner field) and 3k VXLAN scale. As well as bug fix for Spectrum LP mode and Spectrum 2 PFC WD

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

…eptions (MCE) to syslog (#3158)

* Install mcelog package to host OS; log machine check exceptions (MCE) to syslog

* Subscribe to both ConfigDB and AppDB
to get notifications to apply LLDP port config

* the operstate file is not consistent
Removing this since it is not serving any purpose

* Remove check for PortInitDone and PortConfigDone
This is not prteset in Config DB

* Remove checking State DB for port creation

* Check for key to be present before fetching it

* Addressing review comments

Without quote, the command will ignore the version and
regard the ">" as a file redirection symbol and redirect
all the output to a file named the version range.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

Signed-off-by: derek_sun <derek_sun@edge-core.com>

* Add driver and util for peripherals of as7312-54xs, most are copied from as7312-54s.
Signed-off-by: roy_lee <roy_lee@accton.com>

* Add default port speed and index from 1.
Signed-off-by: roy_lee <roy_lee@accton.com>

* Update i2c addr of psus.
Add system logging for monitor.
Signed-off-by: roy_lee <roy_lee@accton.com>

* Correct syntax of module_dirs.
Signed-off-by: roy_lee <roy_lee@accton.com>

* Validate sfputil after tested.
Signed-off-by: roy_lee <roy_lee@accton.com>

* Correct the index of eeprom mapping.
Signed-off-by: roy_lee <roy_lee@accton.com>

The permissions got changed inadverently in this PR: #3152

* Fix isolate/unisolate command for ipv6 peers

…rt (#3185)

*   [devices]: Add a new supported device DellEMC s5232f

    * Switch Vendor: DellEMC
    * Switch SKU: s5232F
    * ASIC Vendor: Broadcom
    * Swich ASIC: Trident3
    * Port Configuration: 32x100G
    * SONiC Image: sonic-broadcom.bin

    * LED support for s5232f
    * Changes Include ipmitool implementation for platform_sensors script is inclued in pmon startup
    * Added 100G,25G,10G configruation ( 100G is default).

* s5232[device] PSU detecttion and default led state support

swss:
[vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896)
[aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915)
Fix typo in orchagent_restart_check from fasle to false. (#923)
[sonic-swss]: Fix for FPM accept call failure in ARM arch (#925)
Add retryCount option for orchagent_restart_check program. (#833)
[vlan] Add pytest cases to validate nonexistent vlan behavior. (#874)
[intfsorch] Wait for interface prior to prefix (#796)
Set timer only when interval changes. Not in each firing of the timer. (#945)
[test]: Fix set interface in configuration database (#956)
[copporch]: Fix polymorphic type error (#946)
[AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952)
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953)
[portsorch]: Add reference count of port (#962)
[mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950)
remove crm acl_counters when acl_table removed (#918)
[aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966)
[policerorch]: Fix return code comparison error (#968)
[gitignore]: Add swss-dbg related files (#967)
[vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934)
[vxlanorch]: Add extra info into NOTICE logs (#891)
[test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955)
[copporch]: Fix copporch in DEL command (#972)
[orchagent]: Fix crash during orchagent process exit (#974)
[vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958)
[test]: Skip unstable test test_vnet_orch_1 (#976)
[intfsorch]: Fix rif flex counter removal error (#975)
Update tests README.md file
[aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978)
[test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981)
[teamsyncd]: Add information for LAG membership changes (#982)

common:
Add an assert to logger, which will log a message and abort. (#286)
[test]: Add IpAddress::isZero() unit test (#289)
do not abort when read timerfd return 0 and errno = 0 (#291)
Add BGP_STATE_TABLE in stateDB (#273)
[IpAddress]: add mcast scope on address and isFullMask method on prefix (#285)
Add ignore Wshadow pragma to json.hpp (#292)
[executor]: Fix Executor does not get correct priority saved in m_selectable (#290)
[schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294)
timerfd:read failure - Record in logs as error. (#295)
[schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296)
[schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297)

sairedis:
ARM32 bit fixes, for 64bit printf format specifier (#468)
Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472)
Fixed config_syncd_barefoot function (#474)
[syncd_init_common.sh] fix fast reboot backwards compatibility (#480)
Add default bridge id for bridge port id of type PORT in virtual switch (#473)
Fix a bug in parsing kernel argument of fast-reboot (#482)
Add TimerWatchdog for monitoring long execution apis (#469)
Add specific comparison logic for tunnel map (#475)
[vslib] add ACL action capabilities support (#481)
Per buffer pool watermark polling mode (#485)
Add specific comparison logic for ACL counter (#484)
Process flex counters requests in separate thread (#483)
Make sairedis/syncd synchronous (#476)
Fixed conditional operator. (#487)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

* Upgrade ifupdown2 to version 1.2.8

Required by ZTP to support ZTP over IPv6 transport

Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>

* support new platform api, thermal and psu part
for psu, all APIs are supported.
for thermal, we support
  get_temperature,
  get_high_threshold
for the thermal sensors of cpu core, cpu pack, psu and sfp module
and get_temperature for the ambient thermal sensors around the asic, port, fan, comex and board.

* 1. address review comments
2. improve the handling of PSU inserting/removal
3. tolerance diverse psu thermal sensor file name conventions

* 1. adjust thermal code according to the latest version of hw-management
2. check power_good_status rather than whether file existing ahead of reading voltage, current and power of PSU

)

This reverts commit b5a4527.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

…on the new platform API (#3163)

* [platform/cel]: add fan present sysfs

* [device/celestica]: move component device to chassis

* [device/celestica]: add basic device api

* 63afbd5 2019-07-22 [vnetorch]: Set default VxLAN encap TTL value (#980) [Volodymyr Samotiy]

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

The following commit addresses the graceful unmounting of file
system and graceful shutdown of dockers before calling a
cold reboot which will cause a power cycle of SSD. This ensures
orderly shutdown and no corruption of files systems because
of the power cycle to SSD.
This commit will use the existing systemd-reboot service scripts
and override the configuration to do cold reboot for S6100 and
Z9100.
Unit tested the fix and graceful shutdown of file system and
dockers are done with cold reboot.

Signed-off-by: Harish Venkatraman <harish_venkatraman@dell.com>

Signed-off-by: Neetha John <nejo@microsoft.com>

Bring up all ports by default by adding the admin_status:up
to each of the ports.

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

* [warm reboot] save configuration after warm reboot

After warm reboot, save a copy of in memory database to config_db.json,
upgrade procedure might have removed config_db.json to force new image
to reload minigraph. However, reload minigraph is skipped during warm
reboot. Missing config_db.json would cause device to fault in next
non-upgrading cold/fast reboot.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* Update finalize-warmboot.sh

* [as5712-54x]
Verified with index from 1.
Add qsfp_event() for command "show interaface trancerver".
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as6712-32x]
Add default port speed.
Verified with index from 1.

Signed-off-by: roy_lee <roy_lee@accton.com>

* [as7726-32x]
Add default port speed.
Verified with index from 1.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as7712-32x]
Add default port speed.
Verified with index from 1.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as5812-54x]
Add default port speed.
Verified with index from 1.

Signed-off-by: roy_lee <roy_lee@accton.com>

* [as5712-54x]
Update port-config with 1-based index.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as5812-54x]
Somehow the service may block, use type=simple to work-around.
Add syslog function for monitor.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as7716-32x]
Update port-config with 1-based index.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as7816-64x]
Update port-config with 1-based index.
Implement sfputil change_event.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as7326-56x]
Update port-config with 1-based index.
Implement sfputil change_event.

Signed-off-by: roy_lee <roy_lee@accton.com>

* Remove debug code.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [as7312-54x]
Update port-config with 1-based index and default port speed.

Signed-off-by: roy_lee <roy_lee@accton.com>

…s-reboot-cause (#3156)

Added Reboot Reason for S6000 in platform 2.0
Fixed issue in process-reboot-cause
Added package uninstall code in platform de-init code for z9100, s6100
- How I did it
-> Added support for S6000 Reboot Reason
-> Added platform.py for all platforms
-> Verified show reboot-cause command with the code changes. Added UT logs with show reboot-cause
-> Modified process-reboot-cause service to start after pmon.service. In S6000, we have to wait for nvram to be loaded.
-> If reboot-cause service starts before pmon.service, show reboot-cause is showing incorrect reason.
-> Bug fix in process-reboot-cause file
- import sonic_platform
+ import sonic_platform.platform

This commit adds support for New feature management VRF using L3mdev.  Added
commands to enable/disable management VRF. Config vrf add mgmt will enable
management VRF, enslave the eth0 device to the master device mgmt and restart
interfaces-configs in mgmt-vrf context.

management interface (eth0) can be configured using config interface eth0 ip
add command and removed using config interface eth0 ip remove command.

Requirement and design are covered in mgmt vrf design document.  Currently show
command displays linux command output; will update show command display in next
PR after concluding what would be the output for the show commands. Added
metric for default routes in dhcp and static, any changes for metric will be
addressed subsequently after discussing.

Signed-off-by: Harish Venkatraman <harish_venkatraman@dell.com>

Signed-off-by: Guohan Lu <gulv@microsoft.com>

Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>