[docker-fpm-frr]: Generate separated staticd.conf for staticd #3306
Conversation
Generate staticd.conf by templates/staticd.conf.j2 with config DB data
|
retest this please |
|
Also. If you introduce |
|
yes, you are right. |
|
Can you please remove ip route and ipv6 route from zebra.conf and I'll push this change? |
default_route block already moved to staticd.conf.j2
|
Done. Please review again. |
|
retest this please |
1 similar comment
|
retest this please |
|
tests are failing, please fix the test. |
|
Don't understand why the tests fail. What is "Build finished. No test results found" means? I checked other PRs and found that some of them passed with the same "Build finished. No test results found" messages. Maybe I just run the test again. |
|
retest this please |
|
@shikenghua |
* Add test for staticd.conf.j2 template * Correct the sample output of zebra.conf.j2 template * Fix a typo in test_zebra_frr
|
retest vs please |
* Fix test errors in test_j2files.py and test_j2files_t2_chassis_fe.py * Fix typo in test_j2files_t2_chassis_fe.py
|
retest baseimage please |
…net#3306) * [docker-fpm-frr]: Generate separated staticd.conf for staticd Generate staticd.conf by templates/staticd.conf.j2 with config DB data * [docker-fpm-frr]: Remove default_route block from zebra.conf.j2 default_route block already moved to staticd.conf.j2 * [docker-fpm-frr]: Add test for staticd.conf.j2 template * Add test for staticd.conf.j2 template * Correct the sample output of zebra.conf.j2 template * Fix a typo in test_zebra_frr * [docker-fpm-frr]: Fix test_j2files test errors * Fix test errors in test_j2files.py and test_j2files_t2_chassis_fe.py * Fix typo in test_j2files_t2_chassis_fe.py
Staticd was separated out from zebra after frr-6.0 to isolate static route handling.
If staticd.conf is missing, it will take zebra.conf for backward compatible. In this case, many ERR logs will be generated because it doesn't recognize other CLI commands in zebra.conf except those for static route.
This may cause some Ansible tests fail because of the loganalyzer found errors in syslog.
- What I did
Generate separated staticd.conf for staticd
- How I did it
Generate staticd.conf by templates/staticd.conf.j2 with config DB data
- How to verify it
Add MGMT_INTERFACE with gwaddr in config_db.json. After reboot, check whether the staticd.conf is generated in /etc/frr/ with correct content and no staticd ERR message should be found in syslog.
- Description for the changelog
Generate staticd.conf by templates/staticd.conf.j2 with config DB data
- A picture of a cute animal (not mandatory but encouraged)