Update redis to 5.0.3 #3066
Merged
Update redis to 5.0.3 #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does rdb format changed between 3.2.4 to 5.0.3. can 5.0.3 reads the redis dump from 3.2.4. this might affect warm reboot since it dumps the redis databased before reboot and then load it after reboot. |
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
|
@lguohan I don't have the right hardware setup for verifying system warm reboot. VS environment not working ( Actually never worked before even with same redis version) . It is appreciated if someone with hardware resource available may do a quick system warm-reboot test with the redis version change. Checking the log (from current redis to redis 5.03 warm upgrade), it looks data restore is good. <1> orchagent: <2> neighsyncd <3> syncd view comparison has issue, but probably not caused by redis version change. <4> warm-reboot log |
|
retest vs please |
https://github.com/sripathikrishnan/redis-rdb-tools/blob/master/docs/RDB_Version_History.textile |
|
@pavel-shirshov , we are not using redis rdb tools. |
|
@lguohan I understand that. The url I provided has answers on your questions:
Yes. It's changed.
Yes it can. Redis makes only backword compatible changes |
|
@jipanyang , can you save the redis database in a db file and then load the db file in 5.0.3 and see if the db has difference using redis-dump. |
|
retest vs please |
|
<1> save DB data with redis 3.2.4 <2> copy data out <3> reboot into new sonic with redis 5.0.3 <4> copy db data to new image with redis 5.0.3 <5> stop redis db instance <6> Let redis 5.0.3 pick up the back db data <7> dump json from redis 5.0.3 <8> copy new json out and compare them with json generated with redis 3.2.4 |
|
Forgot to update the DB number in previous test (fixed to DB0.json, now DB$i.json). |
lguohan
approved these changes
Jul 2, 2019
|
retest vsimage please |
|
ok so comparison logic issue was caused by redis version change than? |
|
no, redis version change is fine. comparison logic issue is something else. |
|
So how come is passing now? |
mssonicbld
added a commit
that referenced
this pull request
May 16, 2024
…lly (#18969) #### Why I did it src/sonic-swss ``` * c36333c3 - (HEAD -> master, origin/master, origin/HEAD) New p4orch development changes (#3066) (6 hours ago) [mint570] * 26a5a1cb - Fix flex counter out-of-order issue by notifying counter operations using SelectableChannel (#3076) (10 hours ago) [Stephen Sun] * 2f8bd9cf - Add support for ECMP and LAG hash offset (#3138) (28 hours ago) [Kumaresh Perumal] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com
- What I did
redis version update with debian stretch:
- How I did it
unix default socket changed to /var/run/redis/redis.sock from
/var/run/redis/redis-server.sock to be consistent with current code implementation.
(The other choice is to change all the code to use new default path)
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)