Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marvell hwsku ET6448M 48x1G+4x10G Arm32 Mgmt switch #3221

Merged
merged 5 commits into from
Jul 30, 2019

Conversation

antony-rheneus
Copy link
Contributor

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

    48x1G and 4x10G Management switch

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@@ -0,0 +1 @@
switchMacAddress=00:50:43:ee:ee:ee
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it mean all switches will have the same mac?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but Hardware doesn't have board eeprom, so its been updated in config file. Need to be updated per board.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not quite understand the logic here, the mac address should be embedded in your board, we should not put a file in the image because then every image will be different for each board. but, I will let you address this problem later.

@lguohan
Copy link
Collaborator

lguohan commented Jul 25, 2019

can you remove config_db.json and init_cfg.json, they are not needed in the image.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@antony-rheneus
Copy link
Contributor Author

can you remove config_db.json and init_cfg.json, they are not needed in the image.

Is it end user's responsibility to generate config_db.json?

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@antony-rheneus
Copy link
Contributor Author

can you remove config_db.json and init_cfg.json, they are not needed in the image.

Is it end user's responsibility to generate config_db.json?

Done, removed json files

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@lguohan
Copy link
Collaborator

lguohan commented Jul 30, 2019

can you update your pr title to be more specific?

@antony-rheneus antony-rheneus changed the title Sonic marvell hwsku Marvell hwsku ET6448M 48x1G+4x10G Arm32 Mgmt switch HWSKU Jul 30, 2019
@antony-rheneus
Copy link
Contributor Author

can you update your pr title to be more specific?

can you update your pr title to be more specific?

Done

@antony-rheneus antony-rheneus changed the title Marvell hwsku ET6448M 48x1G+4x10G Arm32 Mgmt switch HWSKU Marvell hwsku ET6448M 48x1G+4x10G Arm32 Mgmt switch Jul 30, 2019
@lguohan lguohan merged commit 88af7f6 into sonic-net:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants