[sonic_daemon_base]Fix the issue "'NoneType' object has no attribute 'closelog'" #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults from referencing an already destroyed global variable when destructuring daemon_base.Logger by introducing a class member to represent the global Conflicts: src/sonic-daemon-base/sonic_daemon_base/daemon_base.py
jleveque
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the issue "'NoneType' object has no attribute 'closelog'" which results from referencing an already destroyed global variable "syslog" when destructuring daemon_base.Logger. The root cause is that python doesn't have a definite sequence in which objects being destroyed when a program exits.
This issue is only observed when sonic_platform/chassis.py is loaded via python shell.
- How I did it
Introduce a class member to represent the "syslog" so that it is accessible during the class destructing.
- How to verify it
verify whether the information can be logged and confirm no error message when the process exits
- Description for the changelog
[sonic_daemon_base]fix the issue "'NoneType' object has no attribute 'closelog'"
- A picture of a cute animal (not mandatory but encouraged)