Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process-reboot-cause possibly throwing OSError #3159

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

zzhiyuan
Copy link
Contributor

In case of going from previous iteration of SONiC, and the last reboot
was hardware, REBOOT_CAUSE_FILE may not be present and the service may
throw an error.

- What I did
Add check for file before removing it.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

In case of going from previous iteration of SONiC, and the last reboot
was hardware, REBOOT_CAUSE_FILE may not be present and the service may
throw an error.
@jleveque
Copy link
Contributor

Retest mellanox please

1 similar comment
@jleveque
Copy link
Contributor

Retest mellanox please

@lguohan lguohan merged commit e4c041b into sonic-net:master Jul 16, 2019
yxieca pushed a commit that referenced this pull request Jul 16, 2019
In case of going from previous iteration of SONiC, and the last reboot
was hardware, REBOOT_CAUSE_FILE may not be present and the service may
throw an error.
StormLiangMS pushed a commit that referenced this pull request Mar 14, 2024
…atically (#18364)

Why I did it
src/sonic-utilities

* 45c44094 - (HEAD -> 202305, origin/202305) [config] Add Table hard dependency check (#3159) (10 hours ago) [jingwenxie]
* 8bde9cf7 - Skip the validation of action in acl-loader if capability table in STATE_DB is empty (#3199) (20 hours ago) [bingwang-ms]
How I did it
How to verify it
mssonicbld added a commit that referenced this pull request Mar 22, 2024
…atically (#18437)

#### Why I did it
src/sonic-utilities
```
* fb4a090d - (HEAD -> 202311, origin/202311) [config] Add Table hard dependency check (#3159) (4 hours ago) [jingwenxie]
* 86f3de58 - [ipintutil]Handle exception in show ip interfaces command (#3182) (4 hours ago) [Sudharsan Dhamal Gopalarathnam]
* 5bfc3b40 - [Techsupport]Handle SAI kv pair if present in sai common profile (#3196) (4 hours ago) [Sudharsan Dhamal Gopalarathnam]
* f4ef7681 - [fast/warm-reboot] Put ERR message in syslog when a failure is seen (#3186) (4 hours ago) [Vaibhav Hemant Dixit]
* db36df24 - [Bug] Fix fw_setenv illegel character issue (#3201) (4 hours ago) [xumia]
* a58b78c8 - [config] Add YANG alerting for override (#3188) (4 hours ago) [jingwenxie]
* 943a6846 - Update port2alias (#3217) (4 hours ago) [abdosi]
* 3236fbf4 - [show] Update show run all to cover all asic config in multiasic (#3148) (#3224) (5 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Mar 28, 2024
…atically (#18240)

#### Why I did it
src/sonic-utilities
```
* bdc57206 - (HEAD -> master, origin/master, origin/HEAD) Revert "Fix for Switch Port Modes and VLAN CLI Enhancement (#3108)" (#3246) (89 minutes ago) [jingwenxie]
* e35452b7 - Modify "show interface transceiver status" CLI to show SW cmis state (#3238) (2 days ago) [mihirpat1]
* 04a33e1f - Add "state" field in CONFIG_DB a toggle of the fabric port monitor feature (#2932) (2 days ago) [jfeng-arista]
* 3c489ba5 - Enhance route-check for multi-asic platforms (#3216) (5 days ago) [Deepak Singhal]
* c149e48b - [chassis] Add chassis support for CLI "config qos reload" (#3233) (6 days ago) [wenyiz2021]
* d8541add - Update port2alias (#3217) (8 days ago) [abdosi]
* d4688a8f - [graceful reboot] Add the pre_reboot_hook script execution, add the watchdog arm before the reboot (#3203) (8 days ago) [Vadym Hlushko]
* 125f36f3 - [ipintutil]Handle exception in show ip interfaces command (#3182) (10 days ago) [Sudharsan Dhamal Gopalarathnam]
* 9d532017 - [chassis][show-runningconfig] Fix the show runningconfiguration all issue on the Supervisor (#3194) (2 weeks ago) [Marty Y. Lok]
* 1a9261ce - [Techsupport]Handle SAI kv pair if present in sai common profile (#3196) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
* 7466dc4a - Skip the validation of action in acl-loader if capability table in STATE_DB is empty (#3199) (2 weeks ago) [bingwang-ms]
* b879b658 - [Bug] Fix fw_setenv illegel character issue (#3201) (3 weeks ago) [xumia]
* 0b41a560 - [config] Add YANG alerting for override (#3188) (3 weeks ago) [jingwenxie]
* 24683b0c - [show] multi-asic show running test residue (#3198) (3 weeks ago) [jingwenxie]
* 995a797a - CLI to skip polling for periodic information for a port in DomInfoUpdateTask thread (#3187) (3 weeks ago) [mihirpat1]
* 9aa9eaa5 - [config] Add Table hard dependency check (#3159) (3 weeks ago) [jingwenxie]
* 5f0ffcca - [fast/warm-reboot] Put ERR message in syslog when a failure is seen (#3186) (4 weeks ago) [Vaibhav Hemant Dixit]
* 92220dcf - Fix for Switch Port Modes and VLAN CLI Enhancement (#3108) (4 weeks ago) [Saba Akram]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants