Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing import statemet #32

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Add missing import statemet #32

merged 1 commit into from
Jul 23, 2019

Conversation

msosyak
Copy link
Contributor

@msosyak msosyak commented Jul 23, 2019

In case of some fail "global name 'sys' is not defined" error logs are more visible then real error message
Example:

Jul 23 14:36:31.223795 cab18-2-switch2 INFO pmon#syseepromd: Starting up...
Jul 23 14:36:31.931699 cab18-2-switch2 ERR pmon#syseepromd: Failed to load eeprom utility: Failed to load platform module 'eeprom': [Errno 2] No such file or directory
Jul 23 14:36:31.931929 cab18-2-switch2 INFO pmon#supervisord: syseepromd Failed to load eeprom utility: Failed to load platform module 'eeprom': [Errno 2] No such file or directory
Jul 23 14:36:31.932004 cab18-2-switch2 INFO pmon#supervisord: syseepromd Traceback (most recent call last):
Jul 23 14:36:31.932004 cab18-2-switch2 INFO pmon#supervisord: syseepromd   File "/usr/bin/syseepromd", line 142, in <module>
Jul 23 14:36:31.932034 cab18-2-switch2 INFO pmon#supervisord: syseepromd     main()
Jul 23 14:36:31.932034 cab18-2-switch2 INFO pmon#supervisord: syseepromd   File "/usr/bin/syseepromd", line 139, in main
Jul 23 14:36:31.932048 cab18-2-switch2 INFO pmon#supervisord: syseepromd     syseepromd.run()
Jul 23 14:36:31.932059 cab18-2-switch2 INFO pmon#supervisord: syseepromd   File "/usr/bin/syseepromd", line 107, in run
Jul 23 14:36:31.932065 cab18-2-switch2 INFO pmon#supervisord: syseepromd     self.load_eeprom_util()
Jul 23 14:36:31.932092 cab18-2-switch2 INFO pmon#supervisord: syseepromd   File "/usr/bin/syseepromd", line 55, in load_eeprom_util
Jul 23 14:36:31.932092 cab18-2-switch2 INFO pmon#supervisord: syseepromd     sys.exit(ERR_EEPROMUTIL_LOAD)
Jul 23 14:36:31.932111 cab18-2-switch2 INFO pmon#supervisord: syseepromd NameError: global name 'sys' is not defined

Signed-off-by: Myron Sosyak msosyak@barefootnetworks.com

Add missing import statemet
2365564 
Signed-off-by: Myron Sosyak <msosyak@barefootnetworks.com>
@jleveque jleveque merged commit 2fbe910 into sonic-net:master Jul 23, 2019
@keboliu keboliu mentioned this pull request Aug 14, 2019
Merged
jleveque pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Aug 14, 2019
@keboliu @jleveque
[sonic-platform-common][sonic-platform-daemon] Update submodules (#3333)
b283b4b 
[sonic-platform-common]

[sonic_sfp] Interpret sff 'int' element =0 as valid value (sonic-net/sonic-platform-common#51)
add more error code to get_transceiver_change_event ((sonic-net/sonic-platform-common#50)
[sonic_platform_base] support new-platform-api-based daemons ((sonic-net/sonic-platform-common#48)
sync change to sonic_platform_base/sonic_sfp and create symbol link ((sonic-net/sonic-platform-common#49)
Add parser support for Tx_RxLos,TxFault, PowerControl, ResetStatus in sff8436.py ((sonic-net/sonic-platform-common#45)
readd type_abbrv_name in sonic_sfp/sff8436.py ((sonic-net/sonic-platform-common#44)
[psu_base] get_status_led() returns current state of the status LED ((sonic-net/sonic-platform-common#39)
Fix abbrv name for OSFP ((sonic-net/sonic-platform-common#36)
[sff8436] support "Control Bytes" and "Options" ((sonic-net/sonic-platform-common#38)
sonic_sfp: avoid possible key error in get_physical_to_logical() ((sonic-net/sonic-platform-common#37)

[sonic-platform-daemons]

[xcvrd] Enhance xcvrd to handle new system level event/error (sonic-net/sonic-platform-daemons#39)
[xcvrd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#38)
[psud] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#37)
[syseepromd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#36)
Add missing import statemet (sonic-net/sonic-platform-daemons#32)
sonic_xcvrd: Support for DOM Threshold values for EEPROM dump (sonic-net/sonic-platform-daemons#29)
wangshengjun pushed a commit to wangshengjun/sonic-buildimage that referenced this pull request Nov 16, 2020
@keboliu @wangshengjun
[sonic-platform-common][sonic-platform-daemon] Update submodules (son…
f7ca312 
…ic-net#3333)

[sonic-platform-common]

[sonic_sfp] Interpret sff 'int' element =0 as valid value (sonic-net/sonic-platform-common#51)
add more error code to get_transceiver_change_event ((sonic-net/sonic-platform-common#50)
[sonic_platform_base] support new-platform-api-based daemons ((sonic-net/sonic-platform-common#48)
sync change to sonic_platform_base/sonic_sfp and create symbol link ((sonic-net/sonic-platform-common#49)
Add parser support for Tx_RxLos,TxFault, PowerControl, ResetStatus in sff8436.py ((sonic-net/sonic-platform-common#45)
readd type_abbrv_name in sonic_sfp/sff8436.py ((sonic-net/sonic-platform-common#44)
[psu_base] get_status_led() returns current state of the status LED ((sonic-net/sonic-platform-common#39)
Fix abbrv name for OSFP ((sonic-net/sonic-platform-common#36)
[sff8436] support "Control Bytes" and "Options" ((sonic-net/sonic-platform-common#38)
sonic_sfp: avoid possible key error in get_physical_to_logical() ((sonic-net/sonic-platform-common#37)

[sonic-platform-daemons]

[xcvrd] Enhance xcvrd to handle new system level event/error (sonic-net/sonic-platform-daemons#39)
[xcvrd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#38)
[psud] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#37)
[syseepromd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#36)
Add missing import statemet (sonic-net/sonic-platform-daemons#32)
sonic_xcvrd: Support for DOM Threshold values for EEPROM dump (sonic-net/sonic-platform-daemons#29)
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
@lguohan
Added type abbrev name to be used in media_settings.json for Dynamic …
7f95a2a 
…transceiver tuning (sonic-net#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@akokhan akokhan akokhan approved these changes

Assignees
No one assigned
Labels
Bug syseepromd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msosyak @jleveque @akokhan