-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[as5835-54x] Implement get_transceiver_change_event() in sfputil.py #3308
Conversation
Signed-off-by: brandon_chuang <brandon_chuang@CicadaBuildServer.accton.com.tw>
return int(rev,16) | ||
|
||
data = {'valid':0, 'last':0, 'present':0} | ||
def get_transceiver_change_event(self, timeout=2000): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function is a blocking call and the default timeout is 0 meaning it is blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation does not meet the spec.
…he spec Signed-off-by: brandon_chuang <brandon_chuang@CicadaBuildServer.accton.com.tw>
Add another commit to follow the spec. |
retest vsimage please |
…onic-net#3308) Signed-off-by: brandon_chuang <brandon_chuang@CicadaBuildServer.accton.com.tw>
Signed-off-by: brandon_chuang brandon_chuang@edge-core.com
- What I did
- How I did it
Read the presence status of all ports from CPLD and update the presence dictionary in get_transceiver_change_event() of sfputil.py
- How to verify it
sfputil show presence
sfputil show eeprom
show interfaces transciever