[build] Fix cleaning SONIC_PYTHON_STDEB_DEBS #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* slave.mk * .gitignore The SONIC_PYTHON_STDEB_DEBS group is part of SONIC_CLEAN_DEBS for cleaning with 'make clean', but this group is overlooked since they reside in PYTHON_DEBS_PATH, not DEBS_PATH. This fix creates a separate clean rule for SONIC_PYTHON_STDEB_DEBS. Also noticed the .arch file showing up on 'git status' so added it to .gitignore. Signed-off-by: Greg Paussa <greg.paussa@broadcom.com>
jleveque
approved these changes
Aug 15, 2019
lguohan
approved these changes
Aug 15, 2019
wangshengjun
pushed a commit
to wangshengjun/sonic-buildimage
that referenced
this pull request
Nov 16, 2020
* slave.mk * .gitignore The SONIC_PYTHON_STDEB_DEBS group is part of SONIC_CLEAN_DEBS for cleaning with 'make clean', but this group is overlooked since they reside in PYTHON_DEBS_PATH, not DEBS_PATH. This fix creates a separate clean rule for SONIC_PYTHON_STDEB_DEBS. Also noticed the .arch file showing up on 'git status' so added it to .gitignore. Signed-off-by: Greg Paussa <greg.paussa@broadcom.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
* slave.mk
* .gitignore
The SONIC_PYTHON_STDEB_DEBS group is part of SONIC_CLEAN_DEBS
for cleaning with 'make clean', but this group is overlooked
since they reside in PYTHON_DEBS_PATH, not DEBS_PATH. This
fix creates a separate clean rule for SONIC_PYTHON_STDEB_DEBS.
Also noticed the .arch file showing up on 'git status' so
added it to .gitignore.
Signed-off-by: Greg Paussa <greg.paussa@broadcom.com>
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
RB=2162688
G=lnos-reviewers
R=pchaudhary,pmao,rmolina,samaity,sfardeen,zxu
A=zxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SONIC_PYTHON_STDEB_DEBS group is part of SONIC_CLEAN_DEBS
for cleaning with 'make clean', but this group is overlooked
since they reside in PYTHON_DEBS_PATH, not DEBS_PATH. This
fix creates a separate clean rule for SONIC_PYTHON_STDEB_DEBS.
Also noticed the .arch file showing up on 'git status' so
added it to .gitignore.
Signed-off-by: Greg Paussa greg.paussa@broadcom.com
- What I did
Fixed 'make clean' so that all the files in the target/ subtree are removed. Currently, there is a set of files in target/python-debs that doesn't get removed by a 'make clean'.
Separately, the .arch file created during 'make configure' was appearing as an untracked file in the 'git status' output, so I added it to the .gitignore file (just like the .platform file).
- How I did it
Moved the SONIC_PYTHON_STDEB_DEBS out of SONIC_CLEAN_DEBS and into its own SONIC_CLEAN_STDEB_DEBS list and added a new clean recipe to remove its build artifacts from PYTHON_DEBS_PATH instead of DEBS_PATH.
- How to verify it
After doing a build, issue 'make clean' and check the target tree contents using 'ls -alR target/'. There should be no files left in any of the subdirectories, including target/python-debs which should now be empty as well.
- Description for the changelog
Create separate clean rule for SONIC_PYTHON_STDEB_DEBS.
- A picture of a cute animal (not mandatory but encouraged)