[build_debian] Include checksum of ASIC config files in SONiC filesystem #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds script to generate checksums for ASIC config files * Adds step to build_debian that copies ASIC config checksum into SONiC filesystem Signed-off-by: Danny Allen daall@microsoft.com
jleveque
reviewed
Aug 27, 2019
|
The script could be exchanged to |
This is actually originally how I approached this. The issue is that some of the files in sample are actually just samples, so hashing all of them may have some unintended consequences in the future. In addition, we may include more files in the future, so it seemed a little safer to write a more general script with that in mind. |
pavel-shirshov
approved these changes
Aug 28, 2019
pavel-shirshov
approved these changes
Aug 29, 2019
yxieca
approved these changes
Aug 29, 2019
lguohan
approved these changes
Sep 3, 2019
|
retest this please |
sridhar-ravindran
pushed a commit
to sridhar-ravindran/sonic-buildimage
that referenced
this pull request
Sep 6, 2019
…tem (sonic-net#3384) [build_debian] Generate checksum of ASIC config files * Adds script to generate checksums for ASIC config files * Adds step to build_debian that copies ASIC config checksum into SONiC filesystem Signed-off-by: Danny Allen daall@microsoft.com
yxieca
pushed a commit
that referenced
this pull request
Sep 9, 2019
…tem (#3384) [build_debian] Generate checksum of ASIC config files * Adds script to generate checksums for ASIC config files * Adds step to build_debian that copies ASIC config checksum into SONiC filesystem Signed-off-by: Danny Allen daall@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I modified the build_debian.sh script to include a checksum of ASIC configuration files in the
/etc/sonicdirectory of the built SONiC image.- How I did it
I wrote a script to read through a static list of configuration files (at this stage, only those found in
sonic-swss/swssconfig/samples) and generate an MD5 checksum of those configuration files.- How to verify it
Build a new SONiC image and verify that
fsroot/etc/soniccontains anasic_config_checksumfile.- Description for the changelog
Include checksum of ASIC config files in SONiC filesystem.
- A picture of a cute animal (not mandatory but encouraged)
