format commit as code

…sue-template-1

update demo links in issue template

escape `

…codecs

isCodecSupportedInMp4 test audio codecs as audio

* Check if PTS has wrapped after applying PTS time offset

* Fix bug accessing buffered track array

* Intiialize vttCCs map with cc 0

and include this in the deployments readme

…sion-for-deploys

use the version from package.json when deploying

…mended merging library.

Update light build targets to include Typescript extensions

Docs: abrBandWidthFactor and abrBandWidthUpFactor

Thank you to Tom Jenkinson for acting as a reviewer for this work, including writing some suggestions via the GitHub PR github.com/video-dev/pull/2073. The commit history has been squashed as it was a fairly lengthly process to get everything working to support the conversion to TypeScript.

Early in the history of this commit, we converted properties to be initialized to `null`. This was incorrect, as it changes the behaviour of code that uses `Object.keys` calls to check if an object has any keys on it. Before, they would be empty, but if the properties are set to null, this check is no longer valid and it changes the behaviour. This is something to look out for in the future of other conversions, as the values themselves are often times reset to the `null`, but begin as undefined.

Added a common `types` folder for interfaces where the ownership of the type wasn't clear for the individual file. The default no-op logger which is the inferred usage did not have any arguments in it's method signature. By adding an argument, TypeScript is able to infer the correct interface. As well the Karma and Webpack configuration had to be updated to enable building TypeScript, and getting testing coverage information from Istanbul.

Define lib "es2015" and "dom" to add HTMLMediaElement, SourceBuffer and Number.isFinite definitions to the TypeScript binary when it is doing type-checking.

When attempting to lint the older version of `typescript-eslint-parser` would emit `no-undef` errors for TypeScript interfaces. Updating the package fixes this issue.

Tom pointed out that we should not use global module declarations to extend default HTML types since users will eventually be importing *.d.ts files from the hls.js project and this would also extend their types. Due to this feedback switched to defining a module local type `ExtendedSourceBuffer`. Which instead extends with the `ended` prop.

Event Handlers were set to be part of the private scope. While this has no effect now, it will be important to ensure other modules do not directly invoke the event handlers. Other methods that were prefixed with a `_` were also set into the private scope.

Where possible, code was switched to early-exit to lower the cognitive load in conditional statements, an example of this was the doAppend method. Another cleanup statement was switching handling of error codes and the comments to be closer to the conditional to which they applied.

Switched to using the Record<Key, Value> type to help support access via the index signature [key: T] syntax in the future.

An issue that was fixed in this commit was that The controller previous exposed the local `pendingTracks` property through the event and did not set the buffer on `this.tracks` instead opting to set it on the individual track, which bubbled up to the pendingTracks object, whose reference was lost in the buffer-controller module. This commit changes this behaviour so that the controller publishes `tracks` from the public variable on the controller rather than the pendingTracks which are passed into createSourceBuffers. This also means that this fixes the `.buffer.buffered` being undefined on the demo page. Added unit tests to cover the new behaviour of throwing an error if createSourceBuffer is called without an attached media element.

Co-Authored-By: Beraliv <beraliv.spb@gmail.com>

Buffer Controller TypeScript

Make bandwidth estimate public API

* Increase adts.js test coverage to 100%

Added TypeScript types to the code.

Handled media detached and removing the encrypted event listener.

Clears the encrypted event listener from the HTMLMediaElement in controller, and releases the stored reference.

Simplify bandwidth calculation by making; change docs to correctly reference bandwidth in bits/s

EME Controller TypeScript

* Convert tests to Chai BDD

* Invoke mocha with exit so that travis doesnt hang on func test completion

this follows the same process that runs for canary releases

because on netlify it clones the whole thing

Fix video-dev#2061

configure netlify for PR's

Co-Authored-By: itsjamie <1956521+itsjamie@users.noreply.github.com>

parseByteRange -> setByteRange
- removed it returning the parsed value since its usage was like a setter.

…-dev#2106)

Fix null reference in logger when console is not available

…deo-dev#2077)

Apply TypeScript to Fragment & LevelKey

* Upgrade to webpack 4, babel 7

* Use straight git link for webworkify dep

* Use simpler git url

* Re-add globalObject workaround

* Bump karma dep versions

* Dont preprocess non-test files

* Use @babel/register over ts-node

* Update demo `const` usage.

* Use webpack debug config in Karma configuration rather than duplication.

* remove events/EventEmitter && move Observer to ts

* disable node modules in webpack

Lint fixes

…com image link to new domain and using https (video-dev#2127)

…code

(misc) Removing IE8-specific (dead) vtt/cue code

* Reduce GC pressure from ID3._utf8ArrayToStr

If the TextDecoder API exists, it is significantly faster for large payloads than the existing code.
This work happens on the main thread, so large payloads may cause UI hiccups. On my Chrome70 profiler runs, most of the time was actually being spent in GC.

…ideo-dev#2117)

* video-devGH-2082: Replacing usage of Array.prototype.find and Array.protoype.findIndex with alternate solutions

* video-devGH-2082: Adding eslint rule for restricting usage of findIndex/find methods

Basic typescript of event handler.

…ader-typescript

Per feedback from John, the further defined response type caused issue in callers.

…rack.len (video-dev#2096)

* mp4-remuxer / remuxAudio() : dont rely on track.len to compute mdatSize

recompute it by looping through all samples and summing their individual size

get rid of track.len as it should now be useless

related to video-dev#2063

…js into playlist-loader-typescript

…cript

* Playlist-loader rename.

* Playlist Loader conversion to TypeScript.

* Change responseType to string

* Typo fix for destory -> destroy.

* Change networkDetails type to "unknown".

…mport preprocess.

Fixed some typos

* Start and stop subtitle loading in sync with startLoad()/stopLoad() API calls
* Compute sliding & merge subtitle playlists during live playback
* Fix shared references between subtitle-track-controller and subtitle-stream-controller
* Refactoring:
     * Extend subtitle-stream-controller from base-stream-controller
     * Move more shared logic into base-stream-controller
     * Move live reload interval calculation into a shared function & import into subtitle-track-controller
    * Remove the trackId from subtitle fragments, and refer to them by their level property
    * Several other minor refactorings (flipped conditionals, destructuring args, organizing functions)
* Add a bunch of unit tests

Fix XSS issue on metrics page reported in video-dev#2161.

stream-controller: remove inaccurate comment

Fix Istanbul reporting

which includes fix for issue with create-react-app

fixes video-dev#2064

…mically (video-dev#1986)

* Adding the ability for CapLevelController to be enabled/disabled dynamically.

* Updating API docs to include capLevelToPlayerSize as getter/setter.

* Updated documentation to further clarify capLevelToPlayerSize

* Added test to ensure stop capping called when cap level controller destroyed.

* Added test that nextLevelSwitch is called when we stop capping.

…ev#2169)