Fix netlify build in master and add build checks #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjamie
reviewed
Oct 16, 2019
scripts/precommit.sh
Outdated
|
|
||
| npm run lint | ||
| npm run type-check | ||
| npm run docs |
There was a problem hiding this comment.
Do we need to generate docs on every commit? I say no.
If it's to check that it works, we should add a Github action / travis check that the docs build and let the CI run it.
There was a problem hiding this comment.
OK. That was overzealous of me. npm run docs is out.
Run docs in travis build Fix type check errors
robwalch
force-pushed
the
bugfix/sanity-checks
branch
from
7f1c09e
to
efdaedf
Compare
itsjamie
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
and precommitWhy is this Pull Request needed?
These changes are to help ensure we don't break netlify builds when making changes, and are necessary to generate a release with a demo page.
The sanity-check target is one I run a lot locally so I made a shortcut for it.
These changes have already been made in feature/v1.0.0.
Checklist