Add "sanity-check" package script

Run docs in travis build and precommit
Fix type check errors

package.json

@@ -28,6 +28,7 @@
     "lint:quiet": "./scripts/lint.sh --quiet",
     "precommit": "./scripts/precommit.sh",
     "pretest": "npm run lint",
+    "sanity-check": "npm run lint && npm run docs && npm run type-check && npm run build:types && npm run build && npm run test:unit",
     "start": "npm run dev",
     "test": "npm run test:unit && npm run test:func",
     "test:unit": "karma start karma.conf.js",

scripts/precommit.sh

@@ -1,3 +1,6 @@
 #!/bin/bash
-npm run lint
+set -e
 
+npm run lint
+npm run type-check
+npm run docs

scripts/travis.sh

@@ -11,7 +11,9 @@ if [ "${TRAVIS_MODE}" = "build" ]; then
   npm run lint
   echo "travis_fold:end:lint"
   echo "travis_fold:start:build"
+  npm run type-check
   npm run build
+  npm run build:types
   echo "travis_fold:end:build"
   echo "travis_fold:start:docs"
   npm run docs
@@ -47,7 +49,10 @@ elif [ "${TRAVIS_MODE}" = "release" ] || [ "${TRAVIS_MODE}" = "releaseCanary" ]
   fi
   node ./scripts/set-package-version.js
   npm run lint
+  npm run type-check
   npm run build:ci
+  npm run build:types
+
   if [ "${TRAVIS_MODE}" != "netlifyPr" ]; then
     npm run test:unit
     if [[ $(node ./scripts/check-already-published.js) = "not published" ]]; then

src/controller/audio-track-controller.js

@@ -98,7 +98,7 @@ class AudioTrackController extends TaskLoop {
    *
    * Set-up metadata update interval task for live-mode streams.
    *
-   * @param {} data
+   * @param {*} data
    */
   onAudioTrackLoaded (data) {
     if (data.id >= this.tracks.length) {

src/controller/timeline-controller.ts

@@ -21,7 +21,7 @@ class TimelineController extends EventHandler {
   private cueRanges: Array<any> = [];
   private captionsTracks: any = {};
   private captionsProperties: any;
-  private cea608Parser: Cea608Parser;
+  private cea608Parser!: Cea608Parser;
   private lastSn: number = -1;
   private prevCC: number = -1;
   private vttCCs: any = null;
@@ -34,7 +34,6 @@ class TimelineController extends EventHandler {
       Event.MANIFEST_LOADING,
       Event.MANIFEST_LOADED,
       Event.FRAG_LOADED,
-      Event.LEVEL_SWITCHING,
       Event.INIT_PTS_FOUND);
 
     this.hls = hls;
@@ -129,7 +128,7 @@ class TimelineController extends EventHandler {
       } else {
         captionsTracks[trackName] = existingTrack;
         clearCurrentCues(captionsTracks[trackName]);
-        sendAddTrackEvent(captionsTracks[trackName], media);
+        sendAddTrackEvent(captionsTracks[trackName], media as HTMLMediaElement);
       }
     }
   }
@@ -199,7 +198,7 @@ class TimelineController extends EventHandler {
       this.tracks.forEach((track, index) => {
         let textTrack;
         if (index < inUseTracks.length) {
-          let inUseTrack = null;
+          let inUseTrack: TextTrack | null = null;
 
           for (let i = 0; i < inUseTracks.length; i++) {
             if (canReuseVttTextTrack(inUseTracks[i], track)) {
@@ -228,10 +227,6 @@ class TimelineController extends EventHandler {
     }
   }
 
-  onLevelSwitching () {
-    this.enabled = this.hls.currentLevel.closedCaptions !== 'NONE';
-  }
-
   onFragLoaded (data: { frag: Fragment, payload: any }) {
     const { frag, payload } = data;
     const { cea608Parser, initPTS, lastSn, unparsedVttFrags } = this;
@@ -324,7 +319,7 @@ class TimelineController extends EventHandler {
   }
 
   onFragParsingUserdata (data: { samples: Array<any> }) {
-    if (!this.enabled || !this.config.enableCEA708Captions) {
+    if (!this.enabled || !this.cea608Parser) {
       return;
     }
 
@@ -343,7 +338,7 @@ class TimelineController extends EventHandler {
     let count = byteArray[0] & 31;
     let position = 2;
     let tmpByte, ccbyte1, ccbyte2, ccValid, ccType;
-    let actualCCBytes = [];
+    let actualCCBytes: number[] = [];
 
     for (let j = 0; j < count; j++) {
       tmpByte = byteArray[position++];

src/loader/m3u8-parser.ts

@@ -133,7 +133,7 @@ export default class M3U8Parser {
 
         if (audioGroups.length) {
           // If there are audio groups signalled in the manifest, let's look for a matching codec string for this track
-          const groupCodec = M3U8Parser.findGroup(audioGroups, media.groupId);
+          const groupCodec = M3U8Parser.findGroup(audioGroups, media.groupId as string);
 
           // If we don't find the track signalled, lets use the first audio groups codec we have
           // Acting as a best guess

tests/unit/controller/ewma-bandwidth-estimator.js

@@ -25,9 +25,9 @@ describe('EwmaBandWidthEstimator', function () {
     bwEstimator.sample(8000, 1000000);
     expect(bwEstimator.getEstimate()).to.equal(1000000);
     bwEstimator.sample(4000, 1000000);
-    expect(bwEstimator.getEstimate()).to.equal(1396480.1544736226);
+    expect(bwEstimator.getEstimate()).to.closeTo(1396480.1544736226, 0.000000001);
     bwEstimator.sample(1000, 1000000);
-    expect(bwEstimator.getEstimate()).to.equal(2056826.9489827948);
+    expect(bwEstimator.getEstimate()).to.closeTo(2056826.9489827948, 0.000000001);
   });
 
   it('returns correct value bitrate is slow=9,fast=5', function () {
@@ -36,8 +36,8 @@ describe('EwmaBandWidthEstimator', function () {
     bwEstimator.sample(8000, 1000000);
     expect(bwEstimator.getEstimate()).to.equal(1000000);
     bwEstimator.sample(4000, 1000000);
-    expect(bwEstimator.getEstimate()).to.equal(1439580.319105247);
+    expect(bwEstimator.getEstimate()).to.closeTo(1439580.319105247, 0.000000001);
     bwEstimator.sample(1000, 1000000);
-    expect(bwEstimator.getEstimate()).to.equal(2208342.324322311);
+    expect(bwEstimator.getEstimate()).to.closeTo(2208342.324322311, 0.000000001);
   });
 });