Clear audio tick interval when we stopLoad. #2110
Conversation
|
This doesn't solve #2099 yet. Looks like there is more to it, but this is as far as I could debug tonight. While debugging, I was able to see that the audio track will sometimes load, and the video will stall out, and Chrome will switch to a audio only control set, and I will hear audio. But as soon as a video frag loads, I would lose audio, and gain a picture. |
|
Closing in favor of #2123. |
|
Agree with @OrenMe, audio should not reload when stopped. Let's re-open and decide if it's safe enough to go into the next patch, or should be in the minor |
|
@itsjamie do you have any lead on the issue that I can follow? |
|
Unfortunately, not really @OrenMe. The few things I did identify as definites were part of this PR. One definitely was that on reattachment to a track with alternate audio, only a single buffer codec event was expected, whereas on first load, two were (correctly). Additionally, the interval kept running in the audio controller, which is what the interval getting cleared was fixing. I thought that the wrong amount of buffer codec events was the core issue, but when I tested it still didn't work. |
… not play On re-attch the context of altAudio is not saved in buffer control so it doesn't know to create two source buffers. Also, in context of stream controller it doesn't reset the `altAudio` flag. I also noticed that stream controller is reloading the entire frags it has in `fragmentTracker` and it seems it needs to be reset on detach, otherwise there's a very long start delay where unncessery buffering occurs. based on #2110 and fixes #2099.
This PR will...
Clears Tick interval in stop load for audio-stream-controller.
Why is this Pull Request needed?
Looking at #2099 root cause, I noticed that the audio-stream-controller does not clear its tick interval when stopLoad is called, causing it to force loop in the stopped state while the media is detached.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist