Add TS to Cue utilities. #2202
Add TS to Cue utilities. #2202
Conversation
| } catch (err) { | ||
| // for IE11 | ||
| event = document.createEvent('Event'); | ||
| event.initEvent('addtrack', false, false); | ||
| } | ||
| event.track = track; | ||
| (event as any).track = track; |
There was a problem hiding this comment.
I know this PR is specific to TS conversion, but for a future change - we might be able to use a TrackEvent instead of Event
src/utils/output-filter.ts
Outdated
| @@ -16,8 +25,8 @@ export default class OutputFilter { | |||
| this.startTime = null; | |||
| } | |||
|
|
|||
| newCue (startTime, endTime, screen) { | |||
| if (this.startTime === null || this.startTime > startTime) { | |||
| newCue (startTime: number | null, endTime: number, screen: CaptionScreen) { | |||
There was a problem hiding this comment.
If we keep this.time a number in the parser, we don't have to do this
There was a problem hiding this comment.
👍 I used a sentinel value of -1 to replace where null was.
There was a problem hiding this comment.
Made the sentinel value a const, and export it for usage in OutputFilter now.
This removed the need to check if startTime was null.
Still need to check the (this.startTime > startTime) so that it remains the smallest value passed to it that isn't the sentinel.
itsjamie
force-pushed
the
type-some-utilities
branch
from
1ccaa4b
to
6cf7591
Compare
…be replaced with a sentinel -1 value. This simplified handling in the output filter.
|
My handling of the OutputFilter is wrong. Will fix in AM. |
|
Fixed the issue with OutputFilter. |
itsjamie
dismissed stale reviews from johnBartos and michaelcunningham19
Addressed the comments.
This PR will...
Progress towards Typescriptifying HLS.js
Why is this Pull Request needed?
For easy dev.
Are there any points in the code the reviewer needs to double check?
CEA-608 parser review closely.
Resolves issues:
N/A, move towards #2070
Checklist