Utils typescript #2182
Merged
Utils typescript #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: itsjamie <1956521+itsjamie@users.noreply.github.com>
OrenMe
reviewed
Mar 17, 2019
Both ; and , are allowed because the newline seems to be what matters to line terminate. Just using it consistently in this file.
Simple POJO definition gets simple type def.
This narrows the definition of what we accept as "media" to something that is "Bufferable". Which is an object with a "buffered" property that contains `TimeRanges`.
michaelcunningham19
approved these changes
Mar 27, 2019
tjenkinson
approved these changes
Mar 27, 2019
| let vbuffered = media.buffered, buffered = [], i; | ||
| let vbuffered = media.buffered; | ||
| let buffered: BufferTimeRange[] = []; | ||
| let i: number; | ||
| for (i = 0; i < vbuffered.length; i++) { |
There was a problem hiding this comment.
Suggested change
| for (i = 0; i < vbuffered.length; i++) { | |
| for (let i = 0; i < vbuffered.length; i++) { |
then you don't need to define it above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Add types for a few helpers modules.
Why is this Pull Request needed?
Progress towards typescripting hls.js
Are there any points in the code the reviewer needs to double check?
No.
Resolves issues:
Working towards #2070.
Checklist