Fix TS errors #2306
Merged
Fix TS errors #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBartos
force-pushed
the
bugfix/type-errors
branch
from
2131164
to
ffea65b
Compare
johnBartos
force-pushed
the
bugfix/type-errors
branch
from
ffea65b
to
73da534
Compare
michaelcunningham19
approved these changes
Jul 25, 2019
OrenMe
reviewed
Jul 25, 2019
| @@ -305,6 +305,17 @@ class EMEController extends EventHandler { | |||
| return; | |||
| } | |||
|
|
|||
| // initData is null if the media is not CORS-same-origin | |||
| if (!initData) { | |||
There was a problem hiding this comment.
Shouldn’t this be caught higher up?
There was a problem hiding this comment.
It could be, but it made sense to lump this handler along with all of the others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
initData, and add new error details for missing init datathis.cueStartTimeWhy is this Pull Request needed?
So that our build passes without TS errors
Are there any points in the code the reviewer needs to double check?
Sure
Resolves issues:
N/A
Checklist