Bugfix: Uncaught exception trying to flush back buffer when starting live stream #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or live stream without media attached Fixes #2333
robwalch
requested review from
tchakabam,
mangui,
itsjamie,
johnBartos and
dsparacio
itsjamie
previously approved these changes
Sep 26, 2019
robwalch
dismissed stale reviews from michaelcunningham19, itsjamie, mangui, and tchakabam
via
230df65
itsjamie
deleted the
bugfix/remove-thow-without-media-on-flush-backbuffer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Log an error rather than throwing an exception when
flushLiveBackBufferis called for a live stream without media attached.Why is this Pull Request needed?
Fixes an edge-case where the exception prevents a live stream starting.
Resolves issues:
Fixes #2333
Checklist