Updated header and Viacom image link in 'They use hls.js in production!' section of README #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com image link to new domain and using https
itsjamie
approved these changes
Feb 12, 2019
|
@brentsmith-dev Thanks! Always appreciate grammatical corrections |
johnBartos
approved these changes
Feb 12, 2019
dyue
added a commit
to dyue/hls.js
that referenced
this pull request
Mar 9, 2019
* origin/master: (59 commits) Change networkDetails type to "unknown". mp4-remuxer / remuxAudio() : recompute mdatSize / dont rely on audioTrack.len (video-dev#2096) Typo fix for destory -> destroy. Change responseType to string Callbacks are defined, removing TODO. video-devGH-2082: Replacing usage of Array.prototype.find/findIndex (video-dev#2117) Reduce GC pressure from ID3._utf8ArrayToStr (video-dev#2035) (misc): converting binary search to typescript (video-dev#2129) (misc) Removing IE8-specific (dead) vtt/cue code Fixed case of 'They use hls.js in production!' header and updated Viacom image link to new domain and using https (video-dev#2127) remove events/EventEmitter && move Observer to ts (video-dev#2097) Basic typescript of event handler. Update webpack to use babel loader with support for TS. (video-dev#2119) Allow console statement in test bench and saucelabs code. Lint fixes Playlist Loader conversion to TypeScript. Playlist-loader rename. Change IV handling for initSegments to just log a warning. Add handling for AES-128 encrypted initialization segments needing IV. (misc) Adding ace editor to demo to enable advanced customization (video-dev#2077) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viacom image should point at new domain and use https
Changing 'they use hls.js in production !' to 'They use hls.js in production!'
This PR will...
Update viacom image url and fix header text in 'they use hls.js in production !' section of README.md
Why is this Pull Request needed?
Clean up the header and ensure the image link doesn't break in the near future.
Are there any points in the code the reviewer needs to double check?
No
Resolves issues:
None
Checklist