-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2016-10-11, Version 6.8.0 (Current) #9034
Commits on Sep 29, 2016
-
PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9ecfc32 - Browse repository at this point
Copy the full SHA 9ecfc32View commit details -
deps: hotfix upgrade npm tap version for tests
PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4d41bd9 - Browse repository at this point
Copy the full SHA 4d41bd9View commit details
Commits on Sep 30, 2016
-
inspector: fix tests on Windows
Eugene Ostroukhov authored and Myles Borins committedSep 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 3222b66 - Browse repository at this point
Copy the full SHA 3222b66View commit details -
inspector: introduce a smoke test
This test executes a simple debug session over the inspector protocol. PR-URL: #8429 Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Eugene Ostroukhov authored and Myles Borins committedSep 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 0b90ff7 - Browse repository at this point
Copy the full SHA 0b90ff7View commit details -
inspector: zero out structure members
Ctor has to be added as memset to 0 is no longer an option, since the structure now has std::vector member. Attempt at fixing #8155 (so far I was not able to repro it) PR-URL: #8536 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Eugene Ostroukhov authored and Myles Borins committedSep 30, 2016 Configuration menu - View commit details
-
Copy full SHA for b05ce84 - Browse repository at this point
Copy the full SHA b05ce84View commit details -
inspector: report default context
Eugene Ostroukhov authored and Myles Borins committedSep 30, 2016 Configuration menu - View commit details
-
Copy full SHA for 4ed46b4 - Browse repository at this point
Copy the full SHA 4ed46b4View commit details -
inspector: wait for both sides closing
Removes race condition when test relied on both sides of the socket to be closed on the same UV event loop iteration. Fixes: #8498 PR-URL: #8505 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
Eugene Ostroukhov authored and Myles Borins committedSep 30, 2016 Configuration menu - View commit details
-
Copy full SHA for f817875 - Browse repository at this point
Copy the full SHA f817875View commit details -
src: add /json/protocol endpoint to inspector
Embed the compressed and minified protocol.json from the bundled v8_inspector and make it available through the /json/protocol endpoint. Refs: nodejs/diagnostics#52 PR-URL: #7491 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a62999a - Browse repository at this point
Copy the full SHA a62999aView commit details -
inspector: address race conditions
Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: #8669 PR-URL: #8672 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Eugene Ostroukhov authored and Myles Borins committedSep 30, 2016 Configuration menu - View commit details
-
Copy full SHA for e80ae13 - Browse repository at this point
Copy the full SHA e80ae13View commit details -
Remove obsolete build file entries. Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #8753
Eugene Ostroukhov authored and Myles Borins committedSep 30, 2016 Configuration menu - View commit details
-
Copy full SHA for f4f9cf7 - Browse repository at this point
Copy the full SHA f4f9cf7View commit details -
test: mark test-inspector flaky on windows
PR-URL: #8835 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83ed508 - Browse repository at this point
Copy the full SHA 83ed508View commit details -
doc: add example for running with v8-inspector
Add example to show what running Node.js with `--inspect` should look like. Some IDEs do not show the link when running with `--inspect`. This example hints to what the full output looks like. PR-URL: #8845 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3eb93e1 - Browse repository at this point
Copy the full SHA 3eb93e1View commit details
Commits on Oct 4, 2016
-
The patch should have been bumped in aafc314 but it was missed. Ref: aafc314 Ref: #8673 PR-URL: #8851 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Myles Borins committedOct 4, 2016 Configuration menu - View commit details
-
Copy full SHA for 9d41e89 - Browse repository at this point
Copy the full SHA 9d41e89View commit details
Commits on Oct 11, 2016
-
doc: add not-an-aardvark to collaborators
PR-URL: #8525 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 125df45 - Browse repository at this point
Copy the full SHA 125df45View commit details -
test: fix flaky test-force-repl
Increase time allowed for startup from 1 second to 5 seconds to avoid occasional flakiness. While at it, refactor a few minor things such as var->const and using common.mustCall(). Fixes: #8483 PR-URL: #8484 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ff238c8 - Browse repository at this point
Copy the full SHA ff238c8View commit details -
doc: standardize rest parameters
PR-URL: #8485 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 929d9bb - Browse repository at this point
Copy the full SHA 929d9bbView commit details -
doc: add imyller to collaborators
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com> PR-URL: #8530 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c96618f - Browse repository at this point
Copy the full SHA c96618fView commit details -
doc: add gibfahn to collaborators
PR-URL: #8533 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for 8e28e03 - Browse repository at this point
Copy the full SHA 8e28e03View commit details -
doc: capitalize arguments' type names in url doc
PR-URL: #8489 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71dd4c1 - Browse repository at this point
Copy the full SHA 71dd4c1View commit details -
timers: remove unreachable code
PR-URL: #8487 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 02da155 - Browse repository at this point
Copy the full SHA 02da155View commit details -
doc: remove duplicate content from readline doc
Remove a duplicate sentence from the `rl.close()` method description. PR-URL: #8497 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8a1f743 - Browse repository at this point
Copy the full SHA 8a1f743View commit details -
test: add coverage for client._addHandle()
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests. PR-URL: #8518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 30e995f - Browse repository at this point
Copy the full SHA 30e995fView commit details -
doc: link onboarding to contributing guide
Replace the description of the commit message requirements in onboarding.md with a link to the commit message requirements as they appear in the CONTRIBUTING.md. Advantages include: * Only one place to keep the commit message requirements up to date * Most collaborators being onboarded will already have several commits in their name and already be familiar with the requirements. So repeating information here makes finding the new information (about metadata, for example) harder to find. PR-URL: #8529 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eebecef - Browse repository at this point
Copy the full SHA eebecefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82b7894 - Browse repository at this point
Copy the full SHA 82b7894View commit details -
- Added dots to printed commands. - Use spaces instead of tabs so there's no misalignment on terminals with a tab size other than 4. - Improved the help text for .editor and .help. - Automatically indent command help based on the longest command. PR-URL: #8519 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 8c91a9b - Browse repository at this point
Copy the full SHA 8c91a9bView commit details -
doc/json: make sure links are correctly passed to marked
Previously, an attempt was made to make sure the links state is inherited. Unfortunately, this support was not complete, which results in various unresolved links in the JSON output (as an example, [1] contains `initialized by calling [<code>buf.fill(fill, encoding)</code>][<code>buf.fill()</code>]`). This commit completes that attempt. After this commit, individual instances of the parser (for descriptions) inherit the links state from the root lexer, so that individual Markdown links in descriptions could be resolved. That same example is now substituted with `initialized by calling <a href=\"#buffer_buf_fill_value_offset_end_encoding\"><code>buf.fill(fill, encoding)</code></a>`. [1]: https://nodejs.org/api/buffer.json PR-URL: #8494 Reviewed-By: Roman Reiss <me@silverwind.io>
1Configuration menu - View commit details
-
Copy full SHA for 8684cea - Browse repository at this point
Copy the full SHA 8684ceaView commit details -
test: improve test-https-agent.js
On line 40: replace '==' with '===' On line 52: replace 'assert.equal' with 'assert.strictEqual' Added some comments. Changed 'var' to 'const' where possible. Replaced console.log(res.statusCode); with and assertion. Rather than logging the https request status on every loop it will now assert the https status is correct on every loop. Changed the error listener to throw the error rather than log it. PR-URL: #8517 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b10467c - Browse repository at this point
Copy the full SHA b10467cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee319b7 - Browse repository at this point
Copy the full SHA ee319b7View commit details -
doc: fix a formatting error in buffer.md
It was treated as a link to "e.g. `Uint8Array.from()`". PR-URL: #8553 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2d23227 - Browse repository at this point
Copy the full SHA 2d23227View commit details -
doc: remove extra comma in cluster docs
PR-URL: #8557 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 64b79eb - Browse repository at this point
Copy the full SHA 64b79ebView commit details -
PR-URL: #8527 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a91050c - Browse repository at this point
Copy the full SHA a91050cView commit details -
tls: add 'new' keyword for Array constructor call
PR-URL: #8514 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b0234e7 - Browse repository at this point
Copy the full SHA b0234e7View commit details -
doc: update exercise portion of onboarding doc
PR-URL: #8559 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for e16f95d - Browse repository at this point
Copy the full SHA e16f95dView commit details -
buffer: remove unnecessary argument check
In Buffer.prototype.compare, the first check makes sure that target is an instance of Buffer. The value cannot be falsy after that so we can safely get its length. PR-URL: #8552 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3fcdf4e - Browse repository at this point
Copy the full SHA 3fcdf4eView commit details -
test: improve coverage of the buffer module
Add tests for untested branches and statements. Also convert some lines to const. PR-URL: #8552 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ba88f5b - Browse repository at this point
Copy the full SHA ba88f5bView commit details -
doc: fix broken link in timers doc
PR-URL: #8562 Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2f6101e - Browse repository at this point
Copy the full SHA 2f6101eView commit details -
fs: fix handling of
uv_stat_t
fields`FChown` and `Chown` test that the `uid` and `gid` parameters they receive are unsigned integers, but `Stat()` and `FStat()` would return the corresponding fields of `uv_stat_t` as signed integers. Applications which pass those these values directly to `Chown` may fail (e.g. for `nobody` on OS X, who has an `uid` of `-2`, see e.g. nodejs/node-v0.x-archive#5890). This patch changes the `Integer::New()` call for `uid` and `gid` to `Integer::NewFromUnsigned()`. All other fields are kept as they are, for performance, but strictly speaking the respective sizes of those fields aren’t specified, either. Ref: npm/npm#13918 PR-URL: #8515 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> undo accidental change to other fields of uv_fs_stat
Configuration menu - View commit details
-
Copy full SHA for 07d97f4 - Browse repository at this point
Copy the full SHA 07d97f4View commit details -
test: improve child_process tests
Replaced var keyword with const and let in the tests for child process stdin and stdio. PR-URL: #8617 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 9c3d521 - Browse repository at this point
Copy the full SHA 9c3d521View commit details -
Replace equal with strictEqual, use const instead of var Replace throw error with assert.ifError PR-URL: #8577 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for a89deb9 - Browse repository at this point
Copy the full SHA a89deb9View commit details -
test: refactored test-crypto-random.js
Replaced `var` by `const` for constant variables, enforced strict equality check, and replaced custom callback execution check by `common.mustCall`. PR-URL: #8632 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 28d009b - Browse repository at this point
Copy the full SHA 28d009bView commit details -
doc: add link to help repo in README
Include link to Node.js help repo (for end user questions on how to use Node.js) in the README. PR-URL: #8570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 42386d7 - Browse repository at this point
Copy the full SHA 42386d7View commit details -
test: improve coverage of the util module
Add tests for untested branches and statements. Change assert.equal to assert.strictEqual for consistency. PR-URL: #8633 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Configuration menu - View commit details
-
Copy full SHA for 1aa1740 - Browse repository at this point
Copy the full SHA 1aa1740View commit details -
test: replace var by const test-tls-zero-clear-in
PR-URL: #8621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 9032ba6 - Browse repository at this point
Copy the full SHA 9032ba6View commit details -
test: cleanup test-child-process-disconnect.js
Changed var --> const and let Changed assert.equal --> assert.strictEqual PR-URL: #8602 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 14025db - Browse repository at this point
Copy the full SHA 14025dbView commit details -
Improved variables to be all const. Enforced assert.strictEqual across all tests. Modified haveIntl tests to check for int. Fixed alignment. PR-URL: #8641 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for f2f6353 - Browse repository at this point
Copy the full SHA f2f6353View commit details -
build: run
npm install
for doc builds in tarballRun `npm install` before building the documentation from release tarballs. The doctool currently depends on `js-yaml`, which is imported from the `tools/eslint` subtree; however, release tarballs don’t contain that directory. Running `npm install` is clearly not a beautiful solution, but it works. Fixes: #7872 PR-URL: #8413 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a425c4d - Browse repository at this point
Copy the full SHA a425c4dView commit details -
PR-URL: #8579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 7728f95 - Browse repository at this point
Copy the full SHA 7728f95View commit details -
tools: clean up icu/README.md formatting
1. Normalize headings. 2. Specify language in all code blocks. PR-URL: #8660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for a12ff5c - Browse repository at this point
Copy the full SHA a12ff5cView commit details -
test: modernize JS and tighten equality checking
Changed var --> const and let. Changed assert.equal !== --> assert.notStrictEqual Correctly aligned argument PR-URL: #8580 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for fc6b497 - Browse repository at this point
Copy the full SHA fc6b497View commit details -
test: var variables to const in zlib
Changes in test-zlib-from-string is because var->const pushed us over the max char limit per line. PR-URL: #8627 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for fd7f87e - Browse repository at this point
Copy the full SHA fd7f87eView commit details -
test: cleanup cluster-disconnect-unshared-tcp test
Replaced var with const PR-URL: #8598 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6fb8ebd - Browse repository at this point
Copy the full SHA 6fb8ebdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d72a7b3 - Browse repository at this point
Copy the full SHA d72a7b3View commit details -
src: use MaybeStackBuffer on DoSend/Writev
instead of creating own buffer, use MaybeStackBuffer on DoSend to take advantage of its destructor to free up memory, so buffer never leaks memory - even if code in DoSend throws. Use MaybeStackBuffer in Writev to take advantage of destructor on MaybeStackBuffer to clear itself up, rather than Writev managing resources itself. PR-URL: #8626 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 52f0f64 - Browse repository at this point
Copy the full SHA 52f0f64View commit details -
util: don't init Debug if it's not needed yet
Because any call to util.inspect() with an object results in inspectPromise() being called, Debug was being initialized even when it's not needed. Instead, the initialization is placed after the isPromise check. PR-URL: #8452 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Configuration menu - View commit details
-
Copy full SHA for 38be155 - Browse repository at this point
Copy the full SHA 38be155View commit details -
test,lib: align arguments in multiline calls
An upcoming custom lint rule will provide slightly more strict enforcement of argument alignment for multiline function calls. Adjust existing code to conform. PR-URL: #8642 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4492cc3 - Browse repository at this point
Copy the full SHA 4492cc3View commit details -
tools: make argument alignment linting more strict
A few nits in recent PR comments suggest that we can have slightly more strict linting for argument alignment in multiline function calls. This enables the existing linting requirements to apply when one or more of the arguments themselves are function calls. Previously, that situation had been excluded from linting. Refs: #8628 (comment) PR-URL: #8642 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ac6927f - Browse repository at this point
Copy the full SHA ac6927fView commit details -
test: refactor parallel/test-tcp-wrap-listen
PR-URL: #8640 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 34f24e5 - Browse repository at this point
Copy the full SHA 34f24e5View commit details -
test: modernize js and tighten equality checking
Changed var --> const and let. Changed assert.notEqual --> assert.notStrictEqual Fixed comment spelling PR-URL: #8618 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3ddf77f - Browse repository at this point
Copy the full SHA 3ddf77fView commit details -
lib: changed var to const in bootstrap_node.js
PR-URL: #8588 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 858a7bb - Browse repository at this point
Copy the full SHA 858a7bbView commit details -
doc: clarify fs.utimes() arguments
Make it clear that atime and mtime should be in seconds. PR-URL: #8651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 5dd6229 - Browse repository at this point
Copy the full SHA 5dd6229View commit details -
test: changing equal to strictEqual in path
PR-URL: #8628 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a59ca6 - Browse repository at this point
Copy the full SHA 5a59ca6View commit details -
test: update test-cluster-disconnect-unshared-udp
Changed var to const PR-URL: #8599 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for bcba27e - Browse repository at this point
Copy the full SHA bcba27eView commit details -
test: cleanup test-child-process-buffering.js
PR-URL: #8578 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 5e5a1c0 - Browse repository at this point
Copy the full SHA 5e5a1c0View commit details -
test: cleanup test-tls-connect-given-socket.js
Changed vars to consts and lets, assert.equals to assert.strictEquals and added common.mustCall around callbacks. Switched to arrow functions. PR-URL: #8616 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 3269a7d - Browse repository at this point
Copy the full SHA 3269a7dView commit details -
test: cleanup test-child-process-exec-env.js
Replace equal with strictEqual, use const instead of var and improve test with use of assert.notStrictEqual PR-URL: #8600 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for c98d0c9 - Browse repository at this point
Copy the full SHA c98d0c9View commit details -
zlib: fix raw inflate with custom dictionary
Moves inflateSetDictionary right after inflateInit2 when mode is INFLATERAW, since without the wrapper in appears zlib won't return Z_NEED_DICT as it would otherwise, and will thus attempt inflating without the dictionary, leading to an error. Fixes: #8507 PR-URL: #8512 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1547495 - Browse repository at this point
Copy the full SHA 1547495View commit details -
zlib: tighten up dictionary tests
Uses const where possible, removes inaccurate comments, prefers strictEqual where possible, ensures functions with assertions are called and enures the inflater has correct encoding set. PR-URL: #8512 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7403aaa - Browse repository at this point
Copy the full SHA 7403aaaView commit details -
test: improve test-child-process-stdout-flush
Changed vars to const / let, functions to arrow functions and a mustCall where appropriate. PR-URL: #8581 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c664109 - Browse repository at this point
Copy the full SHA c664109View commit details -
test: update test-child-process-recv-handle
change var to const/let where appropriate use strictEqual instead of equal call toString on buffers in strictEqual asserts use common.mustCall on callbacks containing asserts PR-URL: #8648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 714cbfd - Browse repository at this point
Copy the full SHA 714cbfdView commit details -
tools: add eslint rule prefer-assert-methods
PR-URL: #8622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 73d54a6 - Browse repository at this point
Copy the full SHA 73d54a6View commit details -
src: handle thrown errors in CopyProperties()
This commit prevents thrown JavaScript exceptions from crashing the process in node_contextify's CopyProperties() function. Fixes: #8537 PR-URL: #8649 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2dbef79 - Browse repository at this point
Copy the full SHA 2dbef79View commit details -
test: refactor test-dgram-bind-shared-ports.js
Refactored the code to latest standards, where all var is changed to const, functions are changed to arrow functions and assert.equal chaned to assert.strictEqual PR-URL: #8582 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for d4ad8d9 - Browse repository at this point
Copy the full SHA d4ad8d9View commit details -
process: changed var to const in internal/process/promises
PR-URL: #8620 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e8f1cf1 - Browse repository at this point
Copy the full SHA e8f1cf1View commit details -
dns: handle array holes in setServers()
This commit adds better handling of exceptional array formats passed to dns.setServers(). Prior to this commit, the input array was validated using map(), which preserves holes, allowing them to be passed to c-ares, crashing Node. This commit replaces map() with forEach(), which skips holes. Fixes: #8538 PR-URL: #8567 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4e8c037 - Browse repository at this point
Copy the full SHA 4e8c037View commit details -
doc: add ak239 to collaborators
PR-URL: #8676 Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 85ee89e - Browse repository at this point
Copy the full SHA 85ee89eView commit details -
https: fix memory leak with https.request()
If calling `https.request()` with `options.headers.host` defined and `options.servername` undefined, `https.Agent.createSocket` mutates connection `options` after `https.Agent.addRequest` has created empty socket pool array with mismatching connection name. This results in two socket pool arrays being created and only the last one gets eventually deleted by `removeSocket` - causing a memory leak. This commit fixes the leak by making sure that `addRequest` does the same modifications to `options` object as the `createSocket`. `createSocket` is intentionally left unmodified to prevent userland regressions. Test case included. PR-URL: #8647 Fixes: #6687 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7a59449 - Browse repository at this point
Copy the full SHA 7a59449View commit details -
Moved from var to const. Moved from .equal to .strictEqual. Added more checks about the type of the returned values. PR-URL: #8606 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for edf9242 - Browse repository at this point
Copy the full SHA edf9242View commit details -
tools: add additional ESLint rules
PR-URL: #8643 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@keybase.io>
Configuration menu - View commit details
-
Copy full SHA for 5c6284a - Browse repository at this point
Copy the full SHA 5c6284aView commit details -
doc: add eugeneo to collaborators
PR-URL: #8696 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 28264f8 - Browse repository at this point
Copy the full SHA 28264f8View commit details -
tools: update remark configuration
Specify the plugin name as 'remark-lint/', as new remark-cli refused to find it when cwd is different from the directory where node_modules are put. Trailing slash fixes this, as the plugin name gets treated as a path, so `require` works on it. Explicitly specify the list of rules we want to enable, as the new remark-lint is opt-in and doesn't come with any rules by default. Reorder the rules alphabetically. PR-URL: #8666 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0310655 - Browse repository at this point
Copy the full SHA 0310655View commit details -
test: fixup parallel/test-async-wrap-post-did-throw.js
* change var to let * replace equal with strictEqual PR-URL: #8625 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1b494d3 - Browse repository at this point
Copy the full SHA 1b494d3View commit details -
process: changed var to const in internal/v8_prof_processor
PR-URL: #8619 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 37ce6da - Browse repository at this point
Copy the full SHA 37ce6daView commit details -
lib: changed var to const in internal/v8_polyfill
PR-URL: #8615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for beb288b - Browse repository at this point
Copy the full SHA beb288bView commit details -
test: update test/parallel/test-fs-read.js
* Replace equal with strictEqual * Update functions to arrow functions PR-URL: #8596 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6924a4d - Browse repository at this point
Copy the full SHA 6924a4dView commit details -
test: update test/parallel/test-child-process-send-utf8.js
change var to const use arrow function in callback use strict equal PR-URL: #8594 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 43d6212 - Browse repository at this point
Copy the full SHA 43d6212View commit details -
src: remove unneeded ABORT after CHECK
CHECK includes node::Abort(), so that's unneeded to call ABORT after CHECK. PR-URL: #8593 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 5ebce30 - Browse repository at this point
Copy the full SHA 5ebce30View commit details -
test: update test/parallel/test-eval.js
Changed var -> const and assert.equal -> assert.strictEqual PR-URL: #8590 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fef4341 - Browse repository at this point
Copy the full SHA fef4341View commit details -
test: update test/parallel/test-child-process-stdio.js
Refs: nodejs/code-and-learn#56(comment) Replace the equal assetion with strictEqual. Replace the notEqual assertion with strictNotEqual. PR-URL: #8584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dfd022f - Browse repository at this point
Copy the full SHA dfd022fView commit details -
doc: add CTC meeting minutes 2016-08-24
PR-URL: #8423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 98ca442 - Browse repository at this point
Copy the full SHA 98ca442View commit details -
const and let instead var assert.strictEqual instead assert.equal PR-URL: #8668 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9ca8722 - Browse repository at this point
Copy the full SHA 9ca8722View commit details -
dns: tweak regex for IPv6 addresses
The regex used in `dns.setServers()` to match IPv6 addresses in square brackets uses a capturing group for the port but this info is not needed. This commit replaces the capturing group with a non capturing one. PR-URL: #8665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7875589 - Browse repository at this point
Copy the full SHA 7875589View commit details -
process: changed var to const in internal/process.js
PR-URL: #8614 Refs: nodejs/code-and-learn#56 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for e0c10f6 - Browse repository at this point
Copy the full SHA e0c10f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8282d6f - Browse repository at this point
Copy the full SHA 8282d6fView commit details -
Most of the docs recommend `make -j8`. The one exception is the pull request template which recommends `make -j4`. This changes the pull request template so that it is in line with the other docs. PR-URL: #8678 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5c014bb - Browse repository at this point
Copy the full SHA 5c014bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9491f1 - Browse repository at this point
Copy the full SHA a9491f1View commit details -
test: remove call to
net.Socket.resume()
In test parallel/child-process-fork-net2 `net.Socket.resume()` is not necessary since `net.Socket.pause()` is never called. PR-URL: #8679 Refs: #4640 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for b62735a - Browse repository at this point
Copy the full SHA b62735aView commit details -
test: enable cyrillic punycode test case
The test from RFC 3492 contains a bug: the uppercase D in the input should be lowercased. Fix that and enable the test. Fixes: #8691 PR-URL: #8695 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9d1426 - Browse repository at this point
Copy the full SHA e9d1426View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ddfe89 - Browse repository at this point
Copy the full SHA 6ddfe89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 296254f - Browse repository at this point
Copy the full SHA 296254fView commit details -
test: add tests for add/remove header after sent
This change adds tests to make sure an Error is thrown if a header is added or removed after they are sent. PR-URL: #8682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for ed625fe - Browse repository at this point
Copy the full SHA ed625feView commit details -
src: don't abort when c-ares initialization fails
Throw a JS exception instead of aborting so the user at least has a fighting chance of understanding what went wrong. Fixes: #8699 PR-URL: #8710 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 9205edc - Browse repository at this point
Copy the full SHA 9205edcView commit details -
path: fallback to process cwd when resolving drive cwd
The `path.resolve()` function when given just a drive letter such as "C:" tries to get a drive-specific CWD, but that isn't available in cases when the process is not launched via cmd.exe and the process CWD has not been explicitly set on that drive. This change adds a fallback to the process CWD, if the process CWD happens to be on the resolved drive letter. If the process CWD is on another drive, then a drive-specific CWD cannot be resolved and defaults to the drive's root as before. Based on experimentation, the fixed behavior matches that of other similar path resolution implementations on Windows I checked: .NET's `System.IO.Path.GetFullPath()` and Python's `os.path.abspath()`. In the automated path test cases the issue doesn't occur when the tests are run normally from cmd.exe. But it did cause an assertion when running the tests from PowerShell, that is fixed by this change. PR-URL: #8541 Fixes: #7215 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0eaf3ff - Browse repository at this point
Copy the full SHA 0eaf3ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5540e3d - Browse repository at this point
Copy the full SHA 5540e3dView commit details -
Added note about vcbuild being included as batch to clarify that it's not needed from msbuild tools or visual studio. PR-URL: #8704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f13089b - Browse repository at this point
Copy the full SHA f13089bView commit details -
test: cleanup vars to const and '==' to '==='
Modified test-http-upgrade-client.js Line 29: Changed var port to const port Line 30: Changed var headers to const headers Line 57: Changed assert.equal to assert.strictEqual Line 61: Changed var expectedHeaders to const Line 69: Changed '==' to '===' comparison PR-URL: #8705 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for b46d8cd - Browse repository at this point
Copy the full SHA b46d8cdView commit details -
test: add expectWarning to common
There are multiple tests that use the same boilerplate to test that warnings are correctly emitted. This adds a new common function to do that and changes the tests to use it. PR-URL: #8662 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: test/parallel/test-buffer-deprecated.js test/parallel/test-repl-deprecated.js
Configuration menu - View commit details
-
Copy full SHA for aa5a16a - Browse repository at this point
Copy the full SHA aa5a16aView commit details -
benchmark: add benchmark for destructuring object
PR-URL: #8680 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 999f727 - Browse repository at this point
Copy the full SHA 999f727View commit details -
src: rename handle__ to handle_ in HandleWrap
Commit 4663393 (src: pull OnConnection from pipe_wrap and tcp_wrap) removed the private handle_ member from TCPWrap which should allow us to rename the private handle__ member in HandleWrap. PR-URL: #8712 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 41ad6e3 - Browse repository at this point
Copy the full SHA 41ad6e3View commit details -
src: fix minor typo in comments
Correcting a couple of minor spelling typos in comments. PR-URL: #8736 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 8be818e - Browse repository at this point
Copy the full SHA 8be818eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fab334 - Browse repository at this point
Copy the full SHA 6fab334View commit details -
test: skip cpu-intensive tests on slow hosts
The `test-tick-processor-*` tests are now passing everywhere except for the single-processor 700MHz Raspberry Pi 1 devices. The tests are CPU-intensive. Skip the tests if there is only one CPU and it runs at a speed not more than 700 MHz. PR-URL: #8652 Reviewed-By: Matthew Loring <mattloring@google.com>
Configuration menu - View commit details
-
Copy full SHA for 9062838 - Browse repository at this point
Copy the full SHA 9062838View commit details -
tools: enable more remark-lint rules
New rules: 1. rule-style 2. strong-marker 3. no-shell-dollars 4. no-inline-padding 5. code-block-style 6. no-multiple-toplevel-headings Fixes to the existing files applied. PR-URL: #8708 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 336d505 - Browse repository at this point
Copy the full SHA 336d505View commit details -
http: socket connection timeout for http request
This allows passing the socket connection timeout to http#request such that it will be set before the socket is connecting PR-URL: #8101 Fixes: #7580 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for ee7af01 - Browse repository at this point
Copy the full SHA ee7af01View commit details -
We documented most types as Integer, but we don't have link for that. PR-URL: #8740 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for d69570d - Browse repository at this point
Copy the full SHA d69570dView commit details -
test: accept expected AIX result test-stdio-closed
AIX handles closed stdio differently (but still compliant with spec as far as I can tell) than other POSIX variants we test. Test results are different than Linux and others because AIX takes measures to not re-use the file descriptors for stdio if one of the stdio streams is closed. Fixes: #8375 PR-URL: #8755 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Conflicts: test/parallel/parallel.status
Configuration menu - View commit details
-
Copy full SHA for 5e4d898 - Browse repository at this point
Copy the full SHA 5e4d898View commit details -
util: Add format for SharedArrayBuffer
PR-URL: #8587 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for fc68b12 - Browse repository at this point
Copy the full SHA fc68b12View commit details -
benchmark: use 'yes' instead of echo in a loop
This changes child-process-exec-stdout benchmark to use 'yes' instead of echo in a while loop. This makes this benchmark consistent with child-process-read which already uses `yes` and allows this benchmark to be executed on Windows. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #8721
Configuration menu - View commit details
-
Copy full SHA for 882f8b3 - Browse repository at this point
Copy the full SHA 882f8b3View commit details -
doc: improve child_process doc types
PR-URL: #8741 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3aec6a6 - Browse repository at this point
Copy the full SHA 3aec6a6View commit details -
Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #8748
Configuration menu - View commit details
-
Copy full SHA for b2aea50 - Browse repository at this point
Copy the full SHA b2aea50View commit details -
doc,tool: add tls.TLSSocket to typeMap
We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap PR-URL: #8742 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d6dcbc2 - Browse repository at this point
Copy the full SHA d6dcbc2View commit details -
buffer: fix performance regression
V8 5.4 changed the way that the default constructor of derived classes is called. It introduced a significant performance regression in the buffer module for the creation of pooled buffers. This commit forces the definition back to how it was implicitly before. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=4890 PR-URL: #8754 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for b9c2270 - Browse repository at this point
Copy the full SHA b9c2270View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a6e898 - Browse repository at this point
Copy the full SHA 1a6e898View commit details -
test: add assertions to zero length buffer test
1) Add missing assertion that slicing a 0 length buffer does not throw 2) Add assertion that slicing a 0 length buffer has a length of 0 PR-URL: #8729 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 81ed50c - Browse repository at this point
Copy the full SHA 81ed50cView commit details -
test: changed var to const, added strict equal checks
Changed var to const where appropriate. Substituted assert.strictEqual for assert.equal for better type checks. PR-URL: #8762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6ba8aa9 - Browse repository at this point
Copy the full SHA 6ba8aa9View commit details -
test: cleanup parallel/test-fs-realpath.js
Replaced .indexOf() with .includes() for more clarity as to what it is doing. Many of the instances of var changed to const. Instances of assert.equal() refactored to assert.strictEqual() or assert.ifError() Removed the unlinkSync() call in the exit event handler because it probably only handles files in the testing tmp directory so there is no need to unlink them. PR-URL: #8769 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 9252e7a - Browse repository at this point
Copy the full SHA 9252e7aView commit details -
test: cleanup parallel/test-file-write-stream2.js
replace ==, !=, some instances of var, and assert.equal() PR-URL: #8770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for f523b82 - Browse repository at this point
Copy the full SHA f523b82View commit details -
test: cleanup parallel/test-fs-readfile-unlink.js
Changes var to const, != to !==, and assert.equal() to assert.strict Equal() PR-URL: #8764 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 5bd13a3 - Browse repository at this point
Copy the full SHA 5bd13a3View commit details -
doc: enable first-heading-level remark-lint rule
This makes sure that the first heading in all markdown files is h1. Only three files needed to be changed to conform: 1. BUILDING.md 2. CODE_OF_CONDUCT.md 3. doc/onboarding-extras.md Also, .remarkrc is updated to include the `first-heading-level: 1` rule in order to catch similar issues in the future. PR-URL: #8716 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4699e30 - Browse repository at this point
Copy the full SHA 4699e30View commit details -
test: update var to const, use arrow functions
PR-URL: #8595 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 76fd7db - Browse repository at this point
Copy the full SHA 76fd7dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e95b0e - Browse repository at this point
Copy the full SHA 2e95b0eView commit details -
doc: enable no-file-name-articles remark-lint rule
This renames doc/topics/the-event-loop-timers-and-nexttick.md to doc/topics/event-loop-timers-and-nexttick.md, which looks like a better name for that file and enables no-file-name-articles remark-lint rule to prevent such names in the future. PR-URL: #8713 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4fb0514 - Browse repository at this point
Copy the full SHA 4fb0514View commit details -
doc: add added: info for crypto.timingSafeEqual()
crypto.timingSafeEqual() has been added in v6.6.0 cf. #8304 This commit adds the metadata that will display "Added in: v6.6.0" and that can later be checked on https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b PR-URL: #8796 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for e7c0f34 - Browse repository at this point
Copy the full SHA e7c0f34View commit details -
doc: fix title level at tls.md
PR-URL: #8782 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 98e425e - Browse repository at this point
Copy the full SHA 98e425eView commit details -
doc: add commit formats for release blog posts
this commit enhances the guidelines to creating a release blog post, specifically by adding a commit format that must be adhered to when creating a pull request on the website repository Fixes: #8629 PR-URL: #8631 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@keybase.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0522aa0 - Browse repository at this point
Copy the full SHA 0522aa0View commit details -
tls: improve createSecureContext in _tls_common
- this shares the iterator variable `i` expictly. - this converts some var to const. PR-URL: #8781 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d2eaa12 - Browse repository at this point
Copy the full SHA d2eaa12View commit details -
src: rename CHECK_NOT_OOB() macro
Rename CHECK_NOT_OOB() to THROW_AND_RETURN_IF_OOB() because the old name suggests it asserts and aborts when it is really a control flow macro. PR-URL: #8784 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aa11205 - Browse repository at this point
Copy the full SHA aa11205View commit details -
doc: remove failing workaround in BUILDING.md
Updated BUILDING.md, removing workaround for Python conflicts that didn't work. PR-URL: #8763 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: James M Snell <jasnell@gmail.com> Refs: #8763
Configuration menu - View commit details
-
Copy full SHA for dceaa0b - Browse repository at this point
Copy the full SHA dceaa0bView commit details -
test:replace indexOf, assert.equal, add mustCall()
replace indexOf with includes replace assert.equal with assert.strictEqual add common.mustCall replace throw error with assert.ifError PR-URL: #8766 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for af84528 - Browse repository at this point
Copy the full SHA af84528View commit details -
doc: add optional step to onboarding doc
Include information on how to force push to the contributor's own branch so that pull requests show as merged in GitHub interface. PR-URL: #8774 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f07054d - Browse repository at this point
Copy the full SHA f07054dView commit details -
doc: encourage 2FA before onboarding
In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories. PR-URL: #8776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aaebbf9 - Browse repository at this point
Copy the full SHA aaebbf9View commit details -
doc: improve documentation for commit subject line
Specify that commit subject line must be made of only lowercase words and should start with an imperative verb. PR-URL: #8546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for a00ae75 - Browse repository at this point
Copy the full SHA a00ae75View commit details -
test: cleanup test-net-server-address.js
Refactored test: - 'var' to 'const' - functon to arrow function - using common.mustCall() and common.fail() PR-URL: #8586 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for af092f1 - Browse repository at this point
Copy the full SHA af092f1View commit details -
test: clean up test-buffer-badhex
This test was recently (at the time of writing) introduced in 151d316 and could be cleaned up a bit. Refs: #7602 PR-URL: #7773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6dbda6a - Browse repository at this point
Copy the full SHA 6dbda6aView commit details -
dns: remove internal variable from makeAsync
PR-URL: #8800 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for e1a774d - Browse repository at this point
Copy the full SHA e1a774dView commit details -
fs,module: add module-loader-only realpath cache
Reintroduce a realpath cache with the same mechanisms which existed before b488b19 (`fs: optimize realpath using uv_fs_realpath()`), but only for the synchronous version and with the cache being passed as a hidden option to make sure it is only used internally. The cache is hidden from userland applications because it has been decided that fully reintroducing as part of the public API might stand in the way of future optimizations. PR-URL: #8100 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 980c1ed - Browse repository at this point
Copy the full SHA 980c1edView commit details -
PR-URL: #8826 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3e8c8f9 - Browse repository at this point
Copy the full SHA 3e8c8f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fa0fc5 - Browse repository at this point
Copy the full SHA 4fa0fc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72de859 - Browse repository at this point
Copy the full SHA 72de859View commit details -
test: modernize syntax, add strict checks
Changed `var` to `const`, strings to template literals, and assert.equal to assert.strictEqual where appropriate. PR-URL: #8841 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for fc42825 - Browse repository at this point
Copy the full SHA fc42825View commit details -
src: add missing length argument to send comment
The list.length argument is missing from the comment and just adding this for clarity. PR-URL: #8816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 86b9db6 - Browse repository at this point
Copy the full SHA 86b9db6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 324c8b5 - Browse repository at this point
Copy the full SHA 324c8b5View commit details -
test: cleanup/update test-os.js
Replaced `==` with `=== Replaced `indexOf(...) !== -1` with `includes()` PR-URL: #8761 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for bc710ef - Browse repository at this point
Copy the full SHA bc710efView commit details -
timers: improve setTimeout/Interval performance
This commit improves timers performance by making functions inlineable and avoiding the creation of extra closures/functions. This commit also makes setTimeout/Interval argument handling consistent with that of setImmediate. These changes give ~22% improvement in the existing 'breadth' timers benchmark. PR-URL: #8661 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 06c4117 - Browse repository at this point
Copy the full SHA 06c4117View commit details -
test: add and assert readable/writable arguments
Currently the readable and writable arguments are not specified in the req.oncomplete method. Adding and asserting that they are always true (which is always the case for TCP). This might seem unnecessary but it can't hurt to have them to pickup any breaking modifications made to ConnectionWrap::AfterConnect in the future. PR-URL: #8815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 17922de - Browse repository at this point
Copy the full SHA 17922deView commit details -
ares_create_query: avoid single-byte buffer overwrite
Incorrect string length calculation when passing escaped dot. - CVE: CVE-2016-5180 - Upstream bug: https://c-ares.haxx.se/adv_20160929.html PR-URL: #8849 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 23a851d - Browse repository at this point
Copy the full SHA 23a851dView commit details -
test: clean up test-timers-immediate
Clean up test-timers-immediate. Use of `let` also requires a tweak to ESLint rules (but it's one that we should do as timers is pretty much the reason it exists). PR-URL: #8857 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c9450ce - Browse repository at this point
Copy the full SHA c9450ceView commit details -
src: refactor reading of options in contextify
Refactor various functions that read values from the contextify options object. Rather than passing args and the index, pass the value at that index. We use env->isolate() rather than args.GetIsolate(), but since env was constructed from args, this is the same isolate. PR-URL: #8850 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a6b9ffb - Browse repository at this point
Copy the full SHA a6b9ffbView commit details -
cluster: remove unused backlog argument
PR-URL: #8877 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3d3bce6 - Browse repository at this point
Copy the full SHA 3d3bce6View commit details -
PR-URL: #8890 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 573d8bc - Browse repository at this point
Copy the full SHA 573d8bcView commit details -
module: fix comment from "read-only" to "shallow"
The comment here was misleading, implying that the property was being copied as a read-only, when in fact it's just a shallow copy. This serves the purpose of providing the array for introspection, but it isn't read-only. PR-URL: #8887 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 31232ad - Browse repository at this point
Copy the full SHA 31232adView commit details -
build: don't build icu with -fno-rtti
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a202be6 - Browse repository at this point
Copy the full SHA a202be6View commit details -
src: remove unused function declaration
PR-URL: #8878 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d8df78c - Browse repository at this point
Copy the full SHA d8df78cView commit details -
test: expand test coverage for url.js
Currently, line 156 of lib/url.js is not reachable from test-url because there is no example URL which has a white space in the front of the url. I added one example which can reach that line. PR-URL: #8859 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Franziska Hinkelmann <fhinkel@vt.edu>
Configuration menu - View commit details
-
Copy full SHA for 11ba56c - Browse repository at this point
Copy the full SHA 11ba56cView commit details -
doc: add CTC meeting minutes 2016-09-21
PR-URL: #8727 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 505b88d - Browse repository at this point
Copy the full SHA 505b88dView commit details -
doc: add CTC meeting minutes 2016-09-14
PR-URL: #8726 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 77fc5ca - Browse repository at this point
Copy the full SHA 77fc5caView commit details -
test: fix running child-process-uid-gid as root
This skips the child-test-uid-gid test when run as root. Previously, the test failed if executed as root. PR-URL: #8864 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 76f80a3 - Browse repository at this point
Copy the full SHA 76f80a3View commit details -
Teach gtest to produce TAP so we can integrate it better with our CI tooling. TAP is printed to stdout but it can also be written to file by passing the `--gtest_output=tap:filename.tap` switch to cctest. PR-URL: #8034 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 46af588 - Browse repository at this point
Copy the full SHA 46af588View commit details -
build: run cctests as part of test-ci target
Enable the cctests on the CI now that they know how to write TAP output. PR-URL: #8034 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f057d19 - Browse repository at this point
Copy the full SHA f057d19View commit details -
test: fix -Wformat warnings in inspector cctest
Print size_t and ssize_t using %zd and %zu respectively, not %ld. PR-URL: #8034 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 424c126 - Browse repository at this point
Copy the full SHA 424c126View commit details -
doc: recommend using port 0 instead of common.PORT
In the 'writing_tests' guide it is recommended to use common.PORT instead of an arbitrary value, but the recommendation is to use port 0 instead and the docs should reflect that. PR-URL: #8694 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a604a82 - Browse repository at this point
Copy the full SHA a604a82View commit details -
doc: add documentation for test common module
Alphabetized list of methods and properties for the common.js module. Add table of contents to the top of the readme. PR-URL: #8840 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c36c8dc - Browse repository at this point
Copy the full SHA c36c8dcView commit details -
tls: handle
error
events with_tlsError
Previously `TLSSocket#_emitTLSError` was used as an `error` event handler. However that function can emit `error` event itself, so it is not suitable for such use. Luckily the event can be emitted only when the control is released, so this looping-error can't happen. Replace the error handler for clarity and correctness. PR-URL: #8889 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bee1955 - Browse repository at this point
Copy the full SHA bee1955View commit details -
src: fix build for older clang
Removes use of builtins that are unavailable for older clang. Per benchmarks, only uses builtins on Windows, where speedup is significant. Also adds test for unaligned ucs2 buffer write. Between #3410 and #7645, bytes were swapped twice on bigendian platforms if buffer was not two-byte aligned. See comment in #7645. PR-URL: #7645 Fixes: #7618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: src/node_buffer.cc
Configuration menu - View commit details
-
Copy full SHA for 8a2ba6f - Browse repository at this point
Copy the full SHA 8a2ba6fView commit details -
lib: remove let from for loops
This is a known de-opt. It may not be 100% necessary in all cases but it seems like a decent enough idea to avoid it. PR-URL: #8873 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for ba361a2 - Browse repository at this point
Copy the full SHA ba361a2View commit details -
doc: update punctuation in README.md
PR-URL: #8892 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Configuration menu - View commit details
-
Copy full SHA for ff9a84d - Browse repository at this point
Copy the full SHA ff9a84dView commit details -
test: mark test-tick-processor-unknown flaky
Mark test-tick-processor-unknown flaky on SmartOS. PR-URL: #8900 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Conflicts: test/parallel/parallel.status
Configuration menu - View commit details
-
Copy full SHA for 52d0424 - Browse repository at this point
Copy the full SHA 52d0424View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f0f596 - Browse repository at this point
Copy the full SHA 2f0f596View commit details -
timers: improve setImmediate() performance
This commit avoids re-creating a new immediate queue object every time the immediate queue is processed. Additionally, a few functions are tweaked to make them inlineable. These changes give ~6-7% boost in setImmediate() performance in the existing setImmediate() benchmarks. PR-URL: #8655 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Conflicts: lib/internal/process/promises.js
Configuration menu - View commit details
-
Copy full SHA for 3a72a60 - Browse repository at this point
Copy the full SHA 3a72a60View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7039cd - Browse repository at this point
Copy the full SHA e7039cdView commit details -
test: cleanup/update test-dgram-empty-packet.js
* Changed some `var` to `const` and 'let' * Changed `==` to `===` for clarity. PR-URL: #8896 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5164865 - Browse repository at this point
Copy the full SHA 5164865View commit details -
test: refactor test-file-write-stream
Replace all `var` occurrences in test-file-write-stream.js with `const` (where they are not being reassigned) and `let` (where they are being reassigned). Add strict comparison to the asserts and if statements: - Replace `assert.equal` with `assert.strictEqual` where: 1. Result of `typeof` being compared to a string literal. 2. Result of `fs.readFileSync` with UTF-8 encoding being compared to a string constant. - Replace `==` with `===` where integer values are being compared to integer literals. Remove unnecessary very IIFE. Use template literals. PR-URL: #8894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 93c4874 - Browse repository at this point
Copy the full SHA 93c4874View commit details -
fs,doc: undeprecate existsSync
This has been dragged through various long discussions and has been elevated to the CTC multiple times. As noted in #7455 (comment), while this API is still generally considered an anti-pattern, there are still use-cases it is best suited for, such as checking if a git rebase is in progress by looking if ".git/rebase-apply/rebasing" exists. The general consensus is to undeprecate just the sync version, given that the async version still has the "arguments order inconsistency" problem. The consensus at the two last CTC meetings this came up at was also to undeprecate existsSync() but keep exists() deprecated. See: #8242 & #8330 (Description write-up by @Fishrock123) Fixes: #1592 Refs: #4217 Refs: #7455 PR-URL: #8364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 14e2d67 - Browse repository at this point
Copy the full SHA 14e2d67View commit details -
build: make addons build dep. on node_version.h
Make the `test/addons/.buildstamp` file dependent on `src/node_version.h` since addons need to be re-compiled after `NODE_MODULE_VERSION` bumps, e.g. as it happened recently in b5bdff8. PR-URL: #8861 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 38fdbcd - Browse repository at this point
Copy the full SHA 38fdbcdView commit details -
test: remove blank lines at end of files
In preparation for a lint rule that disallows empty lines at the end of a file, remove such lines from a number of test files. Refs: #8918 PR-URL: #8920 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 636026a - Browse repository at this point
Copy the full SHA 636026aView commit details -
tools: disallow extra blank lines at EOF/BOF
Enabling linting to disallow extra blank lines at the start or end of JavaScript files in our code base. Fixes: #8918 PR-URL: #8920 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 58c5510 - Browse repository at this point
Copy the full SHA 58c5510View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c194ee - Browse repository at this point
Copy the full SHA 4c194eeView commit details -
lib: fix TypeError in v8-polyfill
PR-URL: #8863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6cd5588 - Browse repository at this point
Copy the full SHA 6cd5588View commit details -
test: enable addons test to pass with debug build
Currently when running configure with the --debug option in combination with the tests (./configure --debug && make -j8 test) there are a few addon tests that fail with error messages similar to this: === release test === Path: addons/load-long-path/test fs.js:558 return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode); ^ Error: ENOENT: no such file or directory, open '/nodejs/node/test/addons/load-long-path/build/Release/binding.node' at Object.fs.openSync (fs.js:558:18) at Object.fs.readFileSync (fs.js:468:33) at Object.<anonymous> (/nodejs/node/test/addons/load-long-path/test.js:28:19) at Module._compile (module.js:560:32) at Object.Module._extensions..js (module.js:569:10) at Module.load (module.js:477:32) at tryModuleLoad (module.js:436:12) at Function.Module._load (module.js:428:3) at Module.runMain (module.js:594:10) at run (bootstrap_node.js:382:7) Command: out/Release/node /nodejs/node/test/addons/load-long-path/test.js This commit allows for the tests to pass even if the configured build type is of type debug. PR-URL: #8836 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 147a06d - Browse repository at this point
Copy the full SHA 147a06dView commit details -
PR-URL: #8940 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for c31a317 - Browse repository at this point
Copy the full SHA c31a317View commit details -
doc: add CTC meeting minutes 2016-09-07
PR-URL: #8499 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b212b9b - Browse repository at this point
Copy the full SHA b212b9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc2dd3e - Browse repository at this point
Copy the full SHA bc2dd3eView commit details -
test: refactor test-net-server-max-connections
The test timed out on Windows in CI. Made the following changes: * reduced total connections from 200 to 20 * var -> const * string concatenation -> templates * assert.equal -> assert.strictEqual PR-URL: #8931 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for df0211d - Browse repository at this point
Copy the full SHA df0211dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bdc363 - Browse repository at this point
Copy the full SHA 0bdc363View commit details -
test: run faster and cleanup after run
PR-URL: #8848 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Matthew Loring <mattloring@google.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 9b0733f - Browse repository at this point
Copy the full SHA 9b0733fView commit details -
dgram: use Buffer.alloc(0) for zero-size buffers
There is no difference between alloc(0) and allocUnsafe(0), so there is no reason to confuse anyone reading the code with an additional call to allocUnsafe. PR-URL: #8751 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for c4d9b54 - Browse repository at this point
Copy the full SHA c4d9b54View commit details -
Configuration menu - View commit details
-
Copy full SHA for b579fca - Browse repository at this point
Copy the full SHA b579fcaView commit details -
buffer: fix check for
.buffer
propertyisSharedArrayBuffer in fromObject was missing obj.buffer moved the 'length' in obj check so that it is checked first making the code slightly more performant and able to handle SharedArrayBuffer without relying on an explicit check. Ref: #8510 PR-URL: #8739 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 5c10898 - Browse repository at this point
Copy the full SHA 5c10898View commit details -
lib: changed var to const in linkedlist
PR-URL: #8609 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 313a45d - Browse repository at this point
Copy the full SHA 313a45dView commit details -
doc: add example for file existence with fs.stat
Add an example on how to test if a file exists with fs.stat. Also add a link to the Common System Errors. Fixes: https://github.com/nodejs/issues/6752 PR-URL: #8585 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Configuration menu - View commit details
-
Copy full SHA for 2fad4d2 - Browse repository at this point
Copy the full SHA 2fad4d2View commit details -
lib: minor improvements to bootstrap_node.js
Change '==' to '===' PR-URL: #8906 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Configuration menu - View commit details
-
Copy full SHA for a1925a7 - Browse repository at this point
Copy the full SHA a1925a7View commit details -
win,tools: ignore linting for line breaks
Line breaks on Windows should be CRLF, but Node also supports LF. Hence, do not check line breaks on Windows, when running vcbuild jslint. Fixes: #6912 PR-URL: #8785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 623d3c6 - Browse repository at this point
Copy the full SHA 623d3c6View commit details -
test: fix test-child-process-fork-regr-gh-2847
It's not guaranteed that the first socket that tries to connect is the first that succeeds so the rest of assumptions made in the test are not correct. Fix it by making sure the second socket does not try to connect until the first has succeeded. The IPC channel can already be closed when sending the second socket. It should be allowed. Also, don't start sending messages until the worker is online. Fixes: #8950 PR-URL: #8954 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4e9b6a0 - Browse repository at this point
Copy the full SHA 4e9b6a0View commit details -
doc: make node(1) more consistent with tradition
* Added traditional BUGS, AUTHORS and COPYRIGHT sections * Fixed some minor issues with the IRC links PR-URL: #8902 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72ed6aa - Browse repository at this point
Copy the full SHA 72ed6aaView commit details -
test: expand test coverage for url.js
Add url example with more than 255 characters in the hostname of the url. PR-URL: #8976 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: test/parallel/test-url.js
Configuration menu - View commit details
-
Copy full SHA for c4f0bb2 - Browse repository at this point
Copy the full SHA c4f0bb2View commit details -
tls: TLSSocket emits 'error' on handshake failure
Removes branch that would make TLSSocket emit '_tlsError' event if error occured on handshake and control was not released, as it was never happening. Addedd test for tls.Server to ensure it still emits 'tlsClientError' as expected. Fixes: #8803 PR-URL: #8805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for cf92be6 - Browse repository at this point
Copy the full SHA cf92be6View commit details -
src: fix typo in #endif comment
PR-URL: #8989 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Brian White <mscdex@mscdex.net>
Configuration menu - View commit details
-
Copy full SHA for 59aa103 - Browse repository at this point
Copy the full SHA 59aa103View commit details -
src: remove out-of-date TODO comment
This commit attempts to fix one of the items in #4641, which was to remove a TODO the UDPWrap::OnSend function and share the code in that method with StreamWrap::AfterWrite. While looking into this addaleax pointed out that the implementations for these two functions have diverged since the original comment was added: $ git log --pretty=short -u -L 357,357:src/udp_wrap.cc $ git show cbd4033:src/udp_wrap.cc | grep -1 -A26 'UDPWrap::OnSend' git show cbd4033:src/stream_wrap.cc | grep -A27 'void StreamWrap::AfterWrite' Removing the TODO comment seems appropriate in this case. PR-URL: #9000 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 443bede - Browse repository at this point
Copy the full SHA 443bedeView commit details -
test: various test improvements
* Favor strictEqual * Use const where appropriate * Modernize where possible PR-URL: #8468 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a4207d - Browse repository at this point
Copy the full SHA 1a4207dView commit details -
stream: proper
instanceof
forWritable
sUse `[Symbol.hasInstance]()` to return `true` when asking for `new Duplex() instanceof Writable`. PR-URL: #8834 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4e7c67c - Browse repository at this point
Copy the full SHA 4e7c67cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b83f51a - Browse repository at this point
Copy the full SHA b83f51aView commit details -
test: refactor
assert
in internet test-dns.jschange assert.equal() to assert.strictEqual() and use assert.strictEqual() for type validation PR-URL: #8980 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 05f7412 - Browse repository at this point
Copy the full SHA 05f7412View commit details -
test: add coverage for spawnSync() killSignal
This commit adds a test for the killSignal option to spawnSync(), and the other sync child process functions by extension. PR-URL: #8960 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 56951b4 - Browse repository at this point
Copy the full SHA 56951b4View commit details -
doc: fix typo in email address in README
PR-URL: #8941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5e6be7b - Browse repository at this point
Copy the full SHA 5e6be7bView commit details -
fs: make
SyncWriteStream
inherit fromWritable
Make the internal `SyncWriteStream` a proper `stream.Writable` subclass. This allows for quite a bit of simplification, since `SyncWriteStream` predates the streams2/streams3 implementations. Fixes: #8828 PR-URL: #8830 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> (backport info) Refs: #9030
Configuration menu - View commit details
-
Copy full SHA for 688abac - Browse repository at this point
Copy the full SHA 688abacView commit details -
test,benchmark: fix lint errors on v6.x
PR-URL: #9029 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a7dd18 - Browse repository at this point
Copy the full SHA 5a7dd18View commit details
Commits on Oct 12, 2016
-
2016-10-12, Version 6.8.0 (Current)
* fs: - `SyncWriteStream` now inherits from `Stream.Writable`. (Anna Henningsen) #8830 - Practically, this means that when stdio is piped to a file, stdout and stderr will still be `Writable` streams. - `fs.existsSync()` has been undeprecated. `fs.exists()` remains deprecated. (Dan Fabulich) #8364 * http: `http.request()` now accepts a `timeout` option. (Rene Weber) #8101 * module: The module loader now maintains its own realpath cache. (Anna Henningsen) #8100 * npm: Upgraded to 3.10.8 (Kat Marchán) #8706 * stream: `Duplex` streams now show proper `instanceof Stream.Writable`. (Anna Henningsen) #8834 * timers: Improved `setTimeout`/`Interval` performance by up to 22%. (Brian White) #8661 PR-URL: #9034
Configuration menu - View commit details
-
Copy full SHA for 17145bd - Browse repository at this point
Copy the full SHA 17145bdView commit details